New issue
Advanced search Search tips

Issue 726455 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebAudio test code beautifier issues

Project Member Reported by rtoy@chromium.org, May 25 2017

Issue description

The web audio test code beautifier needs a few changes and feature enhancements:

1. On linux, -i option doesn't work
2. It would nice if layout-test-tidy allowed specifying more than one file on the command line. (I guess this would imply -i, maybe?)
3. layout-test-tidy should be able to work as a unix-style filter.  This is important for integration into an editor

 

Comment 1 Deleted

FYI, the first and second issues are trivial, but the third needs some refactoring effort.
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee1974edc56a4a4d34df3e3e3736080289ae58af

commit ee1974edc56a4a4d34df3e3e3736080289ae58af
Author: Hongchan Choi <hongchan@chromium.org>
Date: Wed May 31 01:04:42 2017

Accept multiple file/path targets and fix in-place processing

This CL fixes few minor issues in layout-test-tidy.js.

- Correctly parse '-i' or '--inplace' option.
- Allow multiple files or paths in command arguments with `-R` option.
- Force the document type to 'html5'.
- Edit README accordingly.

Bug: 726455
Change-Id: Iaa9a403d9d9d288c7d84524a391738ab70948d10
Reviewed-on: https://chromium-review.googlesource.com/517296
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475713}
[modify] https://crrev.com/ee1974edc56a4a4d34df3e3e3736080289ae58af/third_party/WebKit/LayoutTests/webaudio/tools/README.md
[modify] https://crrev.com/ee1974edc56a4a4d34df3e3e3736080289ae58af/third_party/WebKit/LayoutTests/webaudio/tools/layout-test-tidy.js

Sign in to add a comment