New issue
Advanced search Search tips

Issue 726452 link

Starred by 1 user
Status: Fixed
Owner:
hongchan@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 745778



Sign in to add a comment

biquad-testing.js didn't have var converted to let

Project Member Reported by rtoy@chromium.org, May 25 2017 
In the Great WebAudio Test Tidy CL, all uses of "var" were supposed to be converted to "let".  But biquad-testing.js didn't get that change applied.

Most likely cause:  The regexp for this required at least one space before "var".

There may be other files that didn't get this fix.

Comment 1 by hongchan@chromium.org, Jul 14 2017 

The tentative list of files affected by this issue:
https://cs.chromium.org/search/?q=(var%5Cs)+file:%5Esrc/third_party/WebKit/LayoutTests/webaudio/+package:%5Echromium$&type=cs

chromium src/third_party/WebKit/LayoutTests/webaudio/resources/mix-testing.js
chromium src/third_party/WebKit/LayoutTests/webaudio/resources/delay-testing.js
chromium src/third_party/WebKit/LayoutTests/webaudio/resources/biquad-testing.js
chromium src/third_party/WebKit/LayoutTests/webaudio/resources/biquad-filters.js
chromium src/third_party/WebKit/LayoutTests/webaudio/resources/audio-codec-test.js
chromium src/third_party/WebKit/LayoutTests/webaudio/resources/waveshaper-testing.js
chromium src/third_party/WebKit/LayoutTests/webaudio/resources/convolution-testing.js
chromium src/third_party/WebKit/LayoutTests/webaudio/resources/panner-model-testing.js
chromium src/third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js
chromium src/third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js
chromium src/third_party/WebKit/LayoutTests/webaudio/resources/scriptprocessornode-testing.js

Comment 2 by rtoy@chromium.org, Jul 26 2017

Blocking: 745778

Comment 3 by hongchan@chromium.org, Jul 28 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542

commit 0f70a72ce7f1786dea3fe3a7b6bca5695b68d542
Author: Hongchan Choi <hongchan@chromium.org>
Date: Fri Jul 28 20:24:02 2017

Replace var to let in LayoutTests/webaudio/resources/

In the Great WebAudio Test Tidy CL, all uses of "var" were supposed
to be converted to "let". This CL takes care of those missing files.

Bug:  726452 
Change-Id: I030529a52eb7af55126a1f7f48e982a952bbfe79
Reviewed-on: https://chromium-review.googlesource.com/592231
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490498}
[modify] https://crrev.com/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542/third_party/WebKit/LayoutTests/webaudio/resources/audio-codec-test.js
[modify] https://crrev.com/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542/third_party/WebKit/LayoutTests/webaudio/resources/biquad-filters.js
[modify] https://crrev.com/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542/third_party/WebKit/LayoutTests/webaudio/resources/biquad-testing.js
[modify] https://crrev.com/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542/third_party/WebKit/LayoutTests/webaudio/resources/convolution-testing.js
[modify] https://crrev.com/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542/third_party/WebKit/LayoutTests/webaudio/resources/delay-testing.js
[modify] https://crrev.com/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542/third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js
[modify] https://crrev.com/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542/third_party/WebKit/LayoutTests/webaudio/resources/mix-testing.js
[modify] https://crrev.com/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542/third_party/WebKit/LayoutTests/webaudio/resources/panner-model-testing.js
[modify] https://crrev.com/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542/third_party/WebKit/LayoutTests/webaudio/resources/scriptprocessornode-testing.js
[modify] https://crrev.com/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542/third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js
[modify] https://crrev.com/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542/third_party/WebKit/LayoutTests/webaudio/resources/waveshaper-testing.js
[modify] https://crrev.com/0f70a72ce7f1786dea3fe3a7b6bca5695b68d542/third_party/WebKit/LayoutTests/webaudio/tools/layout-test-tidy.js

Comment 5 by hongchan@chromium.org, Jul 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment