New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726437 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Accidental sheet swipes in Chrome Home

Project Member Reported by mdjones@chromium.org, May 25 2017

Issue description

The toolbar being at the bottom of the screen in Chrome Home causes some users to accidentally swipe the sheet up (expanding Chrome Home). We should introduce some heuristics/experiment flags to test possible solutions to this problem.
 
Project Member

Comment 2 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d349741f4b627c2ca2c6a79fb9f77f9c8c437947

commit d349741f4b627c2ca2c6a79fb9f77f9c8c437947
Author: Matthew Jones <mdjones@chromium.org>
Date: Fri May 26 22:07:48 2017

[Home] Add flags for different types of sheet expansion logic

This change introduces an experiment flag to enable different swipe
logic variations for expanding the Chrome Home bottom sheet.

The initial option "restrict-area" limits the horizontal area that
a swipe can be in to open the sheet. This area surrounds the pull
handle, so it feels like you must touch the handle to open the
sheet. Once the sheet is opened, the entire toolbar becomes swipable.

BUG= 726437 

Change-Id: Icf40654bf9c4ac1a37e906f69b887483df536ac8
Reviewed-on: https://chromium-review.googlesource.com/516482
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475156}
[modify] https://crrev.com/d349741f4b627c2ca2c6a79fb9f77f9c8c437947/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
[modify] https://crrev.com/d349741f4b627c2ca2c6a79fb9f77f9c8c437947/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/d349741f4b627c2ca2c6a79fb9f77f9c8c437947/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/d349741f4b627c2ca2c6a79fb9f77f9c8c437947/chrome/browser/about_flags.cc
[modify] https://crrev.com/d349741f4b627c2ca2c6a79fb9f77f9c8c437947/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/d349741f4b627c2ca2c6a79fb9f77f9c8c437947/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/d349741f4b627c2ca2c6a79fb9f77f9c8c437947/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d349741f4b627c2ca2c6a79fb9f77f9c8c437947/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d349741f4b627c2ca2c6a79fb9f77f9c8c437947/chrome/common/chrome_switches.cc
[modify] https://crrev.com/d349741f4b627c2ca2c6a79fb9f77f9c8c437947/chrome/common/chrome_switches.h
[modify] https://crrev.com/d349741f4b627c2ca2c6a79fb9f77f9c8c437947/tools/metrics/histograms/enums.xml

My apologies if this has already been mentioned but, on the iPhone, swiping up from the bottom opens the quick actions card (brightness slider, flashlight etc.) so when Chrome Home eventually comes to Chrome for iPhone, the swipe up gesture isn't an option. 
Labels: Hotlist-Chrome-Home

Comment 5 by k...@chromium.org, Jul 1 2017

Labels: Pri-1

Comment 6 by kings...@google.com, Aug 10 2017

Labels: Fine-Pri-2.0

Comment 7 by k...@chromium.org, Sep 12 2017

Labels: -Fine-Pri-2.0 Fine-Pri-3.0
Owner: k...@chromium.org
Cc: mdjones@chromium.org bauerb@chromium.org
 Issue 690771  has been merged into this issue.
Just thought it’s worth noting that with the new iPhone X, swiping up from the bottom is the equivalent to tapping the home button (there is no home button on the iPhone X) so Chrome Home on the iPhone really cannot use the swipe/pull up method, it’ll have to be the expand button
I understand the expand button was removed from Chrome Home recently, but it seems like Apple's iPhone X guidelines weren't reviewed  https://developer.apple.com/ios/human-interface-guidelines/overview/iphone-x/ 

"Avoid explicitly placing interactive controls at the very bottom of the screen and in corners. People use swipe gestures at the bottom edge of the display to access the Home screen and app switcher, and these gestures may cancel custom gestures you implement in this area. The far corners of the screen can be difficult areas for people to reach comfortably."

"Avoid interfering with systemwide screen-edge gestures. People rely on these gestures to work in every app. In rare cases, immersive apps like games might require custom screen-edge gestures that take priority over the system's gestures—the first swipe invokes the app-specific gesture and a second-swipe invokes the system gesture. This behavior (known as edge protect) should be implemented sparingly, as it makes it harder for people to access the system-level actions. See Gestures."

If Chrome Home ships to the iPhone as it is, iPhone X users will be accidentally going to their home screen all the time, and all other iPhone users will be accidentally opening the control center all the time

Comment 11 by k...@chromium.org, Feb 2 2018

Status: WontFix (was: Assigned)
We are ending the current Chrome Home experiment and closing the corresponding Chrome Home bugs. Thanks for the feedback and support!

Ending this "experiment" is moronic. Chrome Home is a vastly more natural mobile interface than a top bar which is a substantial reach on large devices. Reconsider.
Canceling it was the right decision because of the swipe-up issues. Even being careful to avoid this, I unintentionally swipe up 3 to 5 times a day. Normal users would have been extremely annoyed by this, especially iPhone X users

Sign in to add a comment