New issue
Advanced search Search tips

Issue 726430 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Decide when to use float vs double in PDFium

Project Member Reported by npm@chromium.org, May 25 2017

Issue description

floats are good when a lot of accuracy is not needed because they will occupy less space and operations will run faster. However, in some cases, the use of double is necessary. Figuring this out for PDFs is not trivial: it depends on what the spec hints and on what works to render PDFs properly and efficiently.
 
Bulk edit**

This bug has the label Postmortem-Followup but has not been updated in 3+ weeks. We are working on a new workflow to improve postmortem followthrough. Postmortems and postmortem bugs are very important in making sure we don't repeat prior mistakes and for making Chrome better for all.

We will be taking a closer look at these bugs in the coming weeks. Please take some time to work on this, reassign, or close if the issue has been fixed. Thank you.
Labels: -Postmortem-Followup
I don't know why this has a Postmortem label attached. It's work we're thinking of doing but nothing has been done. This is internal cleanup as opposed to a regression.
Owner: ----
Status: Untriaged (was: Assigned)
Setting PDF bugs assigned to me back to untriaged so they can get re-assigned as needed.
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
This is a big task, if it consists of someone going through all the occurrences of "float" and "double" in PDFium and checking each usage.

Lei, what should be our policy in regards to using float vs doubles?

Is the current state bad?

Sign in to add a comment