New issue
Advanced search Search tips

Issue 726405 link

Starred by 1 user
Status: Fixed
Owner:
mustaq@chromium.org
Closed: May 2017
Cc:
rbyers@chromium.org
dtapu...@chromium.org
mlamouri@chromium.org
ojan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 696617



Sign in to add a comment

DocumentUserGestureToken adds no value to UserGestureToken

Project Member Reported by mustaq@chromium.org, May 25 2017 
Current design is not clean:
- The DocumentUserGestureToken/UserGestureToken split we
currently have looks unnecessary because UGT cannot be instantiated directly.
- DocumentUserGestureToken is a misnomer because it is only loosely tied with a Document object.
- Current UserGestureIndicator & UserGestureToken are in platform/ but they are only used in core/ & web/.

We need to clean these up before we add frame level user activation bits as an alternate implementation, see the blocked bug.
Project Member

Comment 1 by bugdroid1@chromium.org, May 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6f69d27ef4a1d09d397dab0c55e692c47bb8284

commit b6f69d27ef4a1d09d397dab0c55e692c47bb8284
Author: Mustaq Ahmed <mustaq@google.com>
Date: Mon May 29 18:52:45 2017

Removed DocumentUserGestureToken, moved UGI to core.

This CL moved all UGI code from platform/ to core/ to ease an altenate
(simple) user-activation implementatation we are planning soon.
Moreover, the DocumentUserGestureToken/UserGestureToken split we
currently have looks unnecessary, so removed the former to avoid future
confusion.

This is a purely cleanup CL, doens't change any functionalities.

Bug:  726405 
Change-Id: Id69a0626022c9c674b96743efdd815c49ebf8b82
Reviewed-on: https://chromium-review.googlesource.com/515822
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475369}
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/dom/BUILD.gn
[delete] https://crrev.com/f03b5126e924f11cca9e5cc2243d29d861fc52b8/third_party/WebKit/Source/core/dom/DocumentUserGestureToken.h
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[rename] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/dom/UserGestureIndicator.cpp
[add] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/dom/UserGestureIndicator.h
[add] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/dom/UserGestureIndicatorTest.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/frame/DOMTimer.h
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/frame/Frame.cpp
[rename] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/frame/FrameTest.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.h
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/html/HTMLVideoElementPersistentTest.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/html/forms/FileInputType.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/html/media/MediaDocument.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/page/CreateWindow.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegate.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/permissions/Permissions.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/quota/StorageManager.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/modules/webusb/USB.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/platform/BUILD.gn
[delete] https://crrev.com/f03b5126e924f11cca9e5cc2243d29d861fc52b8/third_party/WebKit/Source/platform/UserGestureIndicator.h
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/web/WebFrame.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/web/WebScopedUserGesture.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/web/WebUserGestureIndicator.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/web/WebUserGestureToken.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/web/tests/WebUserGestureTokenTest.cpp
[modify] https://crrev.com/b6f69d27ef4a1d09d397dab0c55e692c47bb8284/third_party/WebKit/Source/web/tests/WebViewTest.cpp

Comment 2 by mustaq@chromium.org, May 29 2017

Status: Fixed (was: Started)

Comment 3 by mustaq@chromium.org, Nov 1 2017

Labels: UserActivation
►

Sign in to add a comment