New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726400 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 835454



Sign in to add a comment

Make user action metric to support suffixes.

Project Member Reported by xingliu@chromium.org, May 25 2017

Issue description

Currently user action metrics only support one string to define the action in actions.xml.

It would be good that we can support suffixes similar to histograms in actions.xml.

The following actions can be converts to use suffixes:
FeatureEngagement.NotifyEvent
FeatureEngagement.NotifyUsedEvent


 
Cc: nyquist@chromium.org dtrainor@chromium.org
Labels: OS-All
Summary: Make user action metric to support suffixes. (was: Make user action metric to use suffixes. )
Description: Show this description
Cc: xingliu@chromium.org
Components: Internals>Metrics>UMA
Labels: -Type-Bug Type-Feature
Owner: isherman@chromium.org
isherman: I'm not familiar with the triage-process for Internals>Metrics>UMA.
Could you unassign / triage / put in triage queue / do whatever's typical for that component?
Cc: asvitk...@chromium.org
These patches show before-and-after states for applying 'git cl format' to suffixed user-actions:
Before: https://chromium-review.googlesource.com/c/chromium/src/+/554890/1
After: https://chromium-review.googlesource.com/c/chromium/src/+/554890/1..2

After talking to asvitkine@ I believe we would want 'git cl format' to leave the user actions alone on the client side, and instead do this expansion on the server-side.

As you probably could assume, this would be incredibly helpful regarding In-Product Help. Our guide for setting up IPH now is here: https://chromium.googlesource.com/chromium/src/+/master/components/feature_engagement/README.md#Configuring-UMA
I would love to be able to just tell our users to add themselves to an enum.
Owner: asvitk...@chromium.org
Status: Started (was: Untriaged)
Wrote a CL for this on my flight in. Will likely polish up and land this or next week.
This is excellent! Then we can clean up the in-product help metrics!
Blocking: 835454
Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d27270ac2cc6883f4460d74ac687b93badb107d5

commit d27270ac2cc6883f4460d74ac687b93badb107d5
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Mon Apr 23 15:39:55 2018

Fix support for action suffixes in actions.xml.

There was some previously incomplete support, but
that support didn't really work because pretty_print.py
would just expand all the suffixes and the processed
file would not have the suffix entries, but just the
expanded list. This CL properly preserves the suffixes
in the actions.xml file.

Also, adopt suffixes for some IPH actions to clean them
up and test this functionality.

It also cleans up some redundancy and edge cases in
existing Python code (for example, actions were returned
both in a dict and a set of names, with the latter being
redundant and now simplified.)

Bug:  726400 
Change-Id: I4c73811b9d13ff4e997f1d18a9d3ef0ab9277b06
Reviewed-on: https://chromium-review.googlesource.com/1015293
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552706}
[modify] https://crrev.com/d27270ac2cc6883f4460d74ac687b93badb107d5/tools/metrics/actions/action_utils.py
[modify] https://crrev.com/d27270ac2cc6883f4460d74ac687b93badb107d5/tools/metrics/actions/actions.xml
[modify] https://crrev.com/d27270ac2cc6883f4460d74ac687b93badb107d5/tools/metrics/actions/extract_actions.py
[modify] https://crrev.com/d27270ac2cc6883f4460d74ac687b93badb107d5/tools/metrics/actions/extract_actions_test.py
[modify] https://crrev.com/d27270ac2cc6883f4460d74ac687b93badb107d5/tools/metrics/actions/print_style.py
[modify] https://crrev.com/d27270ac2cc6883f4460d74ac687b93badb107d5/tools/metrics/common/models.py
[modify] https://crrev.com/d27270ac2cc6883f4460d74ac687b93badb107d5/tools/metrics/common/pretty_print_xml.py
[modify] https://crrev.com/d27270ac2cc6883f4460d74ac687b93badb107d5/tools/metrics/histograms/print_style.py
[modify] https://crrev.com/d27270ac2cc6883f4460d74ac687b93badb107d5/tools/metrics/ukm/model.py

Sign in to add a comment