New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 726386 link

Starred by 2 users
Status: Fixed
Owner:
█ asimjour@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 688122



Sign in to add a comment

VR: Disable html select

Project Member Reported by asimjour@chromium.org, May 25 2017 
For the first step, all monocular popup UI widgets should be disabled in VR.
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc76416e2ba1b9669cf7240ca693b8d38c8ba989

commit dc76416e2ba1b9669cf7240ca693b8d38c8ba989
Author: asimjour <asimjour@chromium.org>
Date: Fri May 26 01:14:36 2017

VR: Disable select element in VR mode via WebPreferences

When in VR, html select element opens a monocular popup UI widget.
page_popups_suppressed flag from web_preferences is used to suppress
the monocular ui.

BUG= 726386 

Review-Url: https://codereview.chromium.org/2905873003
Cr-Commit-Position: refs/heads/master@{#474862}

[modify] https://crrev.com/dc76416e2ba1b9669cf7240ca693b8d38c8ba989/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/dc76416e2ba1b9669cf7240ca693b8d38c8ba989/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/dc76416e2ba1b9669cf7240ca693b8d38c8ba989/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

Comment 2 by ddorwin@chromium.org, Jun 6 2017

Components: UI>Browser>VR
Labels: M-60
Status: Started (was: Assigned)
Is this fixed?

Comment 3 by asimjour@chromium.org, Jun 7 2017

Status: Fixed (was: Started)
►

Sign in to add a comment