Performance panel needs to support convenient switching between multiple recordings to simplify comparison.
Suggested UI
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdadc3319167519dabd265361ce14a61c9106839 commit cdadc3319167519dabd265361ce14a61c9106839 Author: Andrey Kosyakov <caseq@chromium.org> Date: Wed May 31 03:26:51 2017 Timeline: add recording history - introduce TimelineHistoryManager; - keep a list of at most 5 recorded/loaded timelines, discard LRU ones; - present recording history as a drop-down list of overview & screenshot thumbnails, accessible via a toolbar button or shortcut; - (drive-by) make ListControl focusable, properly disable Reload action button. - (drive-by) fix initial state of action button if action is disabled; Bug: 726381 Change-Id: I8e154530da6c60744c7f5192cae1914ab3623e4f Reviewed-on: https://chromium-review.googlesource.com/517295 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#475767} [modify] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js [modify] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/front_end/main/Main.js [modify] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js [modify] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceModel.js [add] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/front_end/timeline/TimelineHistoryManager.js [modify] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js [add] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/front_end/timeline/historyToolbarButton.css [modify] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/front_end/timeline/module.json [add] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/front_end/timeline/timelineHistoryManager.css [modify] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js [modify] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/front_end/ui/ListControl.js [modify] https://crrev.com/cdadc3319167519dabd265361ce14a61c9106839/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09d5924d566114d8b8b9dde18759dba28d5f7b53 commit 09d5924d566114d8b8b9dde18759dba28d5f7b53 Author: Andrey Kosyakov <caseq@chromium.org> Date: Fri Jun 02 18:44:30 2017 Timeline: preserve selection while switching between models Keep timeline window and selection associated with each performance model. Bug: 726381 Change-Id: Id61eb021e5b252dff8ec07d0e675822dc81a0956 Reviewed-on: https://chromium-review.googlesource.com/521870 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#476735} [modify] https://crrev.com/09d5924d566114d8b8b9dde18759dba28d5f7b53/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-window-filter.html [modify] https://crrev.com/09d5924d566114d8b8b9dde18759dba28d5f7b53/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js [modify] https://crrev.com/09d5924d566114d8b8b9dde18759dba28d5f7b53/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js [modify] https://crrev.com/09d5924d566114d8b8b9dde18759dba28d5f7b53/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7486e37f46e1960620a8ea832cdbad356ae84916 commit 7486e37f46e1960620a8ea832cdbad356ae84916 Author: Andrey Kosyakov <caseq@chromium.org> Date: Sat Jun 03 03:42:36 2017 DevTools Timeline: misc. history dialog fixes - add placeholder text to empty drop-down box; - fix disabling of the button when action is disabled; - fix screenshot proportions for tall windows; - fix canvas on high-DPI screens. Bug: 726381 Change-Id: Ie1ca6b1172e7054a672d6440bc52a2912761d43c Reviewed-on: https://chromium-review.googlesource.com/522859 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#476883} [modify] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/Source/devtools/front_end/timeline/TimelineHistoryManager.js [modify] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/Source/devtools/front_end/timeline/timelineHistoryManager.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b24c4dbe118451b3e3740ae7176c56eef87f0a0 commit 3b24c4dbe118451b3e3740ae7176c56eef87f0a0 Author: Andrey Kosyakov <caseq@chromium.org> Date: Tue Jun 06 03:34:59 2017 Timeline: add shortcuts for showing prev/next recordings - navigate to previos/next recording upon Alt-Left/Alt-Right; - make sure FlameChart is reset before search highlight is updated; - (drive-by) fix shortcut for page reload recording in the help screen; Bug: 726381 Change-Id: I7784a049259359ff8f7878a27971165599f2f3b4 Reviewed-on: https://chromium-review.googlesource.com/524993 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#477179} [modify] https://crrev.com/3b24c4dbe118451b3e3740ae7176c56eef87f0a0/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js [modify] https://crrev.com/3b24c4dbe118451b3e3740ae7176c56eef87f0a0/third_party/WebKit/Source/devtools/front_end/timeline/TimelineHistoryManager.js [modify] https://crrev.com/3b24c4dbe118451b3e3740ae7176c56eef87f0a0/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js [modify] https://crrev.com/3b24c4dbe118451b3e3740ae7176c56eef87f0a0/third_party/WebKit/Source/devtools/front_end/ui/ShortcutsScreen.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8854fe7071b2e2751e9b932a05247d21e0467fa commit e8854fe7071b2e2751e9b932a05247d21e0467fa Author: Andrey Kosyakov <caseq@chromium.org> Date: Fri Jun 09 00:35:45 2017 Timeline: fix saving when switching models trough history dialog - don't keep backingStorage on TimelinePanel, expose one in TracingModel; - inline TracingModel.reset() into constructor, introduce dispose() instead; - simplify tracing model creation in tests. Bug: 726381 Change-Id: I0a26fc461e0e18e849a445c69fb74e4555bdadb0 Reviewed-on: https://chromium-review.googlesource.com/526855 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#478138} [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/LayoutTests/inspector/tracing-browser-thread.html [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/LayoutTests/inspector/tracing-model-async.html [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/LayoutTests/inspector/tracing-model-ids.html [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/LayoutTests/inspector/tracing-model-storage.html [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/LayoutTests/inspector/tracing-model.html [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/LayoutTests/inspector/tracing.html [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/Source/devtools/front_end/timeline/ExtensionTracingSession.js [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceModel.js [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js [modify] https://crrev.com/e8854fe7071b2e2751e9b932a05247d21e0467fa/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e61417330faba0e613e217ead1409c3212c1e9c commit 6e61417330faba0e613e217ead1409c3212c1e9c Author: Andrey Kosyakov <caseq@chromium.org> Date: Mon Dec 11 23:56:32 2017 DevTools: make timeline record history experiment enabled by default Bug: 726381 Change-Id: I76fb27d4eb50730ff85fdf39895859db4e343bc8 Reviewed-on: https://chromium-review.googlesource.com/811526 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523260} [modify] https://crrev.com/6e61417330faba0e613e217ead1409c3212c1e9c/third_party/WebKit/Source/devtools/front_end/main/Main.js
Comment 1 by caseq@chromium.org
, May 26 201761.8 KB
61.8 KB View Download