rebaseline-cl: List started/unfinished jobs, and don't try to fetch results from those jobs. |
||
Issue descriptionCurrently in webkit-patch rebaseline-cl, the list of try jobs is fetched using GitCL.latest_try_jobs, and this list includes both unfinished jobs and finished jobs. Even if the try job is unfinished (or finished but green), rebaseline-cl tries to fetch layout test results, which is unnecessary.
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/323d8da5b25996009a501ac3094ef33af52944b6 commit 323d8da5b25996009a501ac3094ef33af52944b6 Author: Quinten Yearsley <qyearsley@google.com> Date: Fri Jun 02 23:45:29 2017 Update rebaseline-cl to list started and scheduled jobs. This is a follow-up to https://chromium-review.googlesource.com/514662 which would make it so that rebaseline-cl starts listing started jobs separately, but not yet treating them separately. This also updates rebaseline_cl_unittest.py to use dictionaries of Build to TryJobResult for the return value of GitCL.latest_try_jobs, which is what the real value should be now. Bug: 726376 Change-Id: I502fdf463dff341999550a6c95c93a78a9addff5 Reviewed-on: https://chromium-review.googlesource.com/520584 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#476834} [modify] https://crrev.com/323d8da5b25996009a501ac3094ef33af52944b6/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py [modify] https://crrev.com/323d8da5b25996009a501ac3094ef33af52944b6/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
,
Jun 22 2017
Next step: don't try to fetch results for unfinished or passing jobs.
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91a26f05e5d9c5a20d1300db1fbe732d8847d805 commit 91a26f05e5d9c5a20d1300db1fbe732d8847d805 Author: Quinten Yearsley <qyearsley@google.com> Date: Fri Jun 30 15:52:57 2017 rebaseline-cl: Don't try to fetch results for unfinished builds. This CL changes rebaseline-cl so that it only fetches results for completed, failed builds. For completed, successful builds, they should be considered to have no baselines to download. For scheduled and started builds, and canceled builds, there are no usable results (yet), so the tool can prompt the user to ask if they want to try to continue with results only for some builders. Apart from http://crbug.com/726376 (don't fetch results for started builds), I believe this should also fix http://crbug.com/726855 (don't try to fetch retry results for started or passing builds). Bug: 726376 , 726855 Change-Id: I2e92a426f10f40c580b3aa9a31974b4489565a77 Reviewed-on: https://chromium-review.googlesource.com/548984 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#483714} [modify] https://crrev.com/91a26f05e5d9c5a20d1300db1fbe732d8847d805/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py [modify] https://crrev.com/91a26f05e5d9c5a20d1300db1fbe732d8847d805/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
,
Jun 30 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 25 2017