New issue
Advanced search Search tips

Issue 726376 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

rebaseline-cl: List started/unfinished jobs, and don't try to fetch results from those jobs.

Project Member Reported by qyears...@chromium.org, May 25 2017

Issue description

Currently in webkit-patch rebaseline-cl, the list of try jobs is fetched using GitCL.latest_try_jobs, and this list includes both unfinished jobs and finished jobs.

Even if the try job is unfinished (or finished but green), rebaseline-cl tries to fetch layout test results, which is unnecessary.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ce4987234f2b38382a7f3610ef195a94e5a6b12

commit 4ce4987234f2b38382a7f3610ef195a94e5a6b12
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu May 25 19:37:38 2017

webkitpy: When fetching try jobs, also return try job status.

This CL makes it so that the methods in webkitpy.common.net.git_cl
return the status of try jobs (whether they're started or finished,
successful or failed), so that later this can be used to improve
the behavior of rebaseline-cl.

Change-Id: I27c5eea571073bd1bf7888863efb3a1c8efec34b
Bug:  713265 ,  726376 
Reviewed-on: https://chromium-review.googlesource.com/514662
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474756}
[modify] https://crrev.com/4ce4987234f2b38382a7f3610ef195a94e5a6b12/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py
[modify] https://crrev.com/4ce4987234f2b38382a7f3610ef195a94e5a6b12/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/323d8da5b25996009a501ac3094ef33af52944b6

commit 323d8da5b25996009a501ac3094ef33af52944b6
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri Jun 02 23:45:29 2017

Update rebaseline-cl to list started and scheduled jobs.

This is a follow-up to https://chromium-review.googlesource.com/514662
which would make it so that rebaseline-cl starts listing started jobs
separately, but not yet treating them separately.

This also updates rebaseline_cl_unittest.py to use dictionaries of Build
to TryJobResult for the return value of GitCL.latest_try_jobs, which is
what the real value should be now.

Bug:  726376 
Change-Id: I502fdf463dff341999550a6c95c93a78a9addff5
Reviewed-on: https://chromium-review.googlesource.com/520584
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476834}
[modify] https://crrev.com/323d8da5b25996009a501ac3094ef33af52944b6/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
[modify] https://crrev.com/323d8da5b25996009a501ac3094ef33af52944b6/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Next step: don't try to fetch results for unfinished or passing jobs.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91a26f05e5d9c5a20d1300db1fbe732d8847d805

commit 91a26f05e5d9c5a20d1300db1fbe732d8847d805
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri Jun 30 15:52:57 2017

rebaseline-cl: Don't try to fetch results for unfinished builds.

This CL changes rebaseline-cl so that it only fetches
results for completed, failed builds.

For completed, successful builds, they should be considered
to have no baselines to download.

For scheduled and started builds, and canceled builds,
there are no usable results (yet), so the tool can prompt
the user to ask if they want to try to continue with
results only for some builders.

Apart from  http://crbug.com/726376  (don't fetch results for
started builds), I believe this should also fix
 http://crbug.com/726855  (don't try to fetch retry results
for started or passing builds).

Bug:  726376 ,  726855 
Change-Id: I2e92a426f10f40c580b3aa9a31974b4489565a77
Reviewed-on: https://chromium-review.googlesource.com/548984
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483714}
[modify] https://crrev.com/91a26f05e5d9c5a20d1300db1fbe732d8847d805/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
[modify] https://crrev.com/91a26f05e5d9c5a20d1300db1fbe732d8847d805/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Status: Fixed (was: Started)

Sign in to add a comment