New issue
Advanced search Search tips

Issue 726375 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Implement mini-infobar + CCT experience for reader mode

Project Member Reported by k...@chromium.org, May 25 2017

Issue description

In order to make reader mode more scalable, we'd like to make reader mode triggered by a mini-infobar. This would ideally trigger a CCT experience which can be closed quickly.

Note: There's some prototyping we would need to do to make sure the experience feels smooth.
 

Comment 1 by wychen@chromium.org, Jun 29 2017

Do we want to use Finch to launch this? Or simply switch over to CCT from status quo (navigation)? Compared with the switch from Overlay Panel to navigation, this should be a smaller change.

Comment 2 by k...@chromium.org, Jun 30 2017

Let's switch to CCT if possible (but maybe start with it behind a flag if it isn't too much effort)

Comment 3 by wychen@chromium.org, Jul 19 2017

Cc: -wychen@chromium.org mdjones@chromium.org
Owner: wychen@chromium.org
The infobar part was landed https://codereview.chromium.org/2878543003/.
I'm working on the CCT experience, which can be recycled from https://codereview.chromium.org/1837243002/.

The intended behavior is: for low-end devices, we keep using the navigation within the tab; for high-end devices, open a CCT. It will be behind a flag.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41b2241e9840a5d98f1f6c48f0dd899c59722e88

commit 41b2241e9840a5d98f1f6c48f0dd899c59722e88
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Fri Jul 21 02:51:18 2017

Add a new flag: ReaderModeInCCT

When feature ReaderModeInCCT is turned on, Mobile-friendly View
would be shown in a Chrome Custom Tab on high-end devices.

No implementation yet.

Bug: 726375
Change-Id: Icd00bbd94350768258dd450806b2d9610ab6d34e
Reviewed-on: https://chromium-review.googlesource.com/578575
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488563}
[modify] https://crrev.com/41b2241e9840a5d98f1f6c48f0dd899c59722e88/chrome/browser/about_flags.cc
[modify] https://crrev.com/41b2241e9840a5d98f1f6c48f0dd899c59722e88/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/41b2241e9840a5d98f1f6c48f0dd899c59722e88/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/41b2241e9840a5d98f1f6c48f0dd899c59722e88/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/41b2241e9840a5d98f1f6c48f0dd899c59722e88/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/41b2241e9840a5d98f1f6c48f0dd899c59722e88/tools/metrics/histograms/enums.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01aa11d8d5973e27500c5abb6da3c11acd5e2d0e

commit 01aa11d8d5973e27500c5abb6da3c11acd5e2d0e
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Tue Jul 25 17:43:58 2017

Hide "Request Desktop Site" in Reader Mode

Bug: 726375
Change-Id: I65012b9cc2c5ab457f13503a934bea8de7fa44ad
Reviewed-on: https://chromium-review.googlesource.com/578724
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489357}
[modify] https://crrev.com/01aa11d8d5973e27500c5abb6da3c11acd5e2d0e/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3d9c1b9da636140fd2876712ce382cc873ee0e9

commit f3d9c1b9da636140fd2876712ce382cc873ee0e9
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Thu Jul 27 10:26:15 2017

Implement ReaderModeInCCT feature

When feature ReaderModeInCCT is turned on, Mobile-friendly View
would be shown in a Chrome Custom Tab on high-end devices.
Otherwise, in-tab navigate to the distilled view.

This is mostly from: https://codereview.chromium.org/1837243002/
Notable difference is that the distillation is now done in the
WebContents in the original tab, and we no longer need to load
the original content in an invisible tab.

Bug: 726375
Change-Id: I1d3343f62c73b1abd6d17810c2b89e14b1e95fdc
Reviewed-on: https://chromium-review.googlesource.com/578385
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489892}
[modify] https://crrev.com/f3d9c1b9da636140fd2876712ce382cc873ee0e9/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/f3d9c1b9da636140fd2876712ce382cc873ee0e9/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/f3d9c1b9da636140fd2876712ce382cc873ee0e9/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/f3d9c1b9da636140fd2876712ce382cc873ee0e9/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
[modify] https://crrev.com/f3d9c1b9da636140fd2876712ce382cc873ee0e9/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/f3d9c1b9da636140fd2876712ce382cc873ee0e9/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
[modify] https://crrev.com/f3d9c1b9da636140fd2876712ce382cc873ee0e9/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java
[modify] https://crrev.com/f3d9c1b9da636140fd2876712ce382cc873ee0e9/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
[modify] https://crrev.com/f3d9c1b9da636140fd2876712ce382cc873ee0e9/chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java
[modify] https://crrev.com/f3d9c1b9da636140fd2876712ce382cc873ee0e9/chrome/browser/dom_distiller/tab_utils.cc
[modify] https://crrev.com/f3d9c1b9da636140fd2876712ce382cc873ee0e9/chrome/browser/dom_distiller/tab_utils.h
[modify] https://crrev.com/f3d9c1b9da636140fd2876712ce382cc873ee0e9/chrome/browser/dom_distiller/tab_utils_android.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5e8d0ec63792c78d69808ff4e81f352be1383fb

commit b5e8d0ec63792c78d69808ff4e81f352be1383fb
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Fri Jul 28 03:06:11 2017

Only show relevant menu items for Reader Mode in CCT

Only two items, 'Find in page' and 'Reader Mode Preference',
are shown in the menu for Reader Mode in Chrome Custom Tab.

Bug: 726375
Change-Id: Ib603a0e9f713aa4254c512919a15277ff22f2151
Reviewed-on: https://chromium-review.googlesource.com/578746
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490233}
[modify] https://crrev.com/b5e8d0ec63792c78d69808ff4e81f352be1383fb/chrome/android/java/res/menu/custom_tabs_menu.xml
[modify] https://crrev.com/b5e8d0ec63792c78d69808ff4e81f352be1383fb/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/b5e8d0ec63792c78d69808ff4e81f352be1383fb/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/b5e8d0ec63792c78d69808ff4e81f352be1383fb/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
[modify] https://crrev.com/b5e8d0ec63792c78d69808ff4e81f352be1383fb/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/b5e8d0ec63792c78d69808ff4e81f352be1383fb/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
[modify] https://crrev.com/b5e8d0ec63792c78d69808ff4e81f352be1383fb/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
[modify] https://crrev.com/b5e8d0ec63792c78d69808ff4e81f352be1383fb/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Sign in to add a comment