Some ReloadCacheControlBrowserTest tests are flaky |
||||||||
Issue descriptionFlake appeared recently on https://uberchromegw.corp.google.com/i/chromium.win/builders/Win%207%20Tests%20x64%20%281%29 First instance of failure I can see is https://uberchromegw.corp.google.com/i/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/24572 I was unable to locate a reasonably suspicious culprit CL in the likely regression range.
,
May 25 2017
+toyoshim author of the test
,
May 25 2017
We aren't using PlzNavigate on the bots now, are we?
,
May 25 2017
No, PlzNavigate is not on by default. It runs on bots, but each step is clearly named with a prefix of "browser_side_navigation". So failing just "content_browsertests" implies no PlzNavigate.
,
May 26 2017
,
May 26 2017
Still showing up, though the test might need to be rewritten and this is WAI. I don't believe that there are any guarantees that requests open on the client (Chrome) will hit the test server in the same order as they are open (due to network latency/etc).
,
May 29 2017
Right, the test mistakenly relies on a behavior that are not ensured. I will fix the test.
,
May 31 2017
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=ReloadCacheControlBrowserTest ReloadCacheControlBrowserTest.NavigateToSame ReloadCacheControlBrowserTest.NormalReload ReloadCacheControlBrowserTest.BypassingReload (I filed another bug for this) are flaky.
,
May 31 2017
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf698306c4a097eb809fcf403c12e66358396747 commit bf698306c4a097eb809fcf403c12e66358396747 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Thu Jun 01 05:24:10 2017 Rewrite ReloadCacheControlBrowserTest Original tests are flaky because they rely on unwarranted order how Chrome issues network requests. New test does not check expectations in an expected order, but just check if cache control flag is expected one for each resource. BUG= 726364 , 728060 Change-Id: Idb2367a259f22779581ac59b0c0017cd1256f3b9 Reviewed-on: https://chromium-review.googlesource.com/519283 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#476200} [modify] https://crrev.com/bf698306c4a097eb809fcf403c12e66358396747/content/browser/loader/reload_cache_control_browsertest.cc
,
Jun 1 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mmenke@chromium.org
, May 25 2017