New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726363 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Use existing color types for vr

Project Member Reported by vollick@chromium.org, May 25 2017

Issue description

Specifically, we should replace vr::Colorf with SkColor.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60a9afebd0702a5e3097e928b6c89a5271ca91ee

commit 60a9afebd0702a5e3097e928b6c89a5271ca91ee
Author: vollick <vollick@chromium.org>
Date: Fri May 26 21:15:48 2017

[vr] Migrate from vr::Colorf to SkColor

BUG= 726363 

Review-Url: https://codereview.chromium.org/2911663002
Cr-Commit-Position: refs/heads/master@{#475129}

[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/chrome/browser/android/vr_shell/color_scheme.cc
[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/chrome/browser/android/vr_shell/color_scheme.h
[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/chrome/browser/android/vr_shell/ui_elements/screen_dimmer.cc
[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/chrome/browser/android/vr_shell/ui_elements/screen_dimmer.h
[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/chrome/browser/android/vr_shell/ui_elements/ui_element.h
[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/chrome/browser/android/vr_shell/ui_scene.cc
[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/chrome/browser/android/vr_shell/ui_scene.h
[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/chrome/browser/android/vr_shell/vr_shell_renderer.cc
[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/chrome/browser/android/vr_shell/vr_shell_renderer.h
[modify] https://crrev.com/60a9afebd0702a5e3097e928b6c89a5271ca91ee/device/vr/vr_types.h

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, May 29 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 29 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bac6a3711cbbd2423979856073f66a8ddce24f6b

commit bac6a3711cbbd2423979856073f66a8ddce24f6b
Author: Christopher Grant <cjgrant@google.com>
Date: Mon May 29 18:51:36 2017

[vr] Migrate from vr::Colorf to SkColor

BUG= 726363 

Review-Url: https://codereview.chromium.org/2911663002
Cr-Original-Commit-Position: refs/heads/master@{#475129}
Review-Url: https://codereview.chromium.org/2906423002 .
Cr-Commit-Position: refs/branch-heads/3112@{#16}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/chrome/browser/android/vr_shell/color_scheme.cc
[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/chrome/browser/android/vr_shell/color_scheme.h
[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/chrome/browser/android/vr_shell/ui_elements/screen_dimmer.cc
[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/chrome/browser/android/vr_shell/ui_elements/screen_dimmer.h
[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/chrome/browser/android/vr_shell/ui_elements/ui_element.h
[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/chrome/browser/android/vr_shell/ui_scene.cc
[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/chrome/browser/android/vr_shell/ui_scene.h
[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/chrome/browser/android/vr_shell/vr_shell_renderer.cc
[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/chrome/browser/android/vr_shell/vr_shell_renderer.h
[modify] https://crrev.com/bac6a3711cbbd2423979856073f66a8ddce24f6b/device/vr/vr_types.h

Status: Fixed (was: Assigned)
Labels: Proj-VR-Shell
Labels: M-60

Sign in to add a comment