New issue
Advanced search Search tips

Issue 726362 link

Starred by 1 user
Status: Fixed
Owner:
f...@opera.com
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove kInitialFrameDelay in SMILTimeContainer

Project Member Reported by f...@opera.com, May 25 2017 
kInitialFrameDelay was added (by yours truly) to avoid having to "fix" a lot(?) of testcases when moving the SMIL engine over to "rAF-based" frame scheduling.
While it probably isn't something authors will notice (easily) it's a bit of a wart and a nuisance (to me at least...)
We should remove its use in SMILTimeContainer::Start and do something about the more newly grown usage in SMILTimeContainer::AdvanceFrameForTesting (open-coding probably if nothing else.)

Comment 1 by schenney@chromium.org, May 25 2017

Labels: BugSource-Team PaintTeamTriaged-20170525
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a355f97c2b9962a162f7e96f92303deaa9fc97c2

commit a355f97c2b9962a162f7e96f92303deaa9fc97c2
Author: Fredrik Söderqvist <fs@opera.com>
Date: Sun Jul 09 22:59:43 2017

Adjust svg/animations/animate-linear-discrete-additive*.svg

In these tests we want to sample animation values at a certain point in
time. We are however sampling the animations at the next frame that is
painted - at which point the timeline may have advanced, and hence we
sample at t+<framedelay> (or thereabout) instead. Currently this works
"fine" because the first animation frame follows special scheduling
rules, making sure the timeline won't advance within this time window.
Rather than relying on this, just pause the timeline instead.

BUG= 726362 

Change-Id: I2314b435861050fd0163670928318563bd09f271
Reviewed-on: https://chromium-review.googlesource.com/563624
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485166}
[modify] https://crrev.com/a355f97c2b9962a162f7e96f92303deaa9fc97c2/third_party/WebKit/LayoutTests/svg/animations/animate-linear-discrete-additive-b.svg
[modify] https://crrev.com/a355f97c2b9962a162f7e96f92303deaa9fc97c2/third_party/WebKit/LayoutTests/svg/animations/animate-linear-discrete-additive-c.svg
[modify] https://crrev.com/a355f97c2b9962a162f7e96f92303deaa9fc97c2/third_party/WebKit/LayoutTests/svg/animations/animate-linear-discrete-additive.svg
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afbfd59bb3b037d540e46c8b04205c1301ea4b52

commit afbfd59bb3b037d540e46c8b04205c1301ea4b52
Author: Fredrik Söderqvist <fs@opera.com>
Date: Tue Jul 11 13:41:31 2017

Make svg/W3C-SVG-1.1 animation tests "static"

These tests are animated, but has from a testing standpoint never gone
beyond sampling the frame at t=0. This is however partly by "accident"
because t=0 is just after 'load', while the frame dumped will have a
value of 't' greater than 0. To ensure t=0 is sampled, pause the
timeline.

This commit was generated by a script (explaining the imperfect
indentation.)

BUG= 726362 

Change-Id: I60bdd2d0fa30b09318b18d2eda39583821107199
Reviewed-on: https://chromium-review.googlesource.com/565723
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#485618}
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-02-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-03-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-04-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-05-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-06-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-07-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-08-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-09-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-10-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-11-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-12-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-13-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-14-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-15-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-16-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-17-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-18-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-19-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-20-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-21-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-22-b.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-23-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-24-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-25-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-26-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-27-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-28-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-29-b.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-30-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-31-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-32-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-33-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-34-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-36-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-37-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-39-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-40-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-41-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-44-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-46-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-52-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-60-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-61-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-62-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-63-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-64-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-65-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-66-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-67-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-68-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-69-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-70-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-77-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-78-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-80-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-81-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-82-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-83-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-84-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/animate-elem-85-t.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/filters-light-04-f.svg
[modify] https://crrev.com/afbfd59bb3b037d540e46c8b04205c1301ea4b52/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-19-b.svg
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75f6502efdaf80adbc9ddce8f039ee2e9b58c227

commit 75f6502efdaf80adbc9ddce8f039ee2e9b58c227
Author: Fredrik Söderqvist <fs@opera.com>
Date: Wed Jul 12 21:55:27 2017

Remove kInitialFrameDelay from SMILTimeContainer::Start

This is an old hack to preserve behavior of certain tests. These tests
have since been fixed to not rely on this. Get rid of it and just call
UpdateAnimationsAndScheduleFrameIfNeeded(...) instead to schedule the
first frame just like any other.

BUG= 726362 

Change-Id: I1ff2673a8d4b71ea237a2902f10599e08bcfb7d6
Reviewed-on: https://chromium-review.googlesource.com/564608
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#486115}
[modify] https://crrev.com/75f6502efdaf80adbc9ddce8f039ee2e9b58c227/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e62d30810c8a4bcc52e22cb491f4637c1e4707c

commit 3e62d30810c8a4bcc52e22cb491f4637c1e4707c
Author: Fredrik Söderquist <fs@opera.com>
Date: Thu Jul 13 09:12:53 2017

Deflake two tests in svg/animations/mozilla/

Pause the timeline after adjusting the current time, similarly to how
it's done in other tests in this directory and in other places. This
avoids flakiness due to the timing of the first frame differing from
that of the 'load' event.

TBR=schenney@chromium.org
BUG= 726362 , 742068 

Change-Id: Id9753fc1d5b53a389a59f9b8f36a8965fb9597d0
Reviewed-on: https://chromium-review.googlesource.com/569619
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#486323}
[modify] https://crrev.com/3e62d30810c8a4bcc52e22cb491f4637c1e4707c/third_party/WebKit/LayoutTests/svg/animations/mozilla/animateMotion-by-1.svg
[modify] https://crrev.com/3e62d30810c8a4bcc52e22cb491f4637c1e4707c/third_party/WebKit/LayoutTests/svg/animations/mozilla/animateMotion-mpath-pathLength-1.svg

Comment 6 by f...@opera.com, Jul 14 2017

Owner: f...@opera.com
Status: Fixed (was: Available)
►

Sign in to add a comment