Remove duplicate fmap.py |
|||
Issue descriptionfmap.py exists in both factory/setup and under third_party/flashmap. The version in factory/setup has a few changes compared the one in 3p. These should be upstreamed. Then fmap.py in factory/setup can be made a symlink to the one in third_party/flashmap as is done for other files in factory/setup (see crbug/713599).
,
May 25 2017
FYI fmap.py in setup is already a symlink to factory/py/gooftools.
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/flashmap/+/11bc385cb6d34ed9f53a240b8b6c0f01c6a0a776 commit 11bc385cb6d34ed9f53a240b8b6c0f01c6a0a776 Author: Drew Davenport <ddavenport@chromium.org> Date: Fri May 26 16:47:44 2017 flashmap: add fmap_unittest.py - Remove test functionality from fmap.py's main function and replace with appropriate unit tests in fmap_unittest.py - Bring over some formatting and lint fixes from factory/setup/fmap.py - Add *.pyc to .gitignore BUG= chromium:726356 TEST=ran unit tests Change-Id: I4cb99efa3d924483dfdff9be54f6c3fc10040f3f Reviewed-on: https://chromium-review.googlesource.com/516242 Commit-Ready: Drew Davenport <ddavenport@chromium.org> Tested-by: Drew Davenport <ddavenport@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [add] https://crrev.com/11bc385cb6d34ed9f53a240b8b6c0f01c6a0a776/fmap_unittest.py [modify] https://crrev.com/11bc385cb6d34ed9f53a240b8b6c0f01c6a0a776/fmap.py [modify] https://crrev.com/11bc385cb6d34ed9f53a240b8b6c0f01c6a0a776/.gitignore
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/flashmap/+/9108393752ffd93b133037add1f7b484de09bdbc commit 9108393752ffd93b133037add1f7b484de09bdbc Author: Drew Davenport <ddavenport@chromium.org> Date: Fri May 26 16:47:44 2017 flashmap: Bring over changes from factory repo fmap.py is identical to the one in factory/setup/fmap.py except: - no test functionality in main function - module docstring and license Added some unit tests for the new functionality BUG= chromium:726356 TEST=ran unittests Change-Id: Ib67bd4260cf4e1cc08543b822521a4adcf0cbce6 Reviewed-on: https://chromium-review.googlesource.com/516382 Commit-Ready: Drew Davenport <ddavenport@chromium.org> Tested-by: Drew Davenport <ddavenport@chromium.org> Reviewed-by: Drew Davenport <ddavenport@chromium.org> [modify] https://crrev.com/9108393752ffd93b133037add1f7b484de09bdbc/fmap_unittest.py [modify] https://crrev.com/9108393752ffd93b133037add1f7b484de09bdbc/fmap.py
,
Jun 8 2017
Closing this as infeasible, based on unique development workflow requirements needed by factory. Changes to fmap.py should be made in third_party/flashmap, and brought over to factory.
,
Jul 5 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ddavenp...@chromium.org
, May 25 2017Status: Assigned (was: Untriaged)