New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 726344 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: May 2017
Cc:
█ nyquist@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Presubmit not detecting owners of values.xml

Project Member Reported by rouslan@chromium.org, May 25 2017 
In the patch https://chromium-review.googlesource.com/c/506747/, the presubmit bot is failing because of lack of LGTM from an owner of values.xml, even though an owner has LGTM-ed the change.

Presubmit run:
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/445689

Log:
** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/android/java/res/values/values.xml

LGTM is from nyquist@chromium.org, who is in the owners file:
https://cs.chromium.org/chromium/src/chrome/android/OWNERS

Comment 1 by nyquist@chromium.org, May 25 2017

Status: WontFix (was: Unconfirmed)
This is not a bug.

It is because of this line: https://chromium.googlesource.com/chromium/src/+/master/chrome/android/java/res/OWNERS#1

It says "set noparent", which denies OWNERS from parent directories to be able to approve changes.

You will need to find someone from that OWNERS file or closer to the file you are editing.

Comment 2 by rouslan@chromium.org, May 25 2017 

Totally missed that. Thank you for clarifying.
►

Sign in to add a comment