New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 726341 link

Starred by 2 users
Status: Fixed
Owner:
█ alexclarke@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
maxlg@chromium.org
delph...@chromium.org
altimin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

RendererScheduler should use DidCommitProvisionalLoad as the start-of-navigation signal

Project Member Reported by skyos...@chromium.org, May 25 2017 
DidCommitProvisionalLoad means the renderer has stopped doing work on any previous page it might have had and started loading a new page. We should use that to inform the scheduler about when to enter the loading state.

See https://codereview.chromium.org/2890173002/ for discussion.

Comment 1 by tdres...@chromium.org, May 25 2017

Cc: maxlg@chromium.org
Max is going to plumb OnDidCommitProvisionalLoad into the RSI as part of work on the expected queueing time metric.

It's probably reasonable to land that first, and then land a followup patch which switches all current uses of OnNavigation to use OnDidCommitProvisionalLoad.

Comment 2 by skyos...@chromium.org, May 25 2017 

Great, thank you!

Comment 3 by maxlg@chromium.org, Jun 12 2017 

https://codereview.chromium.org/2890173002/ has been landed.

Comment 4 by tdres...@chromium.org, Jun 13 2017

Status: Untriaged (was: Available)

Comment 5 by altimin@chromium.org, Aug 7 2017

Owner: alexclarke@chromium.org
Status: Fixed (was: Untriaged)
As far as I understand, this was fixed by alexclarke@ in https://chromium-review.googlesource.com/c/522069.
►

Sign in to add a comment