New issue
Advanced search Search tips

Issue 726334 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

autoplay-policy crashes

Reported by tldr@fernandomiguel.net, May 25 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3107.4 Safari/537.36

Steps to reproduce the problem:
1. enable chrome://flags/#autoplay-policy
2. restart chrome

What is the expected behavior?
browser to restart fine

What went wrong?
browser crashes every time till reset flags

Crashed report ID: 

How much crashed? Whole browser

Is it a problem with a plugin? No 

Did this work before? Yes 

Chrome version: 60.0.3107.4  Channel: dev
OS Version: OS X 10.12.6
Flash Version: 

Google Chrome	60.0.3107.4 (Official Build) dev (64-bit)
Revision	ffa07b070c2b1dc5dd7c22bc8694f497bee5d538-refs/branch-heads/3107@{#6}
OS	Mac OS X
JavaScript	V8 6.0.286
Flash	26.0.0.110 /Users/fernandopereira/Library/Application Support/Google/Chrome/PepperFlash/26.0.0.110/PepperFlashPlayer.plugin
User Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3107.4 Safari/537.36
Command Line	/Applications/Google Chrome.app/Contents/MacOS/Google Chrome --flag-switches-begin --enable-browser-task-scheduler --enable-color-correct-rendering --enable-devtools-experiments --enable-experimental-web-platform-features --enable-fast-unload --enable-fullscreen-tab-detaching --enable-fullscreen-toolbar-reveal --enable-google-branded-context-menu --enable-hosted-app-quit-notification --enable-nacl --enable-new-app-menu-icon --enable-offline-auto-reload --enable-permission-action-reporting --disable-push-api-background-mode --enable-quic --site-per-process --enable-site-settings --enable-spelling-feedback-field-trial --enable-tab-audio-muting --enable-experimental-extension-apis --mark-non-secure-as=non-secure --reduced-referrer-granularity --show-cert-link --ssl-version-max=tls1.3 --enable-features=AutomaticTabDiscarding,ExpensiveBackgroundTimerThrottling,FeaturePolicy,HttpFormWarning,IdleTimeSpellChecking,ImportantSitesInCBD,MaterialDesignIncognitoNTP,MediaRemoting,NativeNotifications,NewOmniboxAnswerTypes,NewRemotePlaybackPipeline,NoStatePrefetch,OmniboxDisplayTitleForCurrentUrl,OmniboxEntitySuggestions,OneGoogleBarOnLocalNtp,PauseBackgroundTabs,PermissionsBlacklist,PreferHtmlOverPlugins,SafeSearchUrlReporting,ScrollAnchoring,SiteDetails,SpeculativeResourcePrefetching,TabStripKeyboardFocus,UseGoogleLocalNtp,WebPayments,WebRtcUseEchoCanceller3,ZeroSuggestRedirectToChrome,brotli-encoding,enable-password-force-saving,top-document-isolation --flag-switches-end

also tested with no flags, just autoplay-policy enabled
 
In step 1, what autoplay policy do you pick?
@mlamouri
User gesture required.

i didnt actually tested the other option.
let me test in canary
Google Chrome	60.0.3110.0 (Official Build) canary (64-bit)
Revision	0d764046b1e7ea6eb145e2aa39a88a6d0ac3e714-refs/heads/master@{#474499}
OS	Mac OS X
JavaScript	V8 6.0.286.1
Flash	26.0.0.115 /Users/fernandopereira/Library/Application Support/Google/Chrome Canary/PepperFlash/26.0.0.115/PepperFlashPlayer.plugin
User Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3110.0 Safari/537.36
Command Line	/Applications/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary --flag-switches-begin --autoplay-policy=no-user-gesture-required --flag-switches-end

picking No Gesture required doesnt crash.

Comment 4 by ajha@chromium.org, May 26 2017

Labels: Needs-Triage-M60
Cc: jmukthavaram@chromium.org
Components: Internals>Media
Labels: -Pri-2 -Needs-Triage-M60 M-60 hasbisect OS-Linux OS-Windows Pri-1
Owner: mlamouri@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 7 , Mac 10.12.4 & Ubuntu 14.04 using chrome reported version-60.0.3107.4 & latest Canary-61.0.3115.0.
Manual Bisect info:
-------------------
Good-60.0.3096.0—Revision-470759
Bad-60.0.3097.0—Revision-471158

Bisect tool info : (with Old script as chrome is not invoking with new script for the above range)
-----------------
You are probably looking for a change made after 470896 (known good), but no later than 470905 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/2a628672163491c90fde73c7c467fb059455dc28..41c0a94446d48dcb28ca10a03d41fec0ecfad346

Possible suspect:
----------------
https://chromium.googlesource.com/chromium/src/+/55a0543c377a69bbb9ab8c49629f037219289cd0

Review-Url: https://codereview.chromium.org/2846623003

mlamouri@, Could you please take a look and reassign to the right owner if it is not related to your change.
Thanks..!!
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93f44befa96838a3cff744431f2d3c0b05e70be2

commit 93f44befa96838a3cff744431f2d3c0b05e70be2
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu Jun 01 16:18:30 2017

Autoplay: fixes IPC traits for WebPreferences.

Bug:  726334 
Change-Id: If9232ab19e8bd3e39732aa7ee5944b6d6e9298bb
Reviewed-on: https://chromium-review.googlesource.com/520042
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476316}
[modify] https://crrev.com/93f44befa96838a3cff744431f2d3c0b05e70be2/content/public/common/common_param_traits_macros.h

Labels: Merge-Request-60
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 2 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please merge your change ASAP, planning to have a DEV RC soon.
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 3 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ecad2d7f6c51e2f6d6c4359502fda0deeabcf33

commit 9ecad2d7f6c51e2f6d6c4359502fda0deeabcf33
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Sat Jun 03 09:45:30 2017

Autoplay: fixes IPC traits for WebPreferences.

Bug:  726334 
Change-Id: If9232ab19e8bd3e39732aa7ee5944b6d6e9298bb
Reviewed-on: https://chromium-review.googlesource.com/520042
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#476316}
Review-Url: https://codereview.chromium.org/2922033002 .
Cr-Commit-Position: refs/branch-heads/3112@{#131}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/9ecad2d7f6c51e2f6d6c4359502fda0deeabcf33/content/public/common/common_param_traits_macros.h

Status: Fixed (was: Started)
Excuse my lack of communication: thank you for filing this bug and my apologies for the inconvenience! :)

Comment 14 Deleted

Labels: TE-Verified-M60 TE-Verified-60.0.3112.20
Verified this issue on Ubuntu 14.04, Windows-10 and Mac OS 10.12.5 using chrome latest dev M60-60.0.3112.20 by following steps mentioned in the original comment. Observed no crashes by enabling the flag chrome://flags/#autoplay-policy. Hence adding TE-Verified label.

Sign in to add a comment