New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726290 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Story failures on android-nexus5x

Project Member Reported by perezju@chromium.org, May 25 2017

Issue description

The following stories:
- browse:social:facebook
- browse:news:toi
- browse:social:twitter
- browse:news:cnn
- browse:media:youtube

Have started failing consistently on system_health.common_mobile since build:
https://luci-milo.appspot.com/buildbot/chromium.perf/Android%20Nexus5X%20Perf/88

The exception is a js timeout while navigating between elements in the story, e.g.:

Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 90, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 296, in RunStory
    self._current_page.Run(self)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/__init__.py", line 112, in Run
    self.RunPageInteractions(action_runner)
  File "/b/swarming/w/ir/tools/perf/page_sets/system_health/system_health_story.py", line 138, in RunPageInteractions
    self._DidLoadDocument(action_runner)
  File "/b/swarming/w/ir/tools/perf/page_sets/system_health/browsing_stories.py", line 81, in _DidLoadDocument
    self._NavigateToItem(action_runner, i)
  File "/b/swarming/w/ir/tools/perf/page_sets/system_health/browsing_stories.py", line 41, in _NavigateToItem
    container_selector=self.CONTAINER_SELECTOR)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 465, in ScrollPageToElement
    speed_in_pixels_per_second=speed_in_pixels_per_second))
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 56, in _RunAction
    action.RunAction(self._tab)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/scroll_to_element.py", line 85, in RunAction
    self._scroller.RunAction(tab)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/scroll.py", line 110, in RunAction
    tab.WaitForJavaScriptCondition('window.__scrollActionDone', timeout=60)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 191, in WaitForJavaScriptCondition
    return self._inspector_backend.WaitForJavaScriptCondition(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 293, in WaitForJavaScriptCondition
    e.message + '\n' + debug_message)
TimeoutException: Timed out while waiting 60s for IsJavaScriptExpressionTrue.
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus5X_Perf%2F88%2F%2B%2Frecipes%2Fsteps%2Fsystem_health.common_mobile_on_Android%2F0%2Fstdout

For some reason screenshots appear all black, e.g. browse:news:toi:
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/profiler-file-id_12-2017-05-23_16-40-5945202.png

CL range:
http://test-results.appspot.com/revision_range?start=473831&end=473887
 

Comment 2 Deleted

Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 25 2017

Cc: ke...@intel.com
Owner: ke...@intel.com

=== Auto-CCing suspected CL author ke.he@intel.com ===

Hi ke.he@intel.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : ke.he
  Commit : f6fd56037a18d025817064d21222bc078b081428
  Date   : Tue May 23 08:02:26 2017
  Subject: Convert devtools to be client of WakeLock mojo service.

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.common_mobile
  Metric       : cpuTimeToFirstMeaningfulPaint_avg/browse_social/browse_social_facebook

Revision             Exit Code      N
chromium@473831      0 +- N/A       5      good
chromium@473832      0 +- N/A       5      good
chromium@473833      1 +- N/A       5      bad       <--
chromium@473835      1 +- N/A       5      bad
chromium@473838      1 +- N/A       5      bad
chromium@473845      1 +- N/A       5      bad
chromium@473859      1 +- N/A       5      bad
chromium@473887      1 +- N/A       5      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.facebook system_health.common_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8978630654385720336

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6191903210471424


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 4 by ke...@intel.com, May 26 2017

Cc: dgozman@chromium.org
Mistakenly used the wrong wake lock type when converting devtools to be the client of WakeLock mojo service. I'll correct it soon.

Comment 5 by ke...@intel.com, May 26 2017

Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, May 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd2fa336d116912de565aa11f9b916341be3d579

commit dd2fa336d116912de565aa11f9b916341be3d579
Author: Ke He <ke.he@intel.com>
Date: Sat May 27 03:04:28 2017

Fix the wrong wake lock type in devtools

Mistakenly used the wrong wake lock type when converting devtools to be the
client of WakeLock mojo service.

BUG= 726290 

Change-Id: I38e824294b8e42a4cd959518c2e49a5acb773c03
Reviewed-on: https://chromium-review.googlesource.com/516827
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#475228}
[modify] https://crrev.com/dd2fa336d116912de565aa11f9b916341be3d579/content/browser/devtools/render_frame_devtools_agent_host.cc

Comment 7 by ke...@intel.com, May 27 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Stories are no longer failing
Issue 726689 has been merged into this issue.

Sign in to add a comment