Headless: window resizing should affect top level windows. |
||
Issue descriptionThe Browser.setWindowBounds DevTools command currently tries to reposition and resize windows by resizing the RWHV. As a result, window repositioning is not supported on Mac, because RWHVMac only supports setting the position for popups [1]. We should be setting the bounds of the actual window (on Mac in particular, but we should probably also do this for aura), e.g. via WebContentsView::GetTopLevelNativeWindow() [2]. This requires that all WebContents have their own top-level window (see blocking bug).
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4fde3627fa302b702440da6d6aec9522708c40b commit f4fde3627fa302b702440da6d6aec9522708c40b Author: eseckler <eseckler@chromium.org> Date: Thu May 25 11:08:36 2017 [headless] Fix window management browsertests on Mac. For now, simply disable the failing expectations for window positions. BUG= 726288 Review-Url: https://codereview.chromium.org/2905043003 Cr-Commit-Position: refs/heads/master@{#474623} [modify] https://crrev.com/f4fde3627fa302b702440da6d6aec9522708c40b/headless/lib/headless_devtools_client_browsertest.cc
,
Jul 3 2017
,
Jul 3 2017
,
Jul 3 2017
Note though that, on mac, we can't do what I proposed in #0, because we don't create any platform windows at all. |
||
►
Sign in to add a comment |
||
Comment 1 by eseckler@chromium.org
, May 25 2017