New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726279 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Manage spell check doesn't take long word in settings

Project Member Reported by sc00335...@techmahindra.com, May 25 2017

Issue description

Chrome Version: 60.0.3110.0 dev
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome and go to chrome://settings/editDictionary
(2)Give very long word [Ex: Google is an American multinational technology company specializing in Internet-related services and products. These include online advertising technologies, search, cloud computing, software, and hardware.Wikipedia] , hit add word button and observe

Expected: On hitting add word, given word should be displayed in the list below.
Actual: Instead nothing happens on clicking add word and given text is seen missing.

This is a regression issue broken in M60.

Good Build: 60.0.3109.0 dev
Bad Build: 60.0.3110.0 dev
 
Expected_add word.png
97.6 KB View Download
Actual_add word.ogv
780 KB View Download

Comment 1 by yosin@chromium.org, May 25 2017

Summary: NEEDS_BISECT: NERegression: Manage spell check doesn't take long word in settings (was: Regression: Manage spell check doesn't take long word in settings)

Comment 2 by yosin@chromium.org, May 25 2017

Components: -Blink>Editing>Spellcheck
Summary: NEEDS_BISECT: Regression: Manage spell check doesn't take long word in settings (was: NEEDS_BISECT: NERegression: Manage spell check doesn't take long word in settings)
This is Settings UI issue instead of Blink's spell checker.

Comment 3 by ajha@chromium.org, May 25 2017

Status: Untriaged (was: Unconfirmed)
There is no editDictionary option on Mac. Able to repro this on the latest canary(60.0.3110.0) of Linux Ubuntu 14.04.

Just to update, bisect is in progress for this.
Labels: -Needs-Bisect hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build: 60.0.3109.0 (Revision: 474118).
Bad build : 60.0.3110.0 (Revision: 474499).
You are probably looking for a change made after 474420 (known good), but no later than 474421 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/5a59f95a0fcbaa5976fa7e7247f77f430d9d041a..6997a3932e8fac115ef30c14a3c02178144dabf0

@scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.
Labels: Proj-MaterialDesign-WebUI

Comment 6 by ajha@chromium.org, May 25 2017

Summary: Regression: Manage spell check doesn't take long word in settings (was: NEEDS_BISECT: Regression: Manage spell check doesn't take long word in settings)
Owner: tbuck...@chromium.org
Investigated, this is not a regression issue. 

Previously in M59 (and also in settings-frame), if you try to add a long word, the interface will show the word "as though it had been added" into the dictionary, but in reality the word was not really committed into the dictionary, so if you refresh the page you'll see that the word isn't there.

My CL shown in the bisect only exposes this issue, since it doesn't "fake add" the word in the front-end anymore.

I suggest to make a new/repurpose this bug as "show an error message when the word is too long for the spell check dictionary."

Comment 8 by dpa...@chromium.org, Jun 12 2017

Labels: -Pri-1 Hotlist-MD-Settings-Languages Pri-2
Cc: msrchandra@chromium.org scottchen@chromium.org ranjitkan@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org
 Issue 768768  has been merged into this issue.
tbuckley@ any thoughts on this?
Cc: tbuck...@chromium.org
Labels: -M-60 -hasbisect-per-revision M-65
Owner: scottchen@chromium.org
Good point re #7, we should (1) turn the underline red and (2) disable the "Add word" button when the input is invalid. It seems like any words that are too long or strings that have spaces in them are considered invalid, though there may be more cases.
Summary: Manage spell check doesn't take long word in settings (was: Regression: Manage spell check doesn't take long word in settings)
Removing regression tag based on #7.
Status: Fixed (was: Assigned)
Labels: TE-Verified-M65 TE-Verified-65.0.3322.0
Tested the issue on Windows 10 and Ubuntu 14.04 using Chrome version M65 - 65.0.3322.0. Now on entering long data[used Google is an American multinational technology company specializing in Internet-related services and products. These include online advertising technologies, search, cloud computing, software, and hardware.Wikipedia] --- Add Word button is seen disabled, cannot exceed 99 letters error message is seen along with red underline as per change mentioned in comment#11 and #13.

Hence the fix is working as expected. Adding TE-Verified label. Attaching screenshot for reference.

Thank you!
Issue 726279.png
119 KB View Download

Sign in to add a comment