New issue
Advanced search Search tips

Issue 726265 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Heap-use-after-free in gpu::gles2::GLES2DecoderPassthroughImpl::DoBindTexture

Project Member Reported by ClusterFuzz, May 25 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5925209260687360

Fuzzer: libfuzzer_gpu_angle_passthrough_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-use-after-free WRITE 4
Crash Address: 0x6100000007fc
Crash State:
  gpu::gles2::GLES2DecoderPassthroughImpl::DoBindTexture
  gpu::gles2::GLES2DecoderPassthroughImpl::DoCommands
  gpu::CommandExecutor::ProcessCommands
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=470035:470101

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5925209260687360


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, May 25 2017

Labels: M-60
Project Member

Comment 2 by sheriffbot@chromium.org, May 25 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, May 25 2017

Labels: Pri-1

Comment 4 by kenrb@chromium.org, May 25 2017

Components: Internals>GPU>ANGLE
Owner: geoffl...@chromium.org
Status: Assigned (was: Untriaged)
geofflang@: The ANGLE fuzzer has hit a security regression, are you able to investigate?

There is an ANGLE roll in the regression range, but I don't see any obvious candidates for having caused this.
I'll take this, thanks.  It's likely a newly found bug, not a regression.
Labels: -ReleaseBlock-Beta
Removing the release-block, this code is not released yet.
Project Member

Comment 7 by sheriffbot@chromium.org, May 26 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59d2ca1729430fc7713e642d04a772773248f030

commit 59d2ca1729430fc7713e642d04a772773248f030
Author: geofflang <geofflang@chromium.org>
Date: Wed May 31 15:16:50 2017

Track currently bound external and multisample textures.

This caused assertions in glBindTexture even when binding 0. Caught by
the fuzzer which uses an ES 3.1 context.

BUG= 726265 
BUG= 719933 
BUG= 719803 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2909683002
Cr-Commit-Position: refs/heads/master@{#475912}

[modify] https://crrev.com/59d2ca1729430fc7713e642d04a772773248f030/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

Project Member

Comment 9 by ClusterFuzz, Jun 2 2017

ClusterFuzz has detected this issue as fixed in range 476362:476435.

Detailed report: https://clusterfuzz.com/testcase?key=5925209260687360

Fuzzer: libFuzzer_gpu_angle_passthrough_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-use-after-free WRITE 4
Crash Address: 0x6100000007fc
Crash State:
  gpu::gles2::GLES2DecoderPassthroughImpl::DoBindTexture
  gpu::gles2::GLES2DecoderPassthroughImpl::DoCommands
  gpu::CommandExecutor::ProcessCommands
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=470035:470101
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=476362:476435

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5925209260687360


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Jun 2 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5925209260687360 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Jun 2 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Request-60
Project Member

Comment 13 by sheriffbot@chromium.org, Jun 6 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Labels: -Restrict-View-SecurityNotify -Security_Impact-Head -Hotlist-Merge-Approved -Security_Severity-High -ReleaseBlock-Stable -M-60 -Merge-Approved-60
Removing security and merge labels.  This bug is not exposed in any Chrome release.
Labels: -Type-Bug-Security Type-Bug

Sign in to add a comment