Regression: Overlapping is seen in people section of settings page |
||||||||
Issue descriptionChrome Version: 60.0.3110.0 dev OS: Ubuntu 14.04,windows What steps will reproduce the problem? (1)Launch chrome and open settings page >> In people section give long name (2)Hit tab and observe focus on arrow icon Expected:Ripple effect should not overlap with name. Actual: Instead overlapping of ripple effect is seen. This is a regression issue broken in M60. Good Build: 60.0.3103.0 dev Bad Build: 60.0.3104.0 dev
,
May 25 2017
Using per revision bisect providing the information below Bisect Information: -------------------- You are probably looking for a change made after 472975 (known good), but no later than 472976 (first known bad). Change Log URL: https://chromium.googlesource.com/chromium/src/+log/385931fbf1990470dde91e5f12c75db5680193c4..8a14c40573ecd9fbf68ac4c4d97b9e4c9f504a6d From the above change log suspecting below change Review URL: https://codereview.chromium.org/2893483002 dschuyler@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
May 25 2017
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e959cddaeca101036a8edf445a5d57c629632afc commit e959cddaeca101036a8edf445a5d57c629632afc Author: dschuyler <dschuyler@chromium.org> Date: Wed May 31 22:31:27 2017 [MD settings] adjust button layout This CL gives proper spacing of paper-buttons in settings boxes. There are several cases to consider: a button at the start of a row; a button at the end of the row; multiple buttons in a row; buttons before or after a separator. BUG= 725172 , 726262 , 724944 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2902363002 Cr-Commit-Position: refs/heads/master@{#476067} [modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/chrome/browser/resources/settings/controls/controlled_button.html [modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html [modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html [modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/ui/webui/resources/cr_elements/shared_style_css.html [modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/ui/webui/resources/cr_elements/shared_vars_css.html
,
May 31 2017
,
Jun 6 2017
Merge-Request-60
,
Jun 7 2017
,
Jun 7 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c366c9166c518e396d66db4edf2a7f0dba12e7f0 commit c366c9166c518e396d66db4edf2a7f0dba12e7f0 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Jun 07 21:03:17 2017 [MD settings] adjust button layout This CL gives proper spacing of paper-buttons in settings boxes. There are several cases to consider: a button at the start of a row; a button at the end of the row; multiple buttons in a row; buttons before or after a separator. BUG= 725172 , 726262 , 724944 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2902363002 Cr-Original-Commit-Position: refs/heads/master@{#476067} Review-Url: https://codereview.chromium.org/2931723002 . Cr-Commit-Position: refs/branch-heads/3112@{#235} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/chrome/browser/resources/settings/controls/controlled_button.html [modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html [modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html [modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/ui/webui/resources/cr_elements/shared_style_css.html [modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/ui/webui/resources/cr_elements/shared_vars_css.html
,
Jun 8 2017
Tested the fix on windows 7, Ubuntu 14.04 and Mac 10.12.5 using chrome version 60.0.3112.24. overlapping issue is not observed. Please find the attached screen cast for the same. adding TE-Verified labels. Thanks, |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ajha@chromium.org
, May 25 2017Status: Untriaged (was: Unconfirmed)