New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726261 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----



Sign in to add a comment

Polymerize Findit UI

Project Member Reported by st...@chromium.org, May 25 2017

Issue description

This is a meta bugs to track the work on polymerizing Findit UI.

Test result is almost migrated to polymer, but most other pages are not yet.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2017

Project Member

Comment 2 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6802cf635c938aabaf9d06ab7394009feb0887fd

commit 6802cf635c938aabaf9d06ab7394009feb0887fd
Author: rlanday <rlanday@chromium.org>
Date: Tue May 30 17:48:36 2017

[Reland] Add presubmit rule banning relative header includes

This CL was reverted because it had a bug making it catch all changes to C++
files in the directories it applied to (I thought the fact that I had
successfully uploaded the CL itself verified the rule wouldn't trigger on
unrelated changes...but PRESUBMIT.py is not a C++ file). I have fixed the bug in
this version.

Original CL:
https://codereview.chromium.org/2900173003

Revert:
https://codereview.chromium.org/2897383002

Original description:

Relative header includes (#include path containing "../") can be used to cheat
the dependency system because they're not checked properly. This CL adds a
presubmit rule to catch these.

This rules applies to third_party/WebKit, but not anywhere else in third_party/.
There's one currently existing file I know of that would fail this rule:
ppapi/lib/gl/include/GLES2/gl2.h

I did not change this file when cleaning up the other headers since it appears
to be code imported from a third-party repo. I guess whoever updates this file
will have to bypass the rule.

BUG= 724264 

Review-Url: https://codereview.chromium.org/2900253003
Cr-Commit-Position: refs/heads/master@{#475587}

[modify] https://crrev.com/6802cf635c938aabaf9d06ab7394009feb0887fd/PRESUBMIT.py
[modify] https://crrev.com/6802cf635c938aabaf9d06ab7394009feb0887fd/PRESUBMIT_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/99b54da1474e989abbfab054304e245bf2d202f8

commit 99b54da1474e989abbfab054304e245bf2d202f8
Author: Shuotao Gao <stgao@chromium.org>
Date: Tue May 30 22:22:49 2017

[Findit] Automatically reinstall polymer for production deployment.

For testing deployment, let's go with manual install to avoid overhead of re-installment.

Bug:  726261 
Change-Id: I8b038c76ca08e93184bbdbda8987858a2ff261cd
Reviewed-on: https://chromium-review.googlesource.com/517916
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/99b54da1474e989abbfab054304e245bf2d202f8/appengine/findit/waterfall-backend.yaml
[modify] https://crrev.com/99b54da1474e989abbfab054304e245bf2d202f8/appengine/findit/util_scripts/run.sh

Project Member

Comment 4 by sheriffbot@chromium.org, May 31 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by wylieb@chromium.org, May 31 2018

Cc: -wylieb@chromium.org

Comment 6 by st...@chromium.org, Jun 14 2018

Cc: -robert...@chromium.org -chanli@chromium.org -lijeffrey@chromium.org -st...@chromium.org
Status: Archived (was: Untriaged)
This was half done. Prasad is looking into this in a separate bug. Thus close this one.

Sign in to add a comment