Comments on alerts should be in a more formal date format |
||||
Issue descriptione.g.: "5/25/2017, 4:46:54 PM GMT+10" - The American date format is hurting my head. It's hard for a non-American to read as it's middle-endian. - GMT is not a formal thing, please use "UTC" instead. It should be in a more formal time format, either ISO 8601 (as shown by "date -Is") or RFC 2822 (as shown by "date -R"). The former (massaged a bit for readability): 2017-05-25 16:46:54 +1000 The latter: Thu, 25 May 2017 16:46:54 +1000 (Could also use 12-hour time. The important thing is that the date is either yyyy-mm-dd or uses the name of the month.) See also: https://xkcd.com/1179/
,
May 26 2017
+bevc I think this would make a great starter bug if you're interested in trying out making some small changes to Sheriff-o-Matic whenever. The timestamp talked about in this bug is rendered here: https://cs.chromium.org/chromium/infra/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.html?l=183 You'd want to focus on editing the JavaScript that computes the timestamp here: https://cs.chromium.org/chromium/infra/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.js?l=403 For relative times and handling of time formatting, we've been using the JavaScript library moment.js ( https://momentjs.com/ ) in other parts of Sheriff-o-Matic. (@Sean: Bev expressed interest in learning Polymer as part of her 20% time)
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/bf1d37a09ac165add5c32bf0f6b47ea9a78f77d2 commit bf1d37a09ac165add5c32bf0f6b47ea9a78f77d2 Author: Bev Cristobal <bevc@google.com> Date: Thu Jun 29 23:02:22 2017 Changing date format for comments on alerts Bug:726258 Change-Id: Ia3dbd211f5f09a716efe2100b83ffc7c7f397a7c Reviewed-on: https://chromium-review.googlesource.com/556959 Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org> Commit-Queue: Beverly Cristobal <bevc@google.com> [modify] https://crrev.com/bf1d37a09ac165add5c32bf0f6b47ea9a78f77d2/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.js
,
Jul 10 2017
Format should be changed in the next release of
,
Jul 12 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by zhangtiff@chromium.org
, May 26 2017Labels: -Infra-Troopers Milestone-UX
Status: Available (was: Untriaged)