Android Chrome 59 beta translation not working
Reported by
giovanni...@gmail.com,
May 25 2017
|
|||||||||||||||||||||
Issue descriptionSteps to reproduce the problem: 1. open a web page 2. highlight a word 3. select TRANSLATE from overlay menu 4. nothing happens What is the expected behavior? Translation overlay should appear What went wrong? Translation overlay does not appear, nothing happens Did this work before? Yes 58 stable Chrome version: 59 Channel: beta OS Version: 7.1.2 Flash Version: Platform: ANDROID 7.1.2 Chrome version: 59 beta Translation works on version 58 stable. And yes: I have tried clearing cache, uninstalling and reinstalling & co. and nothing worked.
,
May 25 2017
1. Nexus 6p with 7.1.2 and Samsung Galaxy Tab S2 with 6.0.1 2. Yes 3. and 4. Will record and attach here file
,
May 25 2017
Thank you for providing more feedback. Adding requester "rsgavara@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 25 2017
Recording attached. I try first with beta than with stable and eventually with beta again: you can see that only in stable works.
,
May 25 2017
,
May 25 2017
Adding folk that have touched select popups recently
,
May 25 2017
I can also repro this on my personal device (OnePlue One w/ Android M). The bug is there on beta (M59.0.3071.71) but not on stable (M58.0.3029.83). I couldn't repro on my test device (Nexus 6P w/ Android O). Also noticed that on stable after clicking "Translate" the selection and touch handles stay but on beta they disappear. Maybe that is related.
,
May 25 2017
"Also noticed that on stable after clicking "Translate" the selection and touch handles stay but on beta they disappear. Maybe that is related." Same here
,
May 26 2017
I wrongly assumed that the MenuItem is cannot be 0. The fix is in the works.
,
May 26 2017
,
May 26 2017
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a978f857db529cd85a416d5b6b274b1fb148c9c8 commit a978f857db529cd85a416d5b6b274b1fb148c9c8 Author: timav <timav@chromium.org> Date: Fri May 26 20:12:08 2017 Fix the handling of the text prosessing items in the popup menu The prior code wrongly assumed that the item ID of a MenuItem can not be zero. Because of this for zero ID items prior to Android O the wrong method (doAssistAction()) was called which did not do anything. This fix removes doAssistAction() from valid choices prior to Android O. BUG= 726252 Review-Url: https://codereview.chromium.org/2899043007 Cr-Commit-Position: refs/heads/master@{#475101} [modify] https://crrev.com/a978f857db529cd85a416d5b6b274b1fb148c9c8/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
,
May 26 2017
,
May 26 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4462e6b2ef4336dc80b27cfc81d2e3a5c55679e0 commit 4462e6b2ef4336dc80b27cfc81d2e3a5c55679e0 Author: Tima Vaisburd <timav@chromium.org> Date: Fri May 26 20:32:13 2017 Fix the handling of the text prosessing items in the popup menu The prior code wrongly assumed that the item ID of a MenuItem can not be zero. Because of this for zero ID items prior to Android O the wrong method (doAssistAction()) was called which did not do anything. This fix removes doAssistAction() from valid choices prior to Android O. BUG= 726252 Review-Url: https://codereview.chromium.org/2899043007 Cr-Original-Commit-Position: refs/heads/master@{#475101} Review-Url: https://codereview.chromium.org/2908823002 . Cr-Commit-Position: refs/branch-heads/3071@{#705} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/4462e6b2ef4336dc80b27cfc81d2e3a5c55679e0/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
,
May 26 2017
Fixed on trunk and branch, marking as such.
,
May 30 2017
So when will this fix be deployed to beta version?
,
May 30 2017
Should be in 59.0.3071.76
,
Jul 14 2017
Hi, problem got solved indeed in 59.0.3071.76 but appeared again in 60.0
,
Jul 14 2017
Does not work on both nexus 6p and galaxy tab s2
,
Jul 14 2017
Selim, can you take a look if this is needed before Tuesday?
,
Jul 14 2017
Satya: Can somebody in test team please confirm the isssue?
,
Jul 17 2017
News?
,
Jul 17 2017
dneelamegam@ is checking, he will update the bug soon.
,
Jul 17 2017
Cannot repro this bug from webview side, checked on webview shell browser and gmail with webview versions : M59.0.3071.71/ M60.0.3112.66/70/ M61.0.3159.0 on Samsung S8/NRD90M adn Nexus 6p/O. Looks like chrome specific issue
,
Jul 17 2017
rsgavara@, can you test it in Chrome?
,
Jul 17 2017
I can confirm that in webview works, not in Chrome though
,
Jul 17 2017
giovanni.stoto@ What version of Chrome are you on? I am not able to repro this issue on M60.0.3112.66/70/ M61.0.3159.0 on Nexusw 6P
,
Jul 17 2017
60.0.3112.66
,
Jul 17 2017
Thank you for providing more feedback. Adding requester "rsgavara@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 17 2017
Oh and of course I've tried deleting cache etc. 😉
,
Jul 17 2017
This issue is fixed on M59 and M61 but not on M60. I could repro on Nexus 6P/ N2G47G (looks OS specific, I couldn't repro on different OS earlier). We need to merge this to M60.
,
Jul 18 2017
The fix in trunk narrowly missed M60 branch, needs to be merged there too. Requesting the merge.
,
Jul 18 2017
This bug requires manual review: We are only 6 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 18 2017
Approved for M60 branch 3112.
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c20a4eccc62306db3c72777d44b8be5f11385d24 commit c20a4eccc62306db3c72777d44b8be5f11385d24 Author: Tima Vaisburd <timav@chromium.org> Date: Tue Jul 18 23:54:34 2017 Fix the handling of the text prosessing items in the popup menu The prior code wrongly assumed that the item ID of a MenuItem can not be zero. Because of this for zero ID items prior to Android O the wrong method (doAssistAction()) was called which did not do anything. This fix removes doAssistAction() from valid choices prior to Android O. BUG= 726252 TBR=timav@chromium.org (cherry picked from commit a978f857db529cd85a416d5b6b274b1fb148c9c8) Review-Url: https://codereview.chromium.org/2899043007 Cr-Original-Commit-Position: refs/heads/master@{#475101} Change-Id: I287ae6c967cb522bc7e031405d21da81e9c61190 Reviewed-on: https://chromium-review.googlesource.com/576860 Reviewed-by: Tima Vaisburd <timav@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#645} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/c20a4eccc62306db3c72777d44b8be5f11385d24/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
,
Jul 18 2017
,
Jul 20 2017
Just upgraded to 60.x and bug is fixed. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by rsgav...@chromium.org
, May 25 2017