New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726245 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 723144



Sign in to add a comment

Add Progress notification on new-style notification

Project Member Reported by yoshiki@chromium.org, May 25 2017

Issue description

Progress notification is not supported yet on new-style notification. We need to implement.
 
Owner: fukino@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by fukino@chromium.org, May 30 2017

Blocking: 723144

Comment 3 by tetsui@chromium.org, Jun 14 2017

Cc: tetsui@chromium.org

Comment 4 by tetsui@chromium.org, Jun 14 2017

Owner: tetsui@chromium.org

Comment 5 by tetsui@chromium.org, Jun 16 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1046503e7e4f933250371d4af0742a463e6b4f77

commit 1046503e7e4f933250371d4af0742a463e6b4f77
Author: tetsui <tetsui@chromium.org>
Date: Thu Jun 22 04:50:59 2017

Add progress notification support to new-style notification.

CompactTitleMessageView is added to follow Android's behavior showing
notification title and message in single line when it has progress bar.
Also, added constructor option allow_round_corner to views::ProgressBar
so that progress bar style follows Material Design mock.

BUG= 726245 
TEST=manually tested by progress notification with
* short title, short message
* short title, long message
* long title, long message

Review-Url: https://codereview.chromium.org/2942143002
Cr-Commit-Position: refs/heads/master@{#481439}

[modify] https://crrev.com/1046503e7e4f933250371d4af0742a463e6b4f77/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/1046503e7e4f933250371d4af0742a463e6b4f77/ui/message_center/views/notification_view_md.h
[modify] https://crrev.com/1046503e7e4f933250371d4af0742a463e6b4f77/ui/views/controls/progress_bar.cc
[modify] https://crrev.com/1046503e7e4f933250371d4af0742a463e6b4f77/ui/views/controls/progress_bar.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a7d1693d5a2effc4539153daa67023deccbc200

commit 0a7d1693d5a2effc4539153daa67023deccbc200
Author: tetsui <tetsui@chromium.org>
Date: Tue Jun 27 08:52:22 2017

Add percentage of progress in notification header.

Add percentage of progress in the header of new-style notification, so
that it would be consistent with the mock.

BUG= 726245 
TEST=manual, including environment with RTL language (Hebrew).
Android does not have this for progress bar at system level, so consistency wouldn't be a problem for this.

Review-Url: https://codereview.chromium.org/2945303006
Cr-Commit-Position: refs/heads/master@{#482574}

[modify] https://crrev.com/0a7d1693d5a2effc4539153daa67023deccbc200/ui/message_center/views/notification_header_view.cc
[modify] https://crrev.com/0a7d1693d5a2effc4539153daa67023deccbc200/ui/message_center/views/notification_header_view.h
[modify] https://crrev.com/0a7d1693d5a2effc4539153daa67023deccbc200/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/0a7d1693d5a2effc4539153daa67023deccbc200/ui/strings/ui_strings.grd

Status: Fixed (was: Started)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment