New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726244 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 723144



Sign in to add a comment

Add List notification support to new-style notification

Project Member Reported by yoshiki@chromium.org, May 25 2017

Issue description

List notification is not supported yet on new-style notification. We need to implement.
 
Owner: fukino@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by fukino@chromium.org, May 30 2017

Blocking: 723144
Owner: tetsui@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cf375029b9abf4be32a79fbd7798622e12e569e

commit 4cf375029b9abf4be32a79fbd7798622e12e569e
Author: tetsui <tetsui@chromium.org>
Date: Mon Jun 26 06:12:40 2017

Show number of hidden items in new-style list notification.

Show number of hidden items on the right bottom of the new-style
notification in both collapsed and expanded state.

BUG= 726244 
TEST=manual, also tested in RTL language (Hebrew)

Review-Url: https://codereview.chromium.org/2941043004
Cr-Commit-Position: refs/heads/master@{#482198}

[modify] https://crrev.com/4cf375029b9abf4be32a79fbd7798622e12e569e/ui/message_center/message_center_style.h
[modify] https://crrev.com/4cf375029b9abf4be32a79fbd7798622e12e569e/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/4cf375029b9abf4be32a79fbd7798622e12e569e/ui/message_center/views/notification_view_md.h
[modify] https://crrev.com/4cf375029b9abf4be32a79fbd7798622e12e569e/ui/strings/ui_strings.grd

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f0bd13b3cf5ac9b2794dc4b30f3d3bb5271c8f6

commit 2f0bd13b3cf5ac9b2794dc4b30f3d3bb5271c8f6
Author: tetsui <tetsui@chromium.org>
Date: Mon Jul 03 09:13:48 2017

Move overflow indicator to notifiction header.

In list notification of new-style notification, overflow indicator was
shown on the right bottom of the notification. Now this is moved to the
notification header so that it is compatible with the mock.
This CL also adds divider string between the title and the message of a
list notification sub item.

BUG= 726244 
TEST=manual

Review-Url: https://codereview.chromium.org/2966693002
Cr-Commit-Position: refs/heads/master@{#483967}

[modify] https://crrev.com/2f0bd13b3cf5ac9b2794dc4b30f3d3bb5271c8f6/ui/message_center/views/notification_header_view.cc
[modify] https://crrev.com/2f0bd13b3cf5ac9b2794dc4b30f3d3bb5271c8f6/ui/message_center/views/notification_header_view.h
[modify] https://crrev.com/2f0bd13b3cf5ac9b2794dc4b30f3d3bb5271c8f6/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/2f0bd13b3cf5ac9b2794dc4b30f3d3bb5271c8f6/ui/message_center/views/notification_view_md.h
[modify] https://crrev.com/2f0bd13b3cf5ac9b2794dc4b30f3d3bb5271c8f6/ui/strings/ui_strings.grd

Status: Fixed (was: Started)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment