New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726242 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 723144



Sign in to add a comment

Add buttons to new-style notification

Project Member Reported by yoshiki@chromium.org, May 25 2017

Issue description

We should show buttons on new-style notification. It's not implemented yet.
 
Owner: fukino@chromium.org
Status: Assigned (was: Available)

Comment 3 by fukino@chromium.org, May 30 2017

Blocking: 723144
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63a16add8253bc6a138329c648ba82a5492f11f0

commit 63a16add8253bc6a138329c648ba82a5492f11f0
Author: fukino <fukino@chromium.org>
Date: Mon Jun 12 10:56:17 2017

Notification: Implement two-leveled notification.

The new-style notification should have two states: Collapsed(default) and Expanded.
To implement the feature, this CL does:
* Create NotificationHeaderView which is responsible to keeps app_icon, app_name, expand_button, settings_button, and close_button.
* When the expand_button is clicked, some view's visibility and message_view's line limit is modified to have "expanded" view.

For simplicity, I avoided dynamic creation/deletion of views on expanded state change. The expanded state only changes the existing view's property.
If it hit noticeable performance regression, I'll update the way to change the view.

BUG= 728500 , 726242 
TEST=manually tested expand/collapse function on following notifications using --enabled-new-style-notification
* A basic notification with one-line message (This doesn't have expand icon.)
* A basic notificatoin with two-line message
* A basic notification with two buttons
* A image notification

Review-Url: https://codereview.chromium.org/2925263003
Cr-Commit-Position: refs/heads/master@{#478587}

[modify] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/BUILD.gn
[add] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/vector_icons/notification_expand_less.icon
[add] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/vector_icons/notification_expand_more.icon
[add] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/views/notification_header_view.cc
[add] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/views/notification_header_view.h
[modify] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/views/notification_view_md.h

Comment 5 by tetsui@chromium.org, Jun 14 2017

Cc: tetsui@chromium.org

Comment 6 by tetsui@chromium.org, Jun 27 2017

Owner: tetsui@chromium.org
Can I take this? Feel free to get it back. Thanks!

Comment 7 by tetsui@chromium.org, Jun 27 2017

Status: Started (was: Assigned)
Actually almost done by fukino@ in #4. (Thanks!)
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9776accebbf3a0e8a2a5abfe8f844d532bc65df

commit b9776accebbf3a0e8a2a5abfe8f844d532bc65df
Author: tetsui <tetsui@chromium.org>
Date: Thu Jun 29 12:32:48 2017

Add ripple effect to action buttons in new-style notification.

Hover background color and ripple effect are added to action buttons in
new-style notification. The padding is also adjusted.

BUG= 726242 
TEST=manual

Review-Url: https://codereview.chromium.org/2958963002
Cr-Commit-Position: refs/heads/master@{#483335}

[modify] https://crrev.com/b9776accebbf3a0e8a2a5abfe8f844d532bc65df/ui/message_center/views/notification_view_md.cc

Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment