Small icons for system notifications |
||||||||||||||||||||||||
Issue descriptionWe need small icons for system notifications to show at top left of new-style notifications. New-style notification shows Chrome icon by default, but first-party system notifications should show the dedicated icons.
,
Jun 14 2017
,
Jun 15 2017
Issue 606819 has been merged into this issue.
,
Jun 15 2017
Things tdanderson@ suggested related to the merged issue (Thanks!): - Audit the code base to see all the system notifications we show, and make sure that the "first party system notifications" slides in the mocks do in fact cover all cases. Perhaps this has already been done, I'm not sure. - Once MD notifications are on by default, there are probably some PNG and .icon files that will no longer be in use and can be deleted from the code base.
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/763959aadf1e04d49c0b997cda3d31296f63f172 commit 763959aadf1e04d49c0b997cda3d31296f63f172 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Jul 20 10:06:04 2017 Add header UI string that will be used in MD notification. Add "Chrome OS system" string that will be used for system notification when new-style notification is enabled. BUG=738779, 726241 , 740807 , 740813 TEST=manual Change-Id: I2e4ce586385065752abcc4e38445b7e67c6bb2ef Reviewed-on: https://chromium-review.googlesource.com/578696 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#488182} [modify] https://crrev.com/763959aadf1e04d49c0b997cda3d31296f63f172/ui/strings/ui_strings.grd
,
Jul 26 2017
Sorry for the delay on this. Small icons are now delivered here: https://drive.google.com/drive/folders/0B6x6iYCtKinEUnE4YmxOUGVwcVk?usp=sharing These are to be used like any other chromeOS icons using estade@ vectorized icon in native ui (https://www.chromium.org/developers/how-tos/vectorized-icons-in-native-chrome-ui) Please let me know if any icon I might have forgotten. This goes hand in hand with the new specs you can find here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZYhMpwexg3v6/files/MCEPdLqJ65RgUDaxmwZhTQJJwMSJbxAVNpw
,
Jul 27 2017
sgabriel@: Thank you for the icons! Once https://crbug.com/c/566765/ is landed, I will start applying theme colors and these icons to the system notifications.
,
Aug 1 2017
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01f38b46d3446cc7ae3f482d59dbc1841f625479 commit 01f38b46d3446cc7ae3f482d59dbc1841f625479 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Aug 03 01:16:26 2017 Add first-party notification styling in MD notification. In new-style notification, first-party notification should have different styling compared to general web notifications. To do this, all system notifications should be created by new CreateSystemNotification. (Previously, it was not a requirement.) By using the function, * the display source defaults to string "ChromeOS system". * the notification has single accent color based on SystemNotificationWarningLevel. * gfx::VectorIcon will be passed as small_image instead of gfx::Image to perform icon coloring on CreateSystemNotification side. TEST=out/Debug/message_center_unittests BUG=738779, 726241 , 740807 , 740813 Change-Id: I9e85b3f1de33b6499297f060b5305d0b02157eef Reviewed-on: https://chromium-review.googlesource.com/566765 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#491592} [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/chrome/browser/chromeos/chrome_browser_main_chromeos.cc [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/ui/message_center/BUILD.gn [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/ui/message_center/fake_message_center.cc [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/ui/message_center/fake_message_center.h [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/ui/message_center/message_center.h [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/ui/message_center/message_center_impl.cc [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/ui/message_center/message_center_impl.h [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/ui/message_center/message_center_style.h [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/ui/message_center/notification.cc [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/ui/message_center/notification.h [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/ui/message_center/views/notification_header_view.cc [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/ui/message_center/views/notification_header_view.h [modify] https://crrev.com/01f38b46d3446cc7ae3f482d59dbc1841f625479/ui/message_center/views/notification_view_md.cc
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e3561e0926074e531406ce0fb035e1e3a0d9c39 commit 9e3561e0926074e531406ce0fb035e1e3a0d9c39 Author: John Mellor <johnme@chromium.org> Date: Thu Aug 03 11:10:58 2017 Revert "Add first-party notification styling in MD notification." This reverts commit 01f38b46d3446cc7ae3f482d59dbc1841f625479. Reason for revert: Sorry, this broke compilation on 3 bots: - https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builder%20%28dbg%29 - https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builder%20%28dbg%29 - https://build.chromium.org/p/chromium.android/builders/Android%20MIPS%20Builder%20%28dbg%29 With the following linker error: obj/ui/message_center/message_center/notification.o: In function `message_center::Notification::CreateSystemNotification(...)': ../../ui/message_center/notification.cc:182: undefined reference to `gfx::kNoneIcon' obj/ui/message_center/message_center/notification.o: In function `message_center::Notification::CreateSystemNotification(...)': ../../ui/message_center/notification.cc:232: undefined reference to `gfx::CreateVectorIcon(gfx::VectorIcon const&, unsigned int)' Original change's description: > Add first-party notification styling in MD notification. > > In new-style notification, first-party notification should have > different styling compared to general web notifications. > To do this, all system notifications should be created by > new CreateSystemNotification. (Previously, it was not a requirement.) > > By using the function, > * the display source defaults to string "ChromeOS system". > * the notification has single accent color based on > SystemNotificationWarningLevel. > * gfx::VectorIcon will be passed as small_image instead of gfx::Image > to perform icon coloring on CreateSystemNotification side. > > TEST=out/Debug/message_center_unittests > BUG=738779, 726241 , 740807 , 740813 > > Change-Id: I9e85b3f1de33b6499297f060b5305d0b02157eef > Reviewed-on: https://chromium-review.googlesource.com/566765 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491592} TBR=jamescook@chromium.org,yoshiki@chromium.org,peter@chromium.org,fukino@chromium.org,tetsui@chromium.org Change-Id: I10fe30dbdad6012fbafe32c17a439065f4d816d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 738779, 726241 , 740807 , 740813 Reviewed-on: https://chromium-review.googlesource.com/600067 Reviewed-by: John Mellor <johnme@chromium.org> Commit-Queue: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/heads/master@{#491696} [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/chrome/browser/chromeos/chrome_browser_main_chromeos.cc [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/ui/message_center/BUILD.gn [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/ui/message_center/fake_message_center.cc [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/ui/message_center/fake_message_center.h [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/ui/message_center/message_center.h [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/ui/message_center/message_center_impl.cc [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/ui/message_center/message_center_impl.h [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/ui/message_center/message_center_style.h [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/ui/message_center/notification.cc [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/ui/message_center/notification.h [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/ui/message_center/views/notification_header_view.cc [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/ui/message_center/views/notification_header_view.h [modify] https://crrev.com/9e3561e0926074e531406ce0fb035e1e3a0d9c39/ui/message_center/views/notification_view_md.cc
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ead8b5b61dacc735f3840152ecc5a11c80c724da commit ead8b5b61dacc735f3840152ecc5a11c80c724da Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Aug 10 02:14:46 2017 Reland "Add first-party notification styling in MD notification." This is a reland of 01f38b46d3446cc7ae3f482d59dbc1841f625479 Fix from the original CL: * Link gfx::VectorIcon and gfx::PaintVectorIcon on Android build, as they are now used in message_center::Notification, which is common for all the platforms that uses ui/message_center. Original change's description: > Add first-party notification styling in MD notification. > > In new-style notification, first-party notification should have > different styling compared to general web notifications. > To do this, all system notifications should be created by > new CreateSystemNotification. (Previously, it was not a requirement.) > > By using the function, > * the display source defaults to string "ChromeOS system". > * the notification has single accent color based on > SystemNotificationWarningLevel. > * gfx::VectorIcon will be passed as small_image instead of gfx::Image > to perform icon coloring on CreateSystemNotification side. > > TEST=out/Debug/message_center_unittests > BUG=738779, 726241 , 740807 , 740813 > > Change-Id: I9e85b3f1de33b6499297f060b5305d0b02157eef > Reviewed-on: https://chromium-review.googlesource.com/566765 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491592} Bug: 738779, 726241 , 740807 , 740813 Change-Id: I62fa4644347ce62d629f3218d319b09ac74db097 Reviewed-on: https://chromium-review.googlesource.com/601611 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#493228} [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/chrome/browser/chromeos/chrome_browser_main_chromeos.cc [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/gfx/BUILD.gn [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/message_center/BUILD.gn [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/message_center/fake_message_center.cc [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/message_center/fake_message_center.h [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/message_center/message_center.h [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/message_center/message_center_impl.cc [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/message_center/message_center_impl.h [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/message_center/message_center_style.h [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/message_center/notification.cc [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/message_center/notification.h [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/message_center/views/notification_header_view.cc [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/message_center/views/notification_header_view.h [modify] https://crrev.com/ead8b5b61dacc735f3840152ecc5a11c80c724da/ui/message_center/views/notification_view_md.cc
,
Aug 25 2017
sgabriel@: Drive link in #7 is not working. Could you share this again? Thanks!
,
Aug 25 2017
Here's a working link: https://drive.google.com/drive/folders/0B6x6iYCtKinEQTEwc1l4QkxiRXM?usp=sharing
,
Aug 29 2017
sgabriel@: In the code review, estade@ pointed out to add 1x version only if there are any tweaks. In the assets you provided in #14, all the 1x version and 2x version seem to be same, but I'm not confident with that. Is there any icon that have such tweaks? Thank you for your help.
,
Aug 29 2017
No they are not all the same scaled up assets, most of them have slight differences to fit the pixel grid, shipping both in this case makes sense.
,
Sep 7 2017
,
Sep 8 2017
sgabriel@: I created the list of notifications that are missing from the mock, and require new icons. go/cros-md-notification-icons-needed I wonder if you would take a look at this. Thank you for all your support.
,
Sep 11 2017
Thanks a lot for the detailed list. I have updated the assets repository with the necessary icons: ic_notification_warning ic_notification_google ic_notification_play_prism ic_notification_printing ic_notification_printing_warning ic_notification_printing_done ic_notification_charging_usb_c ic_notification_supervised ic_notification_data In addition, I'd like to modify the following notifications: All_ Remove all right icons. Google Survey_ Remove the "TAKE SURVEY" button as this should be handled by the notification main tap target, this is redundant. Remove the right icon. Change the content to a shorter string: "Let us know how we’re doing." so that we don't need to have an expandable notification Google Play_ Remove the entire expanded mode, OPEN PLAY STORE is redundant, it should be the main target, NO THANKS == close the notification. Remove the right icon. Language change_ Add title (see mock) I believe the 2 last ones (tethering and sms) are handled by somebody else in the team, respectively elizabethchiu@ and shibasheikh@
,
Sep 11 2017
Assets also added to the repo: https://drive.google.com/drive/folders/0B6x6iYCtKinEQTEwc1l4QkxiRXM?usp=sharing
,
Sep 11 2017
Thank you for your quick response! I would replace them with icons you provided soon.
,
Sep 11 2017
Sounds good. Let me know if any are missing.
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6eb7fb46d997babd4e903b11e83315dbab9d1478 commit 6eb7fb46d997babd4e903b11e83315dbab9d1478 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Sep 13 02:05:20 2017 Add material design icon to locale change notification. This CL adds new material design icon to locale change notification. This CL also adds the notification title and shortens the message based on UX review ( https://crbug.com/726241#c20 ). The icon and the accent color is effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: I16ac609c9f453064e27441c149ef2e4bcfa08d31 Reviewed-on: https://chromium-review.googlesource.com/662917 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#501514} [modify] https://crrev.com/6eb7fb46d997babd4e903b11e83315dbab9d1478/ash/ash_strings.grd [modify] https://crrev.com/6eb7fb46d997babd4e903b11e83315dbab9d1478/ash/system/locale/locale_notification_controller.cc
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bb84bdc46eecf7ac41a1f3bce41f525b614bde7 commit 8bb84bdc46eecf7ac41a1f3bce41f525b614bde7 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Sep 14 01:57:40 2017 Adjust survey notification for new style notification. This CL adds new icon to HaTS user survey notification. This CL also removes notification buttons and changes notification message shorter based on UX review ( https://crbug.com/726241#c20 ). The icon and the accent color are effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: I53bac25abfe27775c191629728d6eb01dd2af65f Reviewed-on: https://chromium-review.googlesource.com/662899 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#501839} [modify] https://crrev.com/8bb84bdc46eecf7ac41a1f3bce41f525b614bde7/ash/ash_strings.grd [modify] https://crrev.com/8bb84bdc46eecf7ac41a1f3bce41f525b614bde7/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/8bb84bdc46eecf7ac41a1f3bce41f525b614bde7/chrome/app/vector_icons/notification_google.icon [modify] https://crrev.com/8bb84bdc46eecf7ac41a1f3bce41f525b614bde7/chrome/browser/chromeos/hats/hats_notification_controller.cc
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6071701f1276591080573f7b11617dd1177e159f commit 6071701f1276591080573f7b11617dd1177e159f Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Sep 14 03:42:58 2017 Add material design icon to dual role charge notification. This CL adds new material design icon to USB-C dual role charger notification. This CL also adds system notification accent color to the notification. The icon and the accent color are effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: I94c4e7f946d19932e2d965ac86d18407cf9d110c Reviewed-on: https://chromium-review.googlesource.com/663106 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#501862} [modify] https://crrev.com/6071701f1276591080573f7b11617dd1177e159f/ash/resources/vector_icons/BUILD.gn [add] https://crrev.com/6071701f1276591080573f7b11617dd1177e159f/ash/resources/vector_icons/notification_charging_usb_c.icon [modify] https://crrev.com/6071701f1276591080573f7b11617dd1177e159f/ash/system/power/dual_role_notification.cc
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dec9e8099a64e6fc63e62d9a84c634ebe2b09763 commit dec9e8099a64e6fc63e62d9a84c634ebe2b09763 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Sep 14 05:35:41 2017 Add material design icon to sign in error notification. This CL adds new material design icon to sign in error notification. This CL also changes the notification theme color based on UX review ( https://crbug.com/726241#c20 ). The icon and the accent color are effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: I1c560fe62a70878195b9e7e59b3425defacf6363 Reviewed-on: https://chromium-review.googlesource.com/662481 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#501876} [modify] https://crrev.com/dec9e8099a64e6fc63e62d9a84c634ebe2b09763/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/dec9e8099a64e6fc63e62d9a84c634ebe2b09763/chrome/app/vector_icons/notification_warning.icon [modify] https://crrev.com/dec9e8099a64e6fc63e62d9a84c634ebe2b09763/chrome/browser/signin/signin_error_notifier_ash.cc
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7eeb0ed07076200aadff72ddb9bdba75700cbc3b commit 7eeb0ed07076200aadff72ddb9bdba75700cbc3b Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Sep 14 07:58:15 2017 Add material design icon to ARC migration notification. This CL adds new material design icon to ARC fs migration notification. This CL also adds system notification accent color to the notification. The icon and the accent color are effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: Ibc6ac22c44072892de8adbc2636dae08a0397383 Reviewed-on: https://chromium-review.googlesource.com/666597 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#501896} [modify] https://crrev.com/7eeb0ed07076200aadff72ddb9bdba75700cbc3b/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0ff0ea2e313ac45fe6613f528a822254343baad commit a0ff0ea2e313ac45fe6613f528a822254343baad Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Sep 15 05:22:23 2017 Add new icon to supervised user notification. This CL adds new icon to supervised user notification. This CL also adds system notification accent color to the notification. The icon and the accent color are effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: Ia7b5adb96d6b9cd18ee7973003bc56f45e6381a0 Reviewed-on: https://chromium-review.googlesource.com/662998 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#502164} [modify] https://crrev.com/a0ff0ea2e313ac45fe6613f528a822254343baad/ash/resources/vector_icons/BUILD.gn [add] https://crrev.com/a0ff0ea2e313ac45fe6613f528a822254343baad/ash/resources/vector_icons/notification_supervised.icon [modify] https://crrev.com/a0ff0ea2e313ac45fe6613f528a822254343baad/ash/system/supervised/tray_supervised_user.cc
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/672fd5cd07981bc528210e1368b6884f2cb9bf96 commit 672fd5cd07981bc528210e1368b6884f2cb9bf96 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Sep 15 05:33:22 2017 Add material design icon to ARC initial notification. This CL adds new material design icon to ARC notification. This CL also removes notification buttons on initial notification based on UX review ( https://crbug.com/726241#c20 ). The icon and the accent color are effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: Id617ad8fa8ab42f5494cf53fd27100397a09ceee Reviewed-on: https://chromium-review.googlesource.com/662837 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#502165} [modify] https://crrev.com/672fd5cd07981bc528210e1368b6884f2cb9bf96/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/672fd5cd07981bc528210e1368b6884f2cb9bf96/chrome/app/vector_icons/notification_play_prism.icon [modify] https://crrev.com/672fd5cd07981bc528210e1368b6884f2cb9bf96/chrome/browser/chromeos/arc/arc_auth_notification.cc
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4973f22fab1f3fc70b6cf56979f99da82c04e744 commit 4973f22fab1f3fc70b6cf56979f99da82c04e744 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Sep 19 05:33:45 2017 Add material design icon to AD sign in error notification. This change is equivalent change of https://crrev.com/c/662481 for Active Directory login. This CL adds new material design icon to AD sign in error notification. This CL also changes the notification theme color based on UX review ( https://crbug.com/726241#c20 ). The icon and the accent color are effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: Ifc32134967e1ecd1b4adc5fafd602c055dbcb089 Reviewed-on: https://chromium-review.googlesource.com/666955 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#502785} [modify] https://crrev.com/4973f22fab1f3fc70b6cf56979f99da82c04e744/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f1956ac7af4b3c061e93765788c536e1d7174d0 commit 2f1956ac7af4b3c061e93765788c536e1d7174d0 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Sep 19 08:11:44 2017 Add material design icon to mobile data notifications. This CL adds new material design icon to mobile data notifications. This CL also adds title "Mobile Data" to the notification. The icon is effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: Ia71759dbbe44b1472721c784bb4e1c59b9a7df53 Reviewed-on: https://chromium-review.googlesource.com/666399 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#502798} [modify] https://crrev.com/2f1956ac7af4b3c061e93765788c536e1d7174d0/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/2f1956ac7af4b3c061e93765788c536e1d7174d0/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/2f1956ac7af4b3c061e93765788c536e1d7174d0/chrome/app/vector_icons/notification_mobile_data.icon [modify] https://crrev.com/2f1956ac7af4b3c061e93765788c536e1d7174d0/chrome/browser/chromeos/status/data_promo_notification.cc
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95206950496326c04b839daa73f9f234d159d829 commit 95206950496326c04b839daa73f9f234d159d829 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Sep 20 01:22:17 2017 Add material design icon to CUPS notifications. This CL adds new material design icon to CUPS notifications. The icon is effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: I4e2cfccc9e2909933b9cf62b1355d87c651fa33b Reviewed-on: https://chromium-review.googlesource.com/666345 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#503016} [modify] https://crrev.com/95206950496326c04b839daa73f9f234d159d829/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/95206950496326c04b839daa73f9f234d159d829/chrome/app/vector_icons/notification_printing.icon [add] https://crrev.com/95206950496326c04b839daa73f9f234d159d829/chrome/app/vector_icons/notification_printing_done.icon [add] https://crrev.com/95206950496326c04b839daa73f9f234d159d829/chrome/app/vector_icons/notification_printing_warning.icon [modify] https://crrev.com/95206950496326c04b839daa73f9f234d159d829/chrome/browser/chromeos/printing/cups_print_job_notification.cc
,
Sep 20 2017
Hey, I realized I wrongly exported 2x version of some of the assets in our asset repository. Some might have been 1x assets marked 2x and some might also be 2x assets without their 1x equivalent. Sorry about that. I re-exported the full list of assets in 1x AND 2x on our drive repo: https://drive.google.com/drive/folders/0B6x6iYCtKinEQTEwc1l4QkxiRXM?usp=sharing Assets involved: ic_notification_installed ic_notification_warning ic_notification_google ic_notification_play_prism ic_notification_printing ic_notification_printing_warning ic_notification_printing_done ic_notification_charging_usb_c ic_notification_supervised ic_notification_data ic_notification_sms_sync could you make sure both 1x and 2x variant are implemented? Thanks!
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50562b2acf18bbc44c29eccfecd20074164db08a commit 50562b2acf18bbc44c29eccfecd20074164db08a Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Sep 21 03:41:22 2017 Add material design icon to ARC storage low notification. This CL adds new material design icon to ARC storage low notification. The icon and the accent color are effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: I967dc65dd549d86ffb10be5371653b8c2b9196fc Reviewed-on: https://chromium-review.googlesource.com/674645 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#503345} [modify] https://crrev.com/50562b2acf18bbc44c29eccfecd20074164db08a/chrome/browser/chromeos/arc/notification/arc_boot_error_notification.cc
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c752eae3b96d443fdedead70e8ed8c6beb76ba83 commit c752eae3b96d443fdedead70e8ed8c6beb76ba83 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Sep 22 06:12:55 2017 Apply system style to SMS notification. In new-style notification, system notification has different style from other notifications such as web notification. This CL applies the system style to SMS notification. * The context header has accent color. * New material design icon is added. * The context title "Chrome OS system" is added. The icon and the accent color are effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: I79391a5285e9734aafe6cc2b3876f28eacb35d79 Reviewed-on: https://chromium-review.googlesource.com/674644 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#503669} [modify] https://crrev.com/c752eae3b96d443fdedead70e8ed8c6beb76ba83/ash/resources/vector_icons/BUILD.gn [add] https://crrev.com/c752eae3b96d443fdedead70e8ed8c6beb76ba83/ash/resources/vector_icons/notification_sms_sync.1x.icon [add] https://crrev.com/c752eae3b96d443fdedead70e8ed8c6beb76ba83/ash/resources/vector_icons/notification_sms_sync.icon [modify] https://crrev.com/c752eae3b96d443fdedead70e8ed8c6beb76ba83/ash/system/network/sms_observer.cc
,
Sep 22 2017
In general, this is finished. For remaining tasks, I would like to do on another issue.
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9133e044cb9303b21fe03e988f362a06cce5cba commit b9133e044cb9303b21fe03e988f362a06cce5cba Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Oct 03 01:59:06 2017 Apply system style to display config error notification. In new-style notification, system notification has different style from other notifications such as web notification. This CL applies the system style to display configuration error notification. * The context header has accent color. * New material design icon is added. * The context title "Chrome OS system" is added. The icon and the accent color are effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG= 726241 Change-Id: Ifd92ba496d302f91484208aabd7b75c12779385f Reviewed-on: https://chromium-review.googlesource.com/691675 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#505921} [modify] https://crrev.com/b9133e044cb9303b21fe03e988f362a06cce5cba/ash/display/display_util.cc [modify] https://crrev.com/b9133e044cb9303b21fe03e988f362a06cce5cba/ash/resources/vector_icons/BUILD.gn [add] https://crrev.com/b9133e044cb9303b21fe03e988f362a06cce5cba/ash/resources/vector_icons/notification_monitor_warning.icon |
||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||
Comment 1 by yoshiki@chromium.org
, May 25 2017