New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726233 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

EC: npcx5: max_response size returned in EC_CMD_PROTOCOL_INFO is wrong.

Project Member Reported by aaboagye@chromium.org, May 25 2017

Issue description

gwendal@ recently made a change to flashrom which increased the max read and write size by interrogating the EC. Before, flashrom chose the minimum, but not no longer does. 

This however uncovered a bug in the npcx SHI driver. (see issue 725580) In my quick analysis, it seems that the EC reports that it supports a bigger response than it actually does. In chip/npcx/shi.c, we say that the max response is 160 + host response, but when queried via protocol info we say that it's 163 + host response. (a diff of 3 B which appears to be SHI_PROTO3_OVERHEAD)

I suspect max_response_size should be SHI_MAX_RESPONSE - SHI_PROTO3_OVERHEAD, instead of just SHI_MAX_RESPONSE.

I'm sheriff this week so I haven't had a chance to test this out and look super close at it, but I can get to it next week unless someone else wants to.
 
Labels: Proj-kevin Proj-bob
Owner: gwendal@chromium.org
Status: Verified (was: Unconfirmed)
This was fixed with https://chromium-review.googlesource.com/c/520585.

Sign in to add a comment