browser_side_navigation_webview_instrumentation_test_apk failing on chromium.android/Marshmallow 64 bit Tester |
||||
Issue descriptionbrowser_side_navigation_webview_instrumentation_test_apk failing on chromium.android/Marshmallow 64 bit Tester Builders failed on: - Marshmallow 64 bit Tester: https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FMarshmallow_64_bit_Tester%2F12444%2F%2B%2Frecipes%2Fsteps%2Fbrowser_side_navigation_webview_instrumentation_test_apk_on_Android%2F0%2Flogs%2Forg.chromium.android_webview.test.LoadDataWithBaseUrlTest_testloadDataWithBaseUrlCallsOnPageStarted%2F0 junit.framework.ComparisonFailure: expected:<[http://base.com/]> but was:<[data:text/html;charset=utf-8;base64,]> at org.chromium.android_webview.test.LoadDataWithBaseUrlTest.testloadDataWithBaseUrlCallsOnPageStarted(LoadDataWithBaseUrlTest.java:195) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879) Possible culprit: https://codereview.chromium.org/2901833002
,
May 25 2017
Sure, thanks for alerting us
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20e172c34b3685b8f8e6d212c866742ba729d007 commit 20e172c34b3685b8f8e6d212c866742ba729d007 Author: jam <jam@chromium.org> Date: Thu May 25 19:39:38 2017 Fix LoadDataWithBaseUrlTest.testloadDataWithBaseUrlCallsOnPageStarted after r474498. The problem is that NavigationControllerImpl::GetEntryWithUniqueID doesn't return the pending entry; GetPendingEntry has to be checked as well. BUG= 726230 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2903263002 Cr-Commit-Position: refs/heads/master@{#474758} [modify] https://crrev.com/20e172c34b3685b8f8e6d212c866742ba729d007/content/browser/frame_host/navigation_handle_impl.cc [modify] https://crrev.com/20e172c34b3685b8f8e6d212c866742ba729d007/content/browser/frame_host/navigation_handle_impl.h [modify] https://crrev.com/20e172c34b3685b8f8e6d212c866742ba729d007/content/browser/frame_host/navigation_request.cc
,
May 26 2017
,
May 26 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dgn@chromium.org
, May 25 2017