New issue
Advanced search Search tips

Issue 726214 link

Starred by 1 user
Status: Fixed
Owner:
tkent@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 725414



Sign in to add a comment

Cleanup of DOMTokenList implementation

Project Member Reported by tkent@chromium.org, May 25 2017 
* SpaceSplitString::kShouldFoldCase is unnecessary.
* Simplify functions
   remove ExceptionState from single add() and remove().
* Remove unnecessary virtual
* Confusing usage of setValue()
* Duplicated data members in DOMTokenList and RelList, DOMTokenList and ClassList
* ClassList should be in core/dom/
etc.
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b3f8731aaeecfa338c375b7c8a7f023fe14c6cd

commit 0b3f8731aaeecfa338c375b7c8a7f023fe14c6cd
Author: Kent Tamura <tkent@chromium.org>
Date: Thu May 25 06:23:48 2017

Remove SpaceSplitString::CaseFolding flag.

Existing callsite of kShouldFoldCase can be converted to
SpaceSplitSring(value.LowerASCII(), kShouldNotFoldCase). So the flag isn't
necessary.

BUG= 726214 

Change-Id: Ibc02f7cedd95695d1bcb00f4b4a2fef711ba1831
Reviewed-on: https://chromium-review.googlesource.com/514883
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474582}
[modify] https://crrev.com/0b3f8731aaeecfa338c375b7c8a7f023fe14c6cd/third_party/WebKit/Source/core/dom/ClassCollection.cpp
[modify] https://crrev.com/0b3f8731aaeecfa338c375b7c8a7f023fe14c6cd/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/0b3f8731aaeecfa338c375b7c8a7f023fe14c6cd/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/0b3f8731aaeecfa338c375b7c8a7f023fe14c6cd/third_party/WebKit/Source/core/dom/ElementData.h
[modify] https://crrev.com/0b3f8731aaeecfa338c375b7c8a7f023fe14c6cd/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp
[modify] https://crrev.com/0b3f8731aaeecfa338c375b7c8a7f023fe14c6cd/third_party/WebKit/Source/core/dom/SpaceSplitString.h
[modify] https://crrev.com/0b3f8731aaeecfa338c375b7c8a7f023fe14c6cd/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
[modify] https://crrev.com/0b3f8731aaeecfa338c375b7c8a7f023fe14c6cd/third_party/WebKit/Source/core/html/ClassList.cpp
[modify] https://crrev.com/0b3f8731aaeecfa338c375b7c8a7f023fe14c6cd/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/0b3f8731aaeecfa338c375b7c8a7f023fe14c6cd/third_party/WebKit/Source/core/html/RelList.cpp
Project Member

Comment 3 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/430c07f59270c1835fda3c17dbc173a3a12968a2

commit 430c07f59270c1835fda3c17dbc173a3a12968a2
Author: Kent Tamura <tkent@chromium.org>
Date: Fri May 26 08:14:12 2017

DOMTokenList: Clarify how to sync DOMTokenList value and the associated attribute value

* If the value is updated by a DOMTokenList, DOMTokenList::setValue(), or
DOMTokenListObserver::ValueWasSet(), is responsible for updating the associated
attribute value.

* If the associated attribute value is updated, Element::ParseAttribute() is
responsible to notify with DOMTokenList::DidUpdateAttributeValue().

* Element::ParseAttribute() is the place where we should write code logic in response
to attribute value changes.

This CL doesn't affect blink::ClassList because it handles SpaceSplitStrings in a
completely different way.

BUG= 726214 

Change-Id: Ic0ef717c8c4163fd00ad5771407551bb9a0d6457
Reviewed-on: https://chromium-review.googlesource.com/516684
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474963}
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/dom/DOMTokenList.h
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLIFrameElement.h
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLIFrameElementAllow.cpp
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLIFrameElementAllow.h
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLIFrameElementSandbox.cpp
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLIFrameElementSandbox.h
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLLinkElement.h
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLOutputElement.cpp
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/HTMLOutputElement.h
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/RelList.cpp
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/RelList.h
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.cpp
[modify] https://crrev.com/430c07f59270c1835fda3c17dbc173a3a12968a2/third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.h
Project Member

Comment 4 by bugdroid1@chromium.org, May 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76e4b0202a8ced88bb388353bfe60615967d1706

commit 76e4b0202a8ced88bb388353bfe60615967d1706
Author: Kent Tamura <tkent@chromium.org>
Date: Mon May 29 04:22:22 2017

DOMTokenList: Add a private function UpdateWithTokenSet().

It consolidates duplicated code.
Also, this CL fold AddToken() and RemoveToken() into their callsites.

BUG= 726214 

Change-Id: Iac60b69acc700b4575d9be4835c8682cc886203e
Reviewed-on: https://chromium-review.googlesource.com/516907
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475284}
[modify] https://crrev.com/76e4b0202a8ced88bb388353bfe60615967d1706/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/76e4b0202a8ced88bb388353bfe60615967d1706/third_party/WebKit/Source/core/dom/DOMTokenList.h
Project Member

Comment 5 by bugdroid1@chromium.org, May 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11378e7149c40c9f930127e2db7d2f1e19c32b23

commit 11378e7149c40c9f930127e2db7d2f1e19c32b23
Author: Kent Tamura <tkent@chromium.org>
Date: Mon May 29 06:52:00 2017

Simplify blink::ClassList.

This CL makes blink::ClassList simpler significantly by stop sharing
a SpaceSplitString with Element::ClassNames().

The sharing saved some cost to re-create a SpaceSplitString from a
|class| attribute value. However, it had downsides:

* We needed to have another SpaceSplitString for the quirks mode
  because Element::ClassNames() has lowercased strings for faster
  class name matching and element.classList doesn't have case-
  insensitive behavior.

* We needed to have yet another SpaceSplitString for mutation because
  Element::ClassAttributeChanged() needs to compare an old
  SpaceSplitString value and a new SpaceSplitString value.

This CL reduces code complexity caused by these two downsides.

The cost to re-create SpaceSplitString must not be large because
SpaceSplitString::SharedDataMap() keeps a cache entry created by
Element::ClassNames() creation.

BUG= 726214 

Change-Id: Ifa15ddb408c1eea15b3855ac89094189bb70d629
Reviewed-on: https://chromium-review.googlesource.com/516867
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475301}
[modify] https://crrev.com/11378e7149c40c9f930127e2db7d2f1e19c32b23/third_party/WebKit/Source/core/dom/ClassList.cpp
[modify] https://crrev.com/11378e7149c40c9f930127e2db7d2f1e19c32b23/third_party/WebKit/Source/core/dom/ClassList.h
[modify] https://crrev.com/11378e7149c40c9f930127e2db7d2f1e19c32b23/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/11378e7149c40c9f930127e2db7d2f1e19c32b23/third_party/WebKit/Source/core/dom/DOMTokenList.h
[modify] https://crrev.com/11378e7149c40c9f930127e2db7d2f1e19c32b23/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/11378e7149c40c9f930127e2db7d2f1e19c32b23/third_party/WebKit/Source/core/dom/ElementRareData.h
Project Member

Comment 6 by bugdroid1@chromium.org, May 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/505e4c3ab103688c1f354001fe25dfd13ae0c3cf

commit 505e4c3ab103688c1f354001fe25dfd13ae0c3cf
Author: Kent Tamura <tkent@chromium.org>
Date: Mon May 29 09:10:57 2017

DOMTokenList: Remove unnecessary overrides.

ClassList/RelList had to override length() and ContainsInternal() because they
had their own SpaceSplitString. Now ClassList/RelList use DOMTokenList::tokens_,
and don't need to override length() and ContainsInternal().

- This CL removes |virtual| from DOMTokenList functions without any overrides.

- Also, fold ContainsInternal() into contains().

BUG= 726214 

Change-Id: I6bf24a1ce4f973cb740f57d81b06afb7b74f533a
Reviewed-on: https://chromium-review.googlesource.com/517465
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475318}
[modify] https://crrev.com/505e4c3ab103688c1f354001fe25dfd13ae0c3cf/third_party/WebKit/Source/core/dom/ClassList.cpp
[modify] https://crrev.com/505e4c3ab103688c1f354001fe25dfd13ae0c3cf/third_party/WebKit/Source/core/dom/ClassList.h
[modify] https://crrev.com/505e4c3ab103688c1f354001fe25dfd13ae0c3cf/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/505e4c3ab103688c1f354001fe25dfd13ae0c3cf/third_party/WebKit/Source/core/dom/DOMTokenList.h
[modify] https://crrev.com/505e4c3ab103688c1f354001fe25dfd13ae0c3cf/third_party/WebKit/Source/core/html/RelList.cpp
[modify] https://crrev.com/505e4c3ab103688c1f354001fe25dfd13ae0c3cf/third_party/WebKit/Source/core/html/RelList.h
Project Member

Comment 7 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e1b04f408ded8274ae287ecb92e1e13472ed31d

commit 0e1b04f408ded8274ae287ecb92e1e13472ed31d
Author: Kent Tamura <tkent@chromium.org>
Date: Tue May 30 02:31:31 2017

Remove blink::DOMTokenListObserver.

This CL simplifies DOMTokenList implementation by removing
DOMTokenListObserver.

Any users of DOMTokenList had to do either:
 - Override setValue(), or
 - Implement DOMTokenListObserver::ValueWasSet()
in order to update an associated attribute value. This CL unifies the
code to update attribute values by adding Element and QualifiedName
members to DOMTokenList.

BUG= 726214 

Change-Id: I2acc18966ec198525f34c594e9817635d688a516
Reviewed-on: https://chromium-review.googlesource.com/517612
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475407}
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/dom/BUILD.gn
[delete] https://crrev.com/1233c48998fd21331cf5340d7cc07cd33cabf0b6/third_party/WebKit/Source/core/dom/ClassList.cpp
[delete] https://crrev.com/1233c48998fd21331cf5340d7cc07cd33cabf0b6/third_party/WebKit/Source/core/dom/ClassList.h
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/dom/DOMTokenList.h
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/dom/ElementRareData.h
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/HTMLIFrameElement.h
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/HTMLIFrameElementAllow.cpp
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/HTMLIFrameElementAllow.h
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/HTMLIFrameElementSandbox.cpp
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/HTMLIFrameElementSandbox.h
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/HTMLLinkElement.h
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/HTMLOutputElement.cpp
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/HTMLOutputElement.h
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/RelList.cpp
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/RelList.h
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.cpp
[modify] https://crrev.com/0e1b04f408ded8274ae287ecb92e1e13472ed31d/third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.h
Project Member

Comment 8 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eff1abada903178a950e2c2587f227356cff584d

commit eff1abada903178a950e2c2587f227356cff584d
Author: tkent <tkent@chromium.org>
Date: Tue May 30 06:27:10 2017

DOMTokenList: Fold AddInternal() and RemoveInternal() into toggle().

Only toggle() uses AddInternal() and RemoveInternal(). This CL folds them into
toggle(), and update toggle() code to follow the DOM specification.

This CL doesn't change any behavior.

BUG= 726214 

Review-Url: https://codereview.chromium.org/2909203003
Cr-Commit-Position: refs/heads/master@{#475440}

[modify] https://crrev.com/eff1abada903178a950e2c2587f227356cff584d/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/eff1abada903178a950e2c2587f227356cff584d/third_party/WebKit/Source/core/dom/DOMTokenList.h
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6211d340a0af0393a4cdc8232c990697d6f7f7b4

commit 6211d340a0af0393a4cdc8232c990697d6f7f7b4
Author: tkent <tkent@chromium.org>
Date: Thu Jun 01 02:09:53 2017

DOMTokenList: Rename add() and remove() with single string argument.

add() -> Add()
remove() -> Remove()

because they are not web-exposed. Also, this CL removes ExceptionState arguments
and adds ASSERT_NO_EXCEPTION in the functions.

This CL has no behavior changes.

BUG= 726214 

Review-Url: https://codereview.chromium.org/2910143002
Cr-Commit-Position: refs/heads/master@{#476153}

[modify] https://crrev.com/6211d340a0af0393a4cdc8232c990697d6f7f7b4/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/6211d340a0af0393a4cdc8232c990697d6f7f7b4/third_party/WebKit/Source/core/dom/DOMTokenList.h
[modify] https://crrev.com/6211d340a0af0393a4cdc8232c990697d6f7f7b4/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
[modify] https://crrev.com/6211d340a0af0393a4cdc8232c990697d6f7f7b4/third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af7e5066a0d2bf55b68cfa9e514e2f47f4254d62

commit af7e5066a0d2bf55b68cfa9e514e2f47f4254d62
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jun 02 09:16:09 2017

DOMTokenList: Some code cleanup

- Rename ValidateToken() to CheckTokenSyntax(), and make it static.
- Rename ValidateTokens() to CheckTokensSyntax(), and make it static.
  DOMTokenList has a different 'validate' concept. These functions were
  confusing.
  https://dom.spec.whatwg.org/#concept-domtokenlist-validation
- Make AddTokens() and RemoveTokens() private.

This CL has no behavior changes.

Bug:  726214 
Change-Id: Ia3e8cfbbc9815261e7c667dea458081e7d04fa72
Reviewed-on: https://chromium-review.googlesource.com/522502
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476607}
[modify] https://crrev.com/af7e5066a0d2bf55b68cfa9e514e2f47f4254d62/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/af7e5066a0d2bf55b68cfa9e514e2f47f4254d62/third_party/WebKit/Source/core/dom/DOMTokenList.h
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af7e5066a0d2bf55b68cfa9e514e2f47f4254d62

commit af7e5066a0d2bf55b68cfa9e514e2f47f4254d62
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jun 02 09:16:09 2017

DOMTokenList: Some code cleanup

- Rename ValidateToken() to CheckTokenSyntax(), and make it static.
- Rename ValidateTokens() to CheckTokensSyntax(), and make it static.
  DOMTokenList has a different 'validate' concept. These functions were
  confusing.
  https://dom.spec.whatwg.org/#concept-domtokenlist-validation
- Make AddTokens() and RemoveTokens() private.

This CL has no behavior changes.

Bug:  726214 
Change-Id: Ia3e8cfbbc9815261e7c667dea458081e7d04fa72
Reviewed-on: https://chromium-review.googlesource.com/522502
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476607}
[modify] https://crrev.com/af7e5066a0d2bf55b68cfa9e514e2f47f4254d62/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/af7e5066a0d2bf55b68cfa9e514e2f47f4254d62/third_party/WebKit/Source/core/dom/DOMTokenList.h
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddd382eaab6e5356e5e4f82974c7f8fb3cdc14ca

commit ddd382eaab6e5356e5e4f82974c7f8fb3cdc14ca
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Jun 05 04:53:53 2017

Rename blink::DOMTokenList::Tokens to TokenSet.

We call it "token set" in the DOM specification.
https://dom.spec.whatwg.org/#domtokenlist
> A DOMTokenList object has an associated token set (a set), which is
> initially empty.

Also,
  tokens_ -> token_set_
  SerializeSet() -> SerializeTokenSet()

Bug:  726214 
Change-Id: I7b77d40b6b6e952310fb8180c2750b3ddb70c5b3
Reviewed-on: https://chromium-review.googlesource.com/523205
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476941}
[modify] https://crrev.com/ddd382eaab6e5356e5e4f82974c7f8fb3cdc14ca/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/ddd382eaab6e5356e5e4f82974c7f8fb3cdc14ca/third_party/WebKit/Source/core/dom/DOMTokenList.h
[modify] https://crrev.com/ddd382eaab6e5356e5e4f82974c7f8fb3cdc14ca/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
[modify] https://crrev.com/ddd382eaab6e5356e5e4f82974c7f8fb3cdc14ca/third_party/WebKit/Source/core/html/HTMLIFrameElementAllow.cpp
[modify] https://crrev.com/ddd382eaab6e5356e5e4f82974c7f8fb3cdc14ca/third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.cpp

Comment 13 by tkent@chromium.org, Jun 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment