New issue
Advanced search Search tips

Issue 726203 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

camera_V4L2: add a control file to run all test cases for external cameras

Project Member Reported by wuchengli@chromium.org, May 25 2017

Issue description

There are two test cases that won't be run if the camera is not a built-in camera -- (1) Check 1600x1200 and 960x720 resolution (2) Constant frame rate. The test lab needs to run all test cases for all connected cameras. We need to add a control file for that.
 
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/564981/5
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e6f8fdfef1982375e1153b29d51eec5757ec4bfb

commit e6f8fdfef1982375e1153b29d51eec5757ec4bfb
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Fri Jul 21 13:32:03 2017

camera_V4L2: run all test cases when some cases failed

Go through all test cases to know the result of all cases.

BUG= chromium:726203 
TEST=test_that -b ${BOARD] ${IP} camera_V4L2

Change-Id: I3bcc832d713236dee0429d4f1b036783b22bbc51
Reviewed-on: https://chromium-review.googlesource.com/564980
Commit-Ready: Heng-ruey Hsu <henryhsu@google.com>
Tested-by: Heng-ruey Hsu <henryhsu@google.com>
Reviewed-by: Heng-ruey Hsu <henryhsu@google.com>

[modify] https://crrev.com/e6f8fdfef1982375e1153b29d51eec5757ec4bfb/client/site_tests/camera_V4L2/src/media_v4l2_test.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e6e80248b52a083adb2ca220c067d1e7c1a56581

commit e6e80248b52a083adb2ca220c067d1e7c1a56581
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Fri Jul 21 13:32:03 2017

camera_V4L2: Add a control to run all cases for external camera

Third party lab will use the control file to test external camera.
It should run all test cases without reading config file.

BUG= chromium:726203 
TEST=test_that -b ${BOARD} ${IP} camera_V4L2.external_camera

Change-Id: I178a6c00c1594a2b579a224fed75e79284880b7b
Reviewed-on: https://chromium-review.googlesource.com/564981
Commit-Ready: Heng-ruey Hsu <henryhsu@google.com>
Tested-by: Heng-ruey Hsu <henryhsu@google.com>
Reviewed-by: Heng-ruey Hsu <henryhsu@google.com>

[modify] https://crrev.com/e6e80248b52a083adb2ca220c067d1e7c1a56581/client/site_tests/camera_V4L2/src/media_v4l2_unittest.cc
[modify] https://crrev.com/e6e80248b52a083adb2ca220c067d1e7c1a56581/client/site_tests/camera_V4L2/src/media_v4l2_test.cc
[modify] https://crrev.com/e6e80248b52a083adb2ca220c067d1e7c1a56581/client/site_tests/camera_V4L2/camera_V4L2.py
[modify] https://crrev.com/e6e80248b52a083adb2ca220c067d1e7c1a56581/client/site_tests/camera_V4L2/control.constant_framerate
[add] https://crrev.com/e6e80248b52a083adb2ca220c067d1e7c1a56581/client/site_tests/camera_V4L2/control.external_camera

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/23ee460027022b4ce24ec52f1733141167f8935d

commit 23ee460027022b4ce24ec52f1733141167f8935d
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Fri Jul 21 13:32:03 2017

camera_V4L2: Adjust constant frame rate margin to 1.5%

The margin is aligned to CTS test.
Noise reduction mode requests constant frame rate.

BUG= chromium:726203 
TEST=emerge-${BOARD} autotest-tests

Change-Id: I1ddd30faee75a99e42a37bd093a7ac258af224ab
Reviewed-on: https://chromium-review.googlesource.com/577433
Commit-Ready: Heng-ruey Hsu <henryhsu@google.com>
Tested-by: Heng-ruey Hsu <henryhsu@google.com>
Reviewed-by: Heng-ruey Hsu <henryhsu@google.com>

[modify] https://crrev.com/23ee460027022b4ce24ec52f1733141167f8935d/client/site_tests/camera_V4L2/src/media_v4l2_test.cc

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/92bab4f9da873f08a24de379379a5f191d7196d2

commit 92bab4f9da873f08a24de379379a5f191d7196d2
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Mon Aug 14 06:03:33 2017

camera_V4L2: Add usb-camera suite

Since the control file is used in moblab and moblab will change the user
interface, add the suite then user can run the test in new UI.

BUG= chromium:726203 
TEST=emerge-${BOARD} autotest-tests

Change-Id: I2290042f0d47204aae57a59a1bc61c92f4e27e41
Reviewed-on: https://chromium-review.googlesource.com/611700
Commit-Ready: Heng-ruey Hsu <henryhsu@chromium.org>
Tested-by: Heng-ruey Hsu <henryhsu@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[add] https://crrev.com/92bab4f9da873f08a24de379379a5f191d7196d2/test_suites/control.usb-camera
[modify] https://crrev.com/92bab4f9da873f08a24de379379a5f191d7196d2/client/site_tests/camera_V4L2/control.external_camera

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aab49340ad9feb83fabd63bb20c92e80b563d1a3

commit aab49340ad9feb83fabd63bb20c92e80b563d1a3
Author: Heng-Ruey Hsu <henryhsu@chromium.org>
Date: Wed Aug 16 11:03:24 2017

camera_V4L2: Remove bug template from usb-camera suite

The suite is not run in ChromeOS lab.
We don't need bug template.

BUG= chromium:726203 
TEST=emerge-${BOARD} autotest-tests

Change-Id: I174a37276ea1618a4abe5640e3af062d9b6ab12a
Reviewed-on: https://chromium-review.googlesource.com/615213
Commit-Ready: Heng-ruey Hsu <henryhsu@chromium.org>
Tested-by: Heng-ruey Hsu <henryhsu@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/aab49340ad9feb83fabd63bb20c92e80b563d1a3/test_suites/control.usb-camera

Sign in to add a comment