Symbolized.

Deleted: sym.txt 167 KB

sym.txt 167 KB View Download

This is a recent regression; 60.0.30xx didn't have this hang.

You are probably looking for a change made after 470766 (known good), but no later than 470771 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/4ae97f1e5eba0fcd23ad35a23100cace5e8e8660..f548f57a4ec26eabaec6e466ee668aa29834b6c2

Trent, in the bisect your CL stood out.

https://codereview.chromium.org/2852233002

Probably yours.

FYI M60 cuts tomorrow; you might need to revert this before the deadline.

There's some stuff on top of it. I'll prep a disable CL.

https://codereview.chromium.org/2898953006/

(need a base OWNER for https://codereview.chromium.org/2898953006/ ..)

Looking into the problem.. it's weird. It looks as though the popup menu's runloop simply doesn't exit. This is the one run at SelectItemAndRestoreAllMenuBits() in HIToolbox, so there's only assembly code to debug. Dismissing the menu without selecting anything will also hang.

I don't know why the one on the print dialog is special. Chrome's NPPopupButtonCell menus on Cocoa dialogs behave. The difference may be that this nested menu runloop is being run under a modal run loop:

   2420 -[NSPrintPanel runModalWithPrintInfo:]  (in AppKit) + 498  [0x7fff98846e55]
     2420 -[NSApplication runModalForWindow:]  (in AppKit) + 156  [0x7fff98450375]
       2420 __35-[NSApplication runModalForWindow:]_block_invoke  (in AppKit) + 126  [0x7fff986336fb]
         2420 -[NSApplication _doModalLoop:peek:]  (in AppKit) + 751  [0x7fff98452ae4]


Aand pulling that thread I've found another repro:
 - Trigger an NSAlert (e.g. chrome://apps/ right-click -> Remove from Chrome..)
 - right-click some text in the title to show a menu
 - click outside the menu to dismiss 

So yah, something about modal dialogs. Possibly we can override -[NSApplication runModalForWindow:] with a scoped class that temporarily disables spying on private runloop modes.

Or maybe there's some kind of "I'm nested" flag in MessagePumpMac that's triggering an odd flow, and we can unwedge this by running the show-modal-dialog loop outside of it (assuming that's a thing..).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08c4e3028cf0a15630a07874da6eec8694682ce4

commit 08c4e3028cf0a15630a07874da6eec8694682ce4
Author: tapted <tapted@chromium.org>
Date: Thu May 25 10:43:53 2017

Mac: Disable r470769. I.e., Don't pump chrome tasks in private message loop modes.

It interacts badly with NSMenus on the native print dialog.

To fix, we may need to use a scoping class that adds these modes only
for menus that Chrome runs. Defer that to m61.

BUG= 726200 ,  602914 , 640466
TEST=Click the "Print using system dialog..." link in Print Preview,
then select "Save as PDF" via the [PDF] button in the native print
dialog. Chrome shouldn't hang.

Review-Url: https://codereview.chromium.org/2898953006
Cr-Commit-Position: refs/heads/master@{#474621}

[modify] https://crrev.com/08c4e3028cf0a15630a07874da6eec8694682ce4/base/message_loop/message_pump_mac.mm

#c11 (r474621) is in m60 (r474934) so removing release block and setting target milestone.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24ab401b3662d052facf19a169f553ea9a6bf7e1

commit 24ab401b3662d052facf19a169f553ea9a6bf7e1
Author: Trent Apted <tapted@chromium.org>
Date: Wed Sep 20 11:34:22 2017

Re-enable listening on private runloop modes, for a whitelist.

r470769 started observing private AppKit run loop modes to keep
UI and web pages responsive while menus were fading out, but it
interacted badly with app-modal dialogs.

This re-enables r470769, but only in 3 places:
 - Web page context menus
 - Web page <select> menus
 - menus run from toolkit-views UI.

      pause briefly when either the <select> menu or the right-
      click context menu are fading out. (The main menubar and the
      Chrome app/wrench menu still cause a brief pause when dismissed).

Bug:  726200 ,  602914 , 640466, 652007
Test: https://jsfiddle.net/kvmy8q9d/5/ - the animation shouldn't
Change-Id: Idf769c1f830ccb3ddc67205acb9e86aac2ec0460
Reviewed-on: https://chromium-review.googlesource.com/647836
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503112}
[modify] https://crrev.com/24ab401b3662d052facf19a169f553ea9a6bf7e1/base/message_loop/message_pump_mac.h
[modify] https://crrev.com/24ab401b3662d052facf19a169f553ea9a6bf7e1/base/message_loop/message_pump_mac.mm
[modify] https://crrev.com/24ab401b3662d052facf19a169f553ea9a6bf7e1/base/message_loop/message_pump_mac_unittest.cc
[modify] https://crrev.com/24ab401b3662d052facf19a169f553ea9a6bf7e1/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm
[modify] https://crrev.com/24ab401b3662d052facf19a169f553ea9a6bf7e1/content/browser/renderer_host/webmenurunner_mac.mm
[modify] https://crrev.com/24ab401b3662d052facf19a169f553ea9a6bf7e1/ui/views/controls/menu/menu_runner_impl_cocoa.mm

This shouldn't come back, and hopefully we can expand it to more use-cases. E.g. the mainMenu -- https://jsfiddle.net/kvmy8q9d/5/ doesn't stutter in Safari when toying with the main menu (it does, however, freeze when any modal dialog like Print is shown though). Issue 640466 and it's blockers exist for follow-up.