Chrome Version: ToT
OS: Android

What steps will reproduce the problem?
git cl patch 2903193002
./components/cronet/tools/cr_cronet.py build-test -f UploadDataProvidersTest#testGzipCancel

What is the expected result?
test passes

What happens instead?
test crashes (if fixes from patched CL aren't included)

Internal bug b/38497959

I think there may be several leaks:

Possible leak #1:

JavaUrlRequest.cancel() calls mCallbackAsync.onCanceled() which calls closeResponseChannel() which reads mResponseChannel...but does so on the callee's thread rather than the SerializingExecutor...and mResponseChannel hasn't been set yet...but will be set later during the task posted by fireGetHeaders().

Possible leak #2:

JavaUrlRequest.cancel() sets mState to CANCELLED and then sets mCurrentUrlConnection to null.  However both of these actions could happen after the mState check for CANCELLED in the Runnable posted by fireOpenConnection(), but before the Runnable posted by fireOpenConnection() has set mCurrentUrlConnection, in which case mCurrentUrlConnection will be set but fireDisconnect() will not do take any action because mCurrentUrlConnection was null.  This is similar to "Possible leak #1" in taht mCurrentUrlConnection is accessed on different threads.

If the URL being fetched is served gzip encoded this triggers a strict mode violation deep inside OkHttp where a java.util.zip.Inflater is used, which is a java.io.Closeable Object:

StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
StrictMode: java.lang.Throwable: Explicit termination method 'end' not called
StrictMode: 	at dalvik.system.CloseGuard.open(CloseGuard.java:180)
StrictMode: 	at java.util.zip.Inflater.<init>(Inflater.java:104)
StrictMode: 	at com.android.okhttp.okio.GzipSource.<init>(GzipSource.java:62)
StrictMode: 	at com.android.okhttp.internal.http.HttpEngine.unzip(HttpEngine.java:645)
StrictMode: 	at com.android.okhttp.internal.http.HttpEngine.readResponse(HttpEngine.java:821)
StrictMode: 	at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:463)
StrictMode: 	at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:405)
StrictMode: 	at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getHeaders(HttpURLConnectionImpl.java:162)
StrictMode: 	at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getHeaderFieldKey(HttpURLConnectionImpl.java:214)
StrictMode: 	at org.chromium.net.impl.JavaUrlRequest$4.run(JavaUrlRequest.java:595)
StrictMode: 	at org.chromium.net.impl.JavaUrlRequest$8.run(JavaUrlRequest.java:711)
StrictMode: 	at org.chromium.net.impl.JavaUrlRequest$SeriaizingExecutor$1.run(JavaUrlRequest.java:150)
StrictMode: 	at org.chromium.net.impl.JavaUrlRequest$1$1.run(JavaUrlRequest.java:213)
StrictMode: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
StrictMode: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
StrictMode: 	at org.chromium.net.impl.JavaCronetEngine$1$1.run(JavaCronetEngine.java:58)
StrictMode: 	at java.lang.Thread.run(Thread.java:761)

After I attempted to fix "Possible leak #1" I ran into this crash which I believe is a symptom of "Possible leak #2":

StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
StrictMode: java.lang.Throwable: Explicit termination method 'close' not called
StrictMode: 	at dalvik.system.CloseGuard.open(CloseGuard.java:180)
StrictMode: 	at java.net.AbstractPlainSocketImpl.create(AbstractPlainSocketImpl.java:103)
StrictMode: 	at java.net.Socket.createImpl(Socket.java:470)
StrictMode: 	at java.net.Socket.getImpl(Socket.java:536)
StrictMode: 	at java.net.Socket.setSoTimeout(Socket.java:1127)
StrictMode: 	at com.android.okhttp.Connection.connectSocket(Connection.java:195)
StrictMode: 	at com.android.okhttp.Connection.connect(Connection.java:172)
StrictMode: 	at com.android.okhttp.Connection.connectAndSetOwner(Connection.java:367)
StrictMode: 	at com.android.okhttp.OkHttpClient$1.connectAndSetOwner(OkHttpClient.java:130)
StrictMode: 	at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:329)
StrictMode: 	at com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:246)
StrictMode: 	at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:457)
StrictMode: 	at com.android.okhttp.internal.huc.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:126)
StrictMode: 	at org.chromium.net.impl.JavaUrlRequest$7.run(JavaUrlRequest.java:696)
StrictMode: 	at org.chromium.net.impl.JavaUrlRequest$8.run(JavaUrlRequest.java:708)
StrictMode: 	at org.chromium.net.impl.JavaUrlRequest$SeriaizingExecutor$1.run(JavaUrlRequest.java:150)
StrictMode: 	at org.chromium.net.impl.JavaUrlRequest$1$1.run(JavaUrlRequest.java:213)
StrictMode: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
StrictMode: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
StrictMode: 	at org.chromium.net.impl.JavaCronetEngine$1$1.run(JavaCronetEngine.java:58)
StrictMode: 	at java.lang.Thread.run(Thread.java:761)