New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726173 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[MD Settings/History/Bookmarks] Make button sizing consistent

Project Member Reported by tsergeant@chromium.org, May 25 2017

Issue description

MD Settings applies a bunch of styles to <paper-button>, which make it appear slightly different to those in History/Bookmarks which just use default stylings.

We should move the styles to cr-shared-styles so that we're consistent between pages!
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/061c4fcc1f90b46813ff20a639bdfcfe790902db

commit 061c4fcc1f90b46813ff20a639bdfcfe790902db
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Thu May 25 05:21:01 2017

MD WebUI: Make action-buttons across all pages 36px high

This brings MD History and Bookmarks in line with the button height
from MD Settings.

Bug:  726173 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I138e9a82dd5410a478ed8ef9f5181610b4b16d9d
Reviewed-on: https://chromium-review.googlesource.com/514602
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474562}
[modify] https://crrev.com/061c4fcc1f90b46813ff20a639bdfcfe790902db/chrome/browser/resources/md_history/synced_device_manager.html
[modify] https://crrev.com/061c4fcc1f90b46813ff20a639bdfcfe790902db/ui/webui/resources/cr_elements/shared_style_css.html

Cc: tsergeant@chromium.org
Owner: calamity@chromium.org
This file now exists: https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/paper_button_style_css.html

The last thing to do in order to fix this bug is to import this shared style into MD Bookmarks/History (or maybe into cr-shared-styles?).
Status: Fixed (was: Started)

Sign in to add a comment