New issue
Advanced search Search tips

Issue 726168 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
dbeam@chromium.org
patricia...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[MD settings] clean up enum in site_settings_behavior

Project Member Reported by dschuyler@chromium.org, May 25 2017 
in https://codereview.chromium.org/2902313002/
follow-up on this request, "is there like a list or enum of potential sources somewhere we could use instead of duplicating these string literals?"

Comment 1 by dschuyler@chromium.org, Jun 7 2018

Owner: scottchen@chromium.org
Hi scottchen@, I never got to addressing this follow-up CL. Is this something you'd be up for addressing (or do you have a likely swe to pass it to)?

Comment 2 by dpa...@chromium.org, Jun 7 2018

Labels: M-70
Thanks for following up. Adding M-70 label for this. The WebUI team is focusing on M-69 MD Refresh work, so it is unlikely to this be addressed before that.

Comment 3 by scottchen@chromium.org, Jul 25

Owner: patricia...@chromium.org
Summary: [MD settings] clean up enum in site_settings_behavior (was: [MD settings] follow-up on CL)

Comment 4 by patricia...@chromium.org, Jul 26

Cc: patricia...@chromium.org
Owner: ----
Status: Available (was: Assigned)
I don't think I'm able to work on this, but I think the fix should probably be to:

- Add 'HostedApp' and 'platform_app' to settings.SiteSettingsSource in site_settings/constants.js (in lowercase, with dashes, to be consistent)
- Update the 'HostedApp' string in site_settings_helper.cc
- Convert 'platform_app' to 'platform-app' in the C++ (probably somewhere in site_settings_helper.cc also). Alternatively, just merge the 'hosted-app' and 'platform-app' into one SiteSettingSource - users probably don't care about the difference between these two so there isn't any need to distinguish them as separate things in the site settings UI.
►

Sign in to add a comment