New issue
Advanced search Search tips

Issue 726162 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Migrate all components to use DefaultComponentInstaller

Project Member Reported by waff...@chromium.org, May 25 2017

Issue description

...namely CRL Set and PNaCl. (Can maybe get away with leaving RecoveryComponent, since it will be replaced by ImprovedRecoveryComponent soon.)

The benefits are transparent diffs for everyone (DCI writes fingerprint file) and uniform handling of install processes / temp file cleanup.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca707ada9f4ef0cee5abb2c6c16fb1f1b2b3334c

commit ca707ada9f4ef0cee5abb2c6c16fb1f1b2b3334c
Author: Joshua Pawlicki <waffles@google.com>
Date: Thu Sep 21 21:08:03 2017

Refactor Pnacl to use DCI.
This is the first step to standardize all installers on DCI.

Bug:  726162 
Change-Id: I35a114dd784abb893855c214bd0c5e05d99e65b7
Reviewed-on: https://chromium-review.googlesource.com/627237
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503561}
[modify] https://crrev.com/ca707ada9f4ef0cee5abb2c6c16fb1f1b2b3334c/chrome/browser/browser_process.h
[modify] https://crrev.com/ca707ada9f4ef0cee5abb2c6c16fb1f1b2b3334c/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/ca707ada9f4ef0cee5abb2c6c16fb1f1b2b3334c/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/ca707ada9f4ef0cee5abb2c6c16fb1f1b2b3334c/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/ca707ada9f4ef0cee5abb2c6c16fb1f1b2b3334c/chrome/browser/component_updater/pnacl_component_installer.cc
[modify] https://crrev.com/ca707ada9f4ef0cee5abb2c6c16fb1f1b2b3334c/chrome/browser/component_updater/pnacl_component_installer.h
[modify] https://crrev.com/ca707ada9f4ef0cee5abb2c6c16fb1f1b2b3334c/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/ca707ada9f4ef0cee5abb2c6c16fb1f1b2b3334c/chrome/test/base/testing_browser_process.h

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50e70b3e4721d321c2e369bd82993e95a9dd91eb

commit 50e70b3e4721d321c2e369bd82993e95a9dd91eb
Author: Joshua Pawlicki <waffles@google.com>
Date: Fri Sep 22 15:48:08 2017

Fix IO-not-allowed assert.

Bug:  726162 
Change-Id: I6b534e20b4fec99d7cd83a3e2fd153fa6448892a
Reviewed-on: https://chromium-review.googlesource.com/678040
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503746}
[modify] https://crrev.com/50e70b3e4721d321c2e369bd82993e95a9dd91eb/chrome/browser/component_updater/pnacl_component_installer.cc

Comment 3 by siggi@chromium.org, Sep 22 2017

 Issue 767889  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04ce6e42b3642e0fecb148cb32e4de0aad05e196

commit 04ce6e42b3642e0fecb148cb32e4de0aad05e196
Author: Joshua Pawlicki <waffles@google.com>
Date: Mon Oct 16 21:05:30 2017

Refactor CRLSetFetcher to use ComponentInstaller interface.

Because ComponentInstaller supports transparent differential updates,
support for CRLSet's custom differential update solution is removed.

Additionally, CRLSet will now use the task scheduler API, which allows
us to share one implementation between ios and Chrome browser.

Bug:  726162 
Change-Id: I919b1e5bcd138cb396a21fd2ce1a7b773fbd84bd
Reviewed-on: https://chromium-review.googlesource.com/709335
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509166}
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/chrome/browser/BUILD.gn
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/chrome/browser/browser_process.h
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/chrome/browser/chromeos/login/session/user_session_manager.cc
[delete] https://crrev.com/d2dae267b2233725003f2bf9eea96c2ecc7ac687/chrome/browser/net/crl_set_fetcher.cc
[delete] https://crrev.com/d2dae267b2233725003f2bf9eea96c2ecc7ac687/chrome/browser/net/crl_set_fetcher.h
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/chrome/test/base/testing_browser_process.h
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/components/component_updater/BUILD.gn
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/components/component_updater/DEPS
[add] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/components/component_updater/crl_set_component_installer.cc
[add] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/components/component_updater/crl_set_component_installer.h
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/ios/chrome/browser/application_context.h
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/ios/chrome/browser/application_context_impl.cc
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/ios/chrome/browser/application_context_impl.h
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/ios/chrome/browser/net/BUILD.gn
[delete] https://crrev.com/d2dae267b2233725003f2bf9eea96c2ecc7ac687/ios/chrome/browser/net/crl_set_fetcher.cc
[delete] https://crrev.com/d2dae267b2233725003f2bf9eea96c2ecc7ac687/ios/chrome/browser/net/crl_set_fetcher.h
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/ios/chrome/test/testing_application_context.h
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/ios/chrome/test/testing_application_context.mm
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/net/ssl/ssl_config_service.cc
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/net/ssl/ssl_config_service.h
[modify] https://crrev.com/04ce6e42b3642e0fecb148cb32e4de0aad05e196/net/url_request/url_request_unittest.cc

Status: Fixed (was: Assigned)
This was fixed long ago.

Sign in to add a comment