Implement TypedURLSyncBridge
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2ae2ba24bb3d8a1a1324bde1252dd543e2bf708 commit c2ae2ba24bb3d8a1a1324bde1252dd543e2bf708 Author: gangwu <gangwu@chromium.org> Date: Mon Jun 05 20:51:58 2017 Implement GetAllData and GetStorageKey. Also add TypedURLSyncBridge to be an observer of HistoryBackend. Change storageKey using big endian, since user event is using big endian, and it is better to unify our number style. BUG= 726158 The following 4 functions are ported from TypedUrlSyncableService. GetErrorPercentage() WriteToTypedUrlSpecifics() ClearErrorStats() FixupURLAndGetVisits() Review-Url: https://codereview.chromium.org/2901093009 Cr-Commit-Position: refs/heads/master@{#477079} [modify] https://crrev.com/c2ae2ba24bb3d8a1a1324bde1252dd543e2bf708/components/history/core/browser/BUILD.gn [modify] https://crrev.com/c2ae2ba24bb3d8a1a1324bde1252dd543e2bf708/components/history/core/browser/history_backend.cc [modify] https://crrev.com/c2ae2ba24bb3d8a1a1324bde1252dd543e2bf708/components/history/core/browser/history_backend.h [modify] https://crrev.com/c2ae2ba24bb3d8a1a1324bde1252dd543e2bf708/components/history/core/browser/typed_url_sync_bridge.cc [modify] https://crrev.com/c2ae2ba24bb3d8a1a1324bde1252dd543e2bf708/components/history/core/browser/typed_url_sync_bridge.h [add] https://crrev.com/c2ae2ba24bb3d8a1a1324bde1252dd543e2bf708/components/history/core/browser/typed_url_sync_bridge_unittest.cc [modify] https://crrev.com/c2ae2ba24bb3d8a1a1324bde1252dd543e2bf708/components/history/core/browser/typed_url_sync_metadata_database.cc [modify] https://crrev.com/c2ae2ba24bb3d8a1a1324bde1252dd543e2bf708/components/history/core/browser/typed_url_sync_metadata_database_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f12ab8632a25615e2d9e8e2593c74c46b6b1f2b commit 7f12ab8632a25615e2d9e8e2593c74c46b6b1f2b Author: gangwu <gangwu@chromium.org> Date: Wed Jul 26 23:05:20 2017 [USS] Implement ApplySyncChanges and OnURLVisited/Modified/Deleted. For deletion purpose, exposing function |GetURLRow| in URLDatabase to HistoryBackend, so TypedURLSyncBridge can look up URLRow by URLID. BUG= 726158 Renaming a function. UpdateUrlFromServer->MergeURLWithSync The following 4 functions are ported from TypedUrlSyncableService. DiffVisits ShouldSyncVisit UpdateFromSyncDB->UpdateFromSync CreateOrUpdateSyncNode->UpdateSyncFromLocal Review-Url: https://codereview.chromium.org/2961723003 Cr-Commit-Position: refs/heads/master@{#489789} [modify] https://crrev.com/7f12ab8632a25615e2d9e8e2593c74c46b6b1f2b/components/history/core/browser/history_backend.cc [modify] https://crrev.com/7f12ab8632a25615e2d9e8e2593c74c46b6b1f2b/components/history/core/browser/history_backend.h [modify] https://crrev.com/7f12ab8632a25615e2d9e8e2593c74c46b6b1f2b/components/history/core/browser/typed_url_sync_bridge.cc [modify] https://crrev.com/7f12ab8632a25615e2d9e8e2593c74c46b6b1f2b/components/history/core/browser/typed_url_sync_bridge.h [modify] https://crrev.com/7f12ab8632a25615e2d9e8e2593c74c46b6b1f2b/components/history/core/browser/typed_url_sync_bridge_unittest.cc [modify] https://crrev.com/7f12ab8632a25615e2d9e8e2593c74c46b6b1f2b/components/history/core/browser/typed_url_sync_metadata_database.cc [modify] https://crrev.com/7f12ab8632a25615e2d9e8e2593c74c46b6b1f2b/components/history/core/browser/typed_url_sync_metadata_database.h [modify] https://crrev.com/7f12ab8632a25615e2d9e8e2593c74c46b6b1f2b/components/sync/model/recording_model_type_change_processor.cc [modify] https://crrev.com/7f12ab8632a25615e2d9e8e2593c74c46b6b1f2b/components/sync/model/recording_model_type_change_processor.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21106965afc8e12bab1a1ad4646da1502dc4dcf5 commit 21106965afc8e12bab1a1ad4646da1502dc4dcf5 Author: Gang Wu <gangwu@chromium.org> Date: Wed Oct 11 05:58:50 2017 [USS] Implement controller for typed url This is the final CL for typed url implementation, this CL implement controller for typed url, and bridge Instantiation. Bug: 726158 Change-Id: Iddb32b91b2907c3986e613dec866abab100cb5ba Reviewed-on: https://chromium-review.googlesource.com/669719 Reviewed-by: Brett Wilson <brettw@chromium.org> Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#507906} [modify] https://crrev.com/21106965afc8e12bab1a1ad4646da1502dc4dcf5/chrome/browser/sync/chrome_sync_client.cc [modify] https://crrev.com/21106965afc8e12bab1a1ad4646da1502dc4dcf5/components/browser_sync/profile_sync_components_factory_impl.cc [modify] https://crrev.com/21106965afc8e12bab1a1ad4646da1502dc4dcf5/components/history/core/browser/BUILD.gn [modify] https://crrev.com/21106965afc8e12bab1a1ad4646da1502dc4dcf5/components/history/core/browser/history_backend.cc [add] https://crrev.com/21106965afc8e12bab1a1ad4646da1502dc4dcf5/components/history/core/browser/typed_url_model_type_controller.cc [add] https://crrev.com/21106965afc8e12bab1a1ad4646da1502dc4dcf5/components/history/core/browser/typed_url_model_type_controller.h [modify] https://crrev.com/21106965afc8e12bab1a1ad4646da1502dc4dcf5/components/history/core/browser/typed_url_sync_bridge.cc [modify] https://crrev.com/21106965afc8e12bab1a1ad4646da1502dc4dcf5/components/history/core/browser/typed_url_sync_bridge.h [modify] https://crrev.com/21106965afc8e12bab1a1ad4646da1502dc4dcf5/components/sync/driver/model_type_controller.cc [modify] https://crrev.com/21106965afc8e12bab1a1ad4646da1502dc4dcf5/components/sync/driver/model_type_controller.h [modify] https://crrev.com/21106965afc8e12bab1a1ad4646da1502dc4dcf5/ios/chrome/browser/sync/ios_chrome_sync_client.mm
Comment 1 by bugdroid1@chromium.org
, Jun 5 2017