New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726155 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
In-Product-Help


Sign in to add a comment

Feature engagement tracker metrics

Project Member Reported by xingliu@chromium.org, May 24 2017

Issue description

Add metrics for feature engagement tracker.
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92cb438681b00aa996bdc0bac4187de2dac1ad68

commit 92cb438681b00aa996bdc0bac4187de2dac1ad68
Author: Xing Liu <xingliu@chromium.org>
Date: Tue May 30 23:34:51 2017

Metrics for feature engagement tracker.

This CL adds metrics for feature engagement tracker.

There are some user actions which are not const char literal, this is
probably not ok, so we probably can't use suffixes for user actions.

Bug:  726155 
Change-Id: Ieb0ca4cf5c49b9f2cd6d7eed5f6afe9fea4faa20
Reviewed-on: https://chromium-review.googlesource.com/514331
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475691}
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/BUILD.gn
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/availability_store.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/chrome_variations_configuration.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/chrome_variations_configuration.h
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/chrome_variations_configuration_unittest.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/condition_validator.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/condition_validator.h
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/condition_validator_unittest.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/configuration.h
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/editable_configuration.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/editable_configuration.h
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/feature_config_condition_validator.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/feature_config_condition_validator_unittest.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl_unittest.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/model_impl.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/once_condition_validator.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/once_condition_validator_unittest.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/persistent_store.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/persistent_store_unittest.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/single_invalid_configuration.cc
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/single_invalid_configuration.h
[add] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/stats.cc
[add] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/components/feature_engagement_tracker/internal/stats.h
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/tools/metrics/actions/actions.xml
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/92cb438681b00aa996bdc0bac4187de2dac1ad68/tools/metrics/histograms/histograms.xml

Labels: M-60 Merge-Request-60
Project Member

Comment 4 by sheriffbot@chromium.org, May 30 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, May 31 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b36844f6112ee001d289dda31a858122b23c3852

commit b36844f6112ee001d289dda31a858122b23c3852
Author: Xing Liu <xingliu@chromium.org>
Date: Wed May 31 00:07:57 2017

Metrics for feature engagement tracker.

This CL adds metrics for feature engagement tracker.

There are some user actions which are not const char literal, this is
probably not ok, so we probably can't use suffixes for user actions.

Bug:  726155 
Change-Id: Ieb0ca4cf5c49b9f2cd6d7eed5f6afe9fea4faa20
Reviewed-on: https://chromium-review.googlesource.com/514331
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#475691}
Review-Url: https://codereview.chromium.org/2911123003 .
Cr-Commit-Position: refs/branch-heads/3112@{#43}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/BUILD.gn
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/availability_store.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/chrome_variations_configuration.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/chrome_variations_configuration.h
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/chrome_variations_configuration_unittest.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/condition_validator.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/condition_validator.h
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/condition_validator_unittest.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/configuration.h
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/editable_configuration.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/editable_configuration.h
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/feature_config_condition_validator.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/feature_config_condition_validator_unittest.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl_unittest.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/model_impl.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/once_condition_validator.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/once_condition_validator_unittest.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/persistent_store.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/persistent_store_unittest.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/single_invalid_configuration.cc
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/single_invalid_configuration.h
[add] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/stats.cc
[add] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/components/feature_engagement_tracker/internal/stats.h
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/tools/metrics/actions/actions.xml
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b36844f6112ee001d289dda31a858122b23c3852/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Components: Internals>FeatureEngagementTracker

Sign in to add a comment