Progress bar theme color does not update appropriately |
||
Issue descriptionNavigating between themed pages often does not update the progress bar color in Chrome Home.
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/908718941dc1d7c20a7b8422e698a91c74369826 commit 908718941dc1d7c20a7b8422e698a91c74369826 Author: Matthew Jones <mdjones@chromium.org> Date: Thu May 25 01:07:09 2017 [Home] Fix progress bar theming This change overrides onPrimaryColor changed in BottomToolbarPhone to only update the progress bar's theme color and skip logic that would otherwise block the update. ToolbarManager has also been changed to cache the primary color locally due to some Chrome Home specific logic in the toolbar model. BUG= 726084 Change-Id: I12fb43852825a2b1847920ac12004fd39f90af0b Reviewed-on: https://chromium-review.googlesource.com/514482 Reviewed-by: Theresa Wellington <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#474507} [modify] https://crrev.com/908718941dc1d7c20a7b8422e698a91c74369826/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java [modify] https://crrev.com/908718941dc1d7c20a7b8422e698a91c74369826/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
,
May 25 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by k...@chromium.org
, May 24 2017