New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726084 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Progress bar theme color does not update appropriately

Project Member Reported by mdjones@chromium.org, May 24 2017

Issue description

Navigating between themed pages often does not update the progress bar color in Chrome Home.
 

Comment 1 by k...@chromium.org, May 24 2017

Labels: Hotlist-Chrome-Home
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/908718941dc1d7c20a7b8422e698a91c74369826

commit 908718941dc1d7c20a7b8422e698a91c74369826
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu May 25 01:07:09 2017

[Home] Fix progress bar theming

This change overrides onPrimaryColor changed in BottomToolbarPhone
to only update the progress bar's theme color and skip logic that
would otherwise block the update.

ToolbarManager has also been changed to cache the primary color
locally due to some Chrome Home specific logic in the toolbar model.

BUG= 726084 

Change-Id: I12fb43852825a2b1847920ac12004fd39f90af0b
Reviewed-on: https://chromium-review.googlesource.com/514482
Reviewed-by: Theresa Wellington <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474507}
[modify] https://crrev.com/908718941dc1d7c20a7b8422e698a91c74369826/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
[modify] https://crrev.com/908718941dc1d7c20a7b8422e698a91c74369826/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Status: Fixed (was: Assigned)

Sign in to add a comment