The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb19f7f0877982a0d5c326198eb3a67f366d4114

commit cb19f7f0877982a0d5c326198eb3a67f366d4114
Author: dmazzoni <dmazzoni@chromium.org>
Date: Fri May 26 08:25:06 2017

Fix automation API bounding boxes on high-dpi devices

This regressed in r460412 (https://codereview.chromium.org/2762373002)
when we switched from taking the frame-relative coordinates of each web
object and adding a frame offset, to always just walking up the whole
accessibility tree to find the global bounds of an object.

The reason that failed is because the coordinates we get from the web
have the scale factor applied, but coordinates we get from the desktop
do not. So we need to "unapply" the device scale factor just once,
at the point we walk from the web tree to the desktop tree.

This regressed once before last year. This time I figured out a way to add
a regression test for it.

BUG= 726081 

Review-Url: https://codereview.chromium.org/2911553002
Cr-Commit-Position: refs/heads/master@{#474967}

[modify] https://crrev.com/cb19f7f0877982a0d5c326198eb3a67f366d4114/chrome/browser/extensions/api/automation/automation_apitest.cc
[modify] https://crrev.com/cb19f7f0877982a0d5c326198eb3a67f366d4114/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/cb19f7f0877982a0d5c326198eb3a67f366d4114/chrome/renderer/extensions/automation_internal_custom_bindings.h
[add] https://crrev.com/cb19f7f0877982a0d5c326198eb3a67f366d4114/chrome/test/data/extensions/api_test/automation/tests/location_scaled/buttons.html
[add] https://crrev.com/cb19f7f0877982a0d5c326198eb3a67f366d4114/chrome/test/data/extensions/api_test/automation/tests/location_scaled/location_scaled.js
[add] https://crrev.com/cb19f7f0877982a0d5c326198eb3a67f366d4114/chrome/test/data/extensions/api_test/automation/tests/location_scaled/manifest.json

Argh, this was supposed to be merged to M60!

Entirely my fault, I intended to request a merge since it landed just after the M60 branch point, but I forgot to.

I know it's super late for a merge. Here are some arguments in favor:

* It's had a long time to bake on M61 - no crashes found anywhere near that code
* Most of the affected files are tests (so this doesn't regress again!). The actual changes to chrome/renderer/extensions/automation_internal_custom_bindings.* are very small and safe.
* It only affects users running ChromeVox or Select to Speak. Users who don't have either of those enabled will never touch this code path.

Arguments against the merge:

* Only affects hi-dpi devices like the Pixel. We encounter that a lot more at Google, but most Chromebooks are unaffected.

This bug requires manual review: We are only 3 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

ok, let's merge as per justification in c#4

Merging now

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dff330a148976a09492505e6cd6ca603153a7e38

commit dff330a148976a09492505e6cd6ca603153a7e38
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon Jul 24 19:21:46 2017

Merge to M60: Fix automation API bounding boxes on high-dpi devices

This regressed in r460412 (https://codereview.chromium.org/2762373002)
when we switched from taking the frame-relative coordinates of each web
object and adding a frame offset, to always just walking up the whole
accessibility tree to find the global bounds of an object.

The reason that failed is because the coordinates we get from the web
have the scale factor applied, but coordinates we get from the desktop
do not. So we need to "unapply" the device scale factor just once,
at the point we walk from the web tree to the desktop tree.

This regressed once before last year. This time I figured out a way to add
a regression test for it.

BUG= 726081 

(cherry picked from commit cb19f7f0877982a0d5c326198eb3a67f366d4114)

Review-Url: https://codereview.chromium.org/2911553002
Cr-Original-Commit-Position: refs/heads/master@{#474967}
Change-Id: I84a30fdc6ce9789c9f289039ad1219bf5e7a2937
Reviewed-on: https://chromium-review.googlesource.com/583633
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#667}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/dff330a148976a09492505e6cd6ca603153a7e38/chrome/browser/extensions/api/automation/automation_apitest.cc
[modify] https://crrev.com/dff330a148976a09492505e6cd6ca603153a7e38/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/dff330a148976a09492505e6cd6ca603153a7e38/chrome/renderer/extensions/automation_internal_custom_bindings.h
[add] https://crrev.com/dff330a148976a09492505e6cd6ca603153a7e38/chrome/test/data/extensions/api_test/automation/tests/location_scaled/buttons.html
[add] https://crrev.com/dff330a148976a09492505e6cd6ca603153a7e38/chrome/test/data/extensions/api_test/automation/tests/location_scaled/location_scaled.js
[add] https://crrev.com/dff330a148976a09492505e6cd6ca603153a7e38/chrome/test/data/extensions/api_test/automation/tests/location_scaled/manifest.json

CLs are merged. Marking as fixed 

 Issue 745841  has been merged into this issue.

Chrome OS 9592.71.0, 60.0.3112.80