New issue
Advanced search Search tips

Issue 726078 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

rebaseline-cl prints "triggering jobs" message with no bots and then exits

Project Member Reported by qyears...@chromium.org, May 24 2017

Issue description

This is a bug added in https://codereview.chromium.org/2890373003;

When there are already jobs triggered for all bots, rebaseline-cl should not print "triggering jobs for...", and it should continue on with downloading baselines.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4e28d32f77ff5e9bcb20c8f7514bd296bcb2b6d

commit e4e28d32f77ff5e9bcb20c8f7514bd296bcb2b6d
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu May 25 20:42:25 2017

rebaseline-cl: continue on if there are no jobs to trigger

The purpose of this CL is to fix  http://crbug.com/726078 ,
which is a bug accidentally added in
https://codereview.chromium.org/2890373003 - this CL also
changes the unit tests to set --trigger-jobs to be True by
default in most tests (which is better since it's True by
default if not explicitly specified).

Bug:  726078 
Change-Id: I48d68e9700a4f348059915ce359b4903ea80427b
Reviewed-on: https://chromium-review.googlesource.com/514327
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474790}
[modify] https://crrev.com/e4e28d32f77ff5e9bcb20c8f7514bd296bcb2b6d/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
[modify] https://crrev.com/e4e28d32f77ff5e9bcb20c8f7514bd296bcb2b6d/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Status: Fixed (was: Assigned)

Sign in to add a comment