Improve cbuildbot_launch metrics |
||||
Issue descriptionWe'd like to have a 'presence' metric to know how many builds are currently in progress. We'd also like to add fields that show the current build config, trybot status and/or debug status. Finally, if we can cleanup command line parsing so that it's safe to do before anything else (IE: split apart from cbuildbot parsing), then populate all of these fields before emitting any metrics.
,
Jun 2 2017
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/cd92f90d69378a369109851cd226128fce341aba commit cd92f90d69378a369109851cd226128fce341aba Author: Don Garrett <dgarrett@google.com> Date: Wed Jun 14 04:23:57 2017 metrics: Add a Presence context manager. This context manager is set to True upon entry, and False upon exit. This should make it possible to see how many of a given thing are happening at any given time. I intend to use it for the cbuildbot_launcher to count the number of active builds. BUG= chromium:726065 TEST=run_tests Change-Id: I4a394e67376e58f711f5d93d0484d1a236196000 Reviewed-on: https://chromium-review.googlesource.com/518508 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Paul Hobbs <phobbs@google.com> [modify] https://crrev.com/cd92f90d69378a369109851cd226128fce341aba/lib/metrics_unittest.py [modify] https://crrev.com/cd92f90d69378a369109851cd226128fce341aba/lib/metrics.py
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d1d90ddf342998b402eb69c77a964506db7d252e commit d1d90ddf342998b402eb69c77a964506db7d252e Author: Don Garrett <dgarrett@google.com> Date: Wed Jun 14 23:26:13 2017 cbuildbot_launch: Generate improved fields for all metrics. With this, all launcher metrics have the fields: branch_name: String with branch name. build_config: String with build config being built. tryjob: Boolean flag showing if this is a tryjob. I audited the cbuildbot command line parsing code, and found no side effects other than calling 'Die' in a variety of cases. So... I simplified main to just parse command line options before creating the metrics fields instead of updating them on the fly. While touching commandline parsing, I redid the way we filer command line options before invoking cbuildbot to be slightly less coupled to cbuildbot's internals. BUG= chromium:726065 TEST=Unittest + localbuilds. Change-Id: I4c7da7917acfd60ac5bd69285de0d25addad0e6a Reviewed-on: https://chromium-review.googlesource.com/535054 Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/d1d90ddf342998b402eb69c77a964506db7d252e/scripts/cbuildbot_launch.py [modify] https://crrev.com/d1d90ddf342998b402eb69c77a964506db7d252e/scripts/cbuildbot_launch_unittest.py
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/45e7741daec227815fd83614eeaef3dd386aebb5 commit 45e7741daec227815fd83614eeaef3dd386aebb5 Author: Don Garrett <dgarrett@google.com> Date: Thu Jun 15 19:27:28 2017 cbuildbot_launch: Add a presence metric for builds. Add an additional presence metric to show what builds are in progress. BUG= chromium:726065 TEST=unittests + local build. Change-Id: Ie92b2c220f37e8c0196dfcf60bb4ac09628c443d Reviewed-on: https://chromium-review.googlesource.com/536353 Tested-by: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> Reviewed-by: Paul Hobbs <phobbs@google.com> [modify] https://crrev.com/45e7741daec227815fd83614eeaef3dd386aebb5/scripts/cbuildbot_launch.py
,
Jun 15 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dgarr...@chromium.org
, May 31 2017