New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726062 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

MD settings don't allow you to re-mask a Google card

Project Member Reported by zkoch@chromium.org, May 24 2017

Issue description

Chrome Version: 58.0.3029.110 (Official Build) (64-bit)
OS: OS X

What steps will reproduce the problem?
(1) Be signed into Chrome
(2) Have a card in your google account (payments.google.com)
(3) Have unmasked a card (e.g. go to https://rsolomakhin.github.io/autofill/ to use the card, type in your CVC, and leave the box checked to save copy locally)

What is the expected result?

In chrome://settings/autofill you should be able to "Clear copy" of the saved card

What happens instead?

The "Clear copy" option has been removed in material settings

 

Comment 1 by csashi@google.com, May 24 2017

Cc: vasi...@chromium.org
Owner: jsaul@google.com
Status: Assigned (was: Untriaged)

Comment 2 by jsaul@google.com, May 24 2017

Zach: This works fine for me on Mac.  I do notice that "Copied to Chrome [Clear copy]" only appears if you hover over the entry, just like the other [Edit] buttons.  Is this perhaps the cause behind your bug?

Comment 3 by zkoch@chromium.org, May 24 2017

Are you at chrome://md-settings?

Comment 4 by jsaul@google.com, May 24 2017

Ah, nope, I was at chrome://settings/autofill because that's what the bug referenced. :)

I see the problem now, thanks.

Comment 5 by csashi@google.com, May 26 2017

We could disable "OfferStoreUnmaskedWalletCards" feature flag until this bug is fixed, or if this bug is not fixed in time.

https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_experiments.cc?l=172&rcl=88677427eb90210e1f60202602a3dc1eace69da5
Components: UI>Settings Privacy
Labels: -Pri-3 M-59 Pri-1
Bumping up the priority because it's a privacy issue.

Comment 7 by csashi@google.com, May 26 2017

FWIW, there is a workaround for the missing "Clear Copy". If the user signs out of Chrome we clear these copies.

Comment 8 by zkoch@chromium.org, May 26 2017

I think easiest way to solve this would just be to add the three dot menu to all cards, and on the ones from Google Payments add two options:

* Clear copy (if there is a locally saved copy)
* Edit (which takes you to payments.google.com)
Cc: jsaul@google.com dbeam@chromium.org
Owner: hcarmona@chromium.org
Status: Started (was: Assigned)
Taking this since it's in 59
Labels: -Pri-1 ReleaseBlock-Stable Pri-0
I'm uploading CL soon. Upping priority in case we need to take action. This seems serious.

Comment 11 by jsaul@google.com, Jun 2 2017

Thanks Hector; much appreciated.
http://crrev.com/2919873003 CL under review now
Cc: szhangcs@google.com
Thanks Hector for taking this issue.
Cc: groby@chromium.org
Labels: -Pri-0 Pri-1
P0 -> P1
We have 2 workarounds:
  1. Log out of Chrome + Log back in
  2. Go to web and remove card, this will remove from Chrome also
Labels: -ReleaseBlock-Stable -M-59 M-60
Changing to M-60 as per email conversation
Labels: Merge-Request-60
Requesting merge to M60.

Fix is landed in Canary, verified it's working on Version 61.0.3119.0 (Official Build) canary (64-bit)
Project Member

Comment 19 by sheriffbot@chromium.org, Jun 5 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 5 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ccb5bb42f0f5f969cb057175cc291fb3d594a21

commit 7ccb5bb42f0f5f969cb057175cc291fb3d594a21
Author: Hector Carmona <hcarmona@chromium.org>
Date: Mon Jun 05 23:50:27 2017

Allow clearing local CC details

R=dschuyler@chromium.org,dpapad@chromium.org
BUG= 726062 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2919873003
Cr-Original-Commit-Position: refs/heads/master@{#476817}
Review-Url: https://codereview.chromium.org/2920223005 .
Cr-Commit-Position: refs/branch-heads/3112@{#172}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/7ccb5bb42f0f5f969cb057175cc291fb3d594a21/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/7ccb5bb42f0f5f969cb057175cc291fb3d594a21/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js

Status: Fixed (was: Started)
Labels: Needs-Feedback
Tested this issue on Windows 10, Ubuntu 14.04 and Mac 10.12.4 with chrome #60.0.3112.20  
as per steps mentioned in the comment #0.

Observed that in Windows and Mac, while entering the CVV the check box was selected to save the copy on local device and after saving it, i was able to delete the copy from "chrome://settings/autofill", whereas in Ubuntu while entering the CVV the check box was not available to save copy on local device.

Attaching screen-cast for reference

hcarmona@ Could you please look into it and confirm this expected behavior of this issue.
Issue 726062.mp4
997 KB View Download
the Linux Screen-cast
Issue 726062-Linux.mp4
1.2 MB View Download
Please enable this flag to get the checkbox: chrome://flags/#enable-offer-store-unmasked-wallet-cards

Comment 25 by jsaul@google.com, Jun 6 2017

Chiming in: That is indeed expected behavior; the ability to save locally is currently disabled by default on Linux.

Sign in to add a comment