MD settings don't allow you to re-mask a Google card |
|||||||||||||
Issue descriptionChrome Version: 58.0.3029.110 (Official Build) (64-bit) OS: OS X What steps will reproduce the problem? (1) Be signed into Chrome (2) Have a card in your google account (payments.google.com) (3) Have unmasked a card (e.g. go to https://rsolomakhin.github.io/autofill/ to use the card, type in your CVC, and leave the box checked to save copy locally) What is the expected result? In chrome://settings/autofill you should be able to "Clear copy" of the saved card What happens instead? The "Clear copy" option has been removed in material settings
,
May 24 2017
Zach: This works fine for me on Mac. I do notice that "Copied to Chrome [Clear copy]" only appears if you hover over the entry, just like the other [Edit] buttons. Is this perhaps the cause behind your bug?
,
May 24 2017
Are you at chrome://md-settings?
,
May 24 2017
Ah, nope, I was at chrome://settings/autofill because that's what the bug referenced. :) I see the problem now, thanks.
,
May 26 2017
We could disable "OfferStoreUnmaskedWalletCards" feature flag until this bug is fixed, or if this bug is not fixed in time. https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_experiments.cc?l=172&rcl=88677427eb90210e1f60202602a3dc1eace69da5
,
May 26 2017
Bumping up the priority because it's a privacy issue.
,
May 26 2017
FWIW, there is a workaround for the missing "Clear Copy". If the user signs out of Chrome we clear these copies.
,
May 26 2017
I think easiest way to solve this would just be to add the three dot menu to all cards, and on the ones from Google Payments add two options: * Clear copy (if there is a locally saved copy) * Edit (which takes you to payments.google.com)
,
Jun 2 2017
Taking this since it's in 59
,
Jun 2 2017
I'm uploading CL soon. Upping priority in case we need to take action. This seems serious.
,
Jun 2 2017
Thanks Hector; much appreciated.
,
Jun 2 2017
http://crrev.com/2919873003 CL under review now
,
Jun 2 2017
Thanks Hector for taking this issue.
,
Jun 2 2017
,
Jun 2 2017
P0 -> P1 We have 2 workarounds: 1. Log out of Chrome + Log back in 2. Go to web and remove card, this will remove from Chrome also
,
Jun 2 2017
Changing to M-60 as per email conversation
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4614abca043a0d6f46575068d605f0af3cf749cd commit 4614abca043a0d6f46575068d605f0af3cf749cd Author: hcarmona <hcarmona@chromium.org> Date: Fri Jun 02 22:26:44 2017 Allow clearing local CC details R=dschuyler@chromium.org,dpapad@chromium.org BUG= 726062 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2919873003 Cr-Commit-Position: refs/heads/master@{#476817} [modify] https://crrev.com/4614abca043a0d6f46575068d605f0af3cf749cd/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/4614abca043a0d6f46575068d605f0af3cf749cd/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
,
Jun 5 2017
Requesting merge to M60. Fix is landed in Canary, verified it's working on Version 61.0.3119.0 (Official Build) canary (64-bit)
,
Jun 5 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ccb5bb42f0f5f969cb057175cc291fb3d594a21 commit 7ccb5bb42f0f5f969cb057175cc291fb3d594a21 Author: Hector Carmona <hcarmona@chromium.org> Date: Mon Jun 05 23:50:27 2017 Allow clearing local CC details R=dschuyler@chromium.org,dpapad@chromium.org BUG= 726062 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2919873003 Cr-Original-Commit-Position: refs/heads/master@{#476817} Review-Url: https://codereview.chromium.org/2920223005 . Cr-Commit-Position: refs/branch-heads/3112@{#172} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/7ccb5bb42f0f5f969cb057175cc291fb3d594a21/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/7ccb5bb42f0f5f969cb057175cc291fb3d594a21/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
,
Jun 5 2017
,
Jun 6 2017
Tested this issue on Windows 10, Ubuntu 14.04 and Mac 10.12.4 with chrome #60.0.3112.20 as per steps mentioned in the comment #0. Observed that in Windows and Mac, while entering the CVV the check box was selected to save the copy on local device and after saving it, i was able to delete the copy from "chrome://settings/autofill", whereas in Ubuntu while entering the CVV the check box was not available to save copy on local device. Attaching screen-cast for reference hcarmona@ Could you please look into it and confirm this expected behavior of this issue.
,
Jun 6 2017
the Linux Screen-cast
,
Jun 6 2017
Please enable this flag to get the checkbox: chrome://flags/#enable-offer-store-unmasked-wallet-cards
,
Jun 6 2017
Chiming in: That is indeed expected behavior; the ability to save locally is currently disabled by default on Linux. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by csashi@google.com
, May 24 2017Owner: jsaul@google.com
Status: Assigned (was: Untriaged)