New issue
Advanced search Search tips

Issue 726061 link

Starred by 1 user
Status: Fixed
Owner:
yus...@chromium.org
Closed: May 2017
Cc:
wychen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: ----
Type: ----



Sign in to add a comment

clank_junit_tests failing on internal.client.clank/test-phone

Project Member Reported by wychen@chromium.org, May 24 2017 
clank_junit_tests failing on internal.client.clank/test-phone

Builders failed on: 
- test-phone: 
  http://master7.golo.chromium.org/i/internal.client.clank/builders/test-phone

https://uberchromegw.corp.google.com/i/internal.client.clank/builders/test-phone/builds/5929/steps/clank_junit_tests/logs/stdio

Caused by: java.lang.NullPointerException
	at android.preference.PreferenceManager.getDefaultSharedPreferencesName(PreferenceManager.java:498)
	at android.preference.PreferenceManager.getDefaultSharedPreferences(PreferenceManager.java:487)
	at org.chromium.base.ContextUtils.fetchAppSharedPreferences(ContextUtils.java:70)
	at org.chromium.base.ContextUtils.access$000(ContextUtils.java:19)
	at org.chromium.base.ContextUtils$Holder.<clinit>(ContextUtils.java:28)
	at org.chromium.base.ContextUtils.getAppSharedPreferences(ContextUtils.java:81)
	at org.chromium.chrome.browser.locale.LocaleManager.<init>(LocaleManager.java:107)
	at com.google.android.apps.chrome.locale.LocaleManagerInternal.<init>(LocaleManagerInternal.java:44)
	at com.google.android.apps.chrome.locale.LocaleManagerInternalUnitTest.<init>(LocaleManagerInternalUnitTest.java:65)
	... 28 more

Likely culprit:
https://codereview.chromium.org/2898823002
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c85db9e48e29888204b45335c1b0e309441d2f8a

commit c85db9e48e29888204b45335c1b0e309441d2f8a
Author: wychen <wychen@chromium.org>
Date: Wed May 24 20:37:16 2017

Revert "Add metrics for search engine promo and search widget"

This reverts commit d307666724e1a3a49943b035271723135be40829.

Reason for revert:
broke clank_junit_tests.  crbug.com/726061 

Original issue's description:
> Add metrics for search engine promo and search widget
>
> - Adds histograms and user action for search widget use
> - Add histogram definitions around search engine promo use and
> selections
> - Add LocaleManager refactoring to route the signals that are important
> for metrics
>
> BUG=724349, 724348
> Review-Url: https://codereview.chromium.org/2898823002
> Cr-Commit-Position: refs/heads/master@{#474203}
> Committed: https://chromium.googlesource.com/chromium/src/+/d307666724e1a3a49943b035271723135be40829

TBR=yusufo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 726061 

Review-Url: https://codereview.chromium.org/2897363003
Cr-Commit-Position: refs/heads/master@{#474404}

[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/android/BUILD.gn
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelper.java
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelperTest.java
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/browser/android/locale/locale_manager.cc
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/browser/android/locale/locale_manager.h
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/browser/search_engines/template_url_service_android.cc
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/chrome/browser/search_engines/template_url_service_android.h
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/components/search_engines/BUILD.gn
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/components/search_engines/search_engine_type.h
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/tools/metrics/actions/actions.xml
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/c85db9e48e29888204b45335c1b0e309441d2f8a/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e6c29b66c4e874eaad2c690bc085f43780cd4f2

commit 9e6c29b66c4e874eaad2c690bc085f43780cd4f2
Author: wychen <wychen@chromium.org>
Date: Wed May 24 21:27:42 2017

Reland "Add metrics for search engine promo and search widget"

Reason for revert:
already fixed downstream in https://chrome-internal-review.googlesource.com/380388

> Revert "Add metrics for search engine promo and search widget"
>
> This reverts commit d307666724e1a3a49943b035271723135be40829.
>
> Reason for revert:
> broke clank_junit_tests.  crbug.com/726061 
>
> Original issue's description:
> > Add metrics for search engine promo and search widget
> >
> > - Adds histograms and user action for search widget use
> > - Add histogram definitions around search engine promo use and
> > selections
> > - Add LocaleManager refactoring to route the signals that are important
> > for metrics
> >
> > BUG=724349, 724348
> > Review-Url: https://codereview.chromium.org/2898823002
> > Cr-Commit-Position: refs/heads/master@{#474203}
> > Committed: https://chromium.googlesource.com/chromium/src/+/d307666724e1a3a49943b035271723135be40829
>
> TBR=yusufo@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 726061 
>
> Review-Url: https://codereview.chromium.org/2897363003
> Cr-Commit-Position: refs/heads/master@{#474404}

TBR=yusufo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 726061 

Review-Url: https://codereview.chromium.org/2902913003
Cr-Commit-Position: refs/heads/master@{#474428}

[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/android/BUILD.gn
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelper.java
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelperTest.java
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/browser/android/locale/locale_manager.cc
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/browser/android/locale/locale_manager.h
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/browser/search_engines/template_url_service_android.cc
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/chrome/browser/search_engines/template_url_service_android.h
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/components/search_engines/BUILD.gn
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/components/search_engines/search_engine_type.h
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/tools/metrics/actions/actions.xml
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/9e6c29b66c4e874eaad2c690bc085f43780cd4f2/tools/metrics/histograms/histograms.xml

Comment 3 by wychen@chromium.org, May 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment