New issue
Advanced search Search tips

Issue 726045 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 673589
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MacViews] Wire up FindBarView

Project Member Reported by ellyjo...@chromium.org, May 24 2017

Issue description

FindBarView needs a DropdownBarHost, and it uses a BrowserView as its host. Do we have a BrowserView shim for Mac?
 

Comment 1 by tapted@chromium.org, May 25 2017

Cc: lgrey@chromium.org
Mergedinto: 673589
Status: Duplicate (was: Assigned)
There's no shim.

For the fullscreen bubble we made ExclusiveAccessControllerViews to bridge the gap - https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h?ssfr=1

It nicely fits the "favour composition over inheritance" guideline that we suggest at https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#Multiple-inheritance

(i.e. https://codereview.chromium.org/1650483002 moved ExclusiveAccessContext from a parent of BrowserWindowCocoa to a component).

We probably need something similar for FindBarHost

Anyway I think we are already tracking this in  Issue 673589  - there are some notes there

Sign in to add a comment