New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726043 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: ----
Type: ----



Sign in to add a comment

Generate Orderfile failing on internal.client.clank/orderfile-clankium

Project Member Reported by wychen@chromium.org, May 24 2017

Issue description

Generate Orderfile failing on internal.client.clank/orderfile-clankium

Builders failed on: 
- orderfile-clankium: 
  http://master7.golo.chromium.org/i/internal.client.clank/builders/orderfile-clankium

https://uberchromegw.corp.google.com/i/internal.client.clank/builders/orderfile-clankium

Error message from https://uberchromegw.corp.google.com/i/internal.client.clank/builders/orderfile-clankium/builds/5258/steps/Generate%20Orderfile/logs/stdio

obj/chrome/browser/ui/libui.a(translate_compact_infobar.o):translate_compact_infobar.cc:function translate::TranslateInfoBarDelegate::Observer::Observer(): error: undefined reference to 'vtable for translate::TranslateInfoBarDelegate::Observer'

Likely culprit:
https://codereview.chromium.org/2894553002



 
Thanks for the report, investigating now
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23aebb59595b4be9d0ec2d9272cf3c596dd9f2bd

commit 23aebb59595b4be9d0ec2d9272cf3c596dd9f2bd
Author: googleo <googleo@chromium.org>
Date: Thu May 25 04:54:58 2017

Fix "Generate Orderfile failing on internal.client.clank/orderfile-clankium"
Error: The vtable symbol may be undefined because the class is missing its key function
(see go/missingkeymethod)

BUG= 726043 
TBR=groby@chromium.org

Review-Url: https://codereview.chromium.org/2902353002
Cr-Commit-Position: refs/heads/master@{#474556}

[modify] https://crrev.com/23aebb59595b4be9d0ec2d9272cf3c596dd9f2bd/components/translate/core/browser/translate_infobar_delegate.h

Comment 3 by guidou@chromium.org, May 26 2017

Labels: -Sheriff-Chromium

Comment 4 by wychen@chromium.org, May 26 2017

Status: Verified (was: Assigned)

Sign in to add a comment