Expand perf_data_generator to allow stopping scheduling all benchmarks on a particular device |
|||
Issue descriptionIdeally the steps for stopping scheduling all benchmarks on a particular device should look like this: 1) Add device id to a DEVICE_BLACK_LIST list 2) Run tools/perf/generate_perf_data 3) Send the CL to martiniss@ for review & land it.
,
May 25 2017
Code for this was landed in https://chromium-review.googlesource.com/c/514345/ Stephen: can you also change it so that running tools/perf/generate_perf_data will print to stdout things like: Device "abcd" is blacklisted, these benchmarks are not scheduled: * ... * ... * ... Device "eefg" is blacklisted, these benchmarks are not scheduled: * ... * ... This would be useful for coordinating with perf sherrifs about upcoming stoppage alert.
,
May 25 2017
Ok, will do.
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74545c81cc8998d6ea435a79330e4c5be506b36e commit 74545c81cc8998d6ea435a79330e4c5be506b36e Author: Stephen Martinis <martiniss@chromium.org> Date: Fri May 26 21:54:05 2017 //tools/perf: Print information when not scheduling benchmarks When we don't schedule benchmarks, print something when you're generating perf data. Bug: 726037 Change-Id: Iecef39ddb1a310917d3a1ee6e8a042be5f621c6b Reviewed-on: https://chromium-review.googlesource.com/516527 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#475148} [modify] https://crrev.com/74545c81cc8998d6ea435a79330e4c5be506b36e/tools/perf/core/perf_data_generator.py [modify] https://crrev.com/74545c81cc8998d6ea435a79330e4c5be506b36e/tools/perf/core/perf_data_generator_unittest.py
,
Jul 14 2017
,
Dec 28 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nedngu...@google.com
, May 24 2017