HttpNetworkTransactionTest.UseIPConnectionPoolingWithHostCacheExpiration is broken |
|||
Issue descriptionHttpNetworkTransactionTest.UseIPConnectionPoolingWithHostCacheExpiration creates a OneTimeCachingHostResolver for use in the test, but then creates an HttpNetworkSession that doesn't actually use it. It looks like this was broken in https://chromiumcodereview.appspot.com/11348333. Fixing the test to actually use the OneTimeCachingHostResolver causes the test to fail. It's unclear if this is indicative of a real bug, or a change in assumptions since the test was originally written. It also looks like the test was marked as flaky at the time that CL landed, which may or may not be relevant to the failures when the bug is fixed. Marking this as P1 - I think determining if the test failing when the bug is fixied indicates whether there's a real bug is pretty high priority. If there's no bug, and it's just a test issue, fixing it seems a bit lower priority.
,
May 25 2017
Thank you for uncovering the problem and filing this issue.
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dcd8194cc47b97f5c3165d35a24356b45659ccc commit 6dcd8194cc47b97f5c3165d35a24356b45659ccc Author: bnc <bnc@chromium.org> Date: Thu May 25 20:11:50 2017 Fix HttpNetworkTransactionTest.UseIPConnectionPoolingWithHostCacheExpiration. BUG= 726027 Review-Url: https://codereview.chromium.org/2902383002 Cr-Commit-Position: refs/heads/master@{#474773} [modify] https://crrev.com/6dcd8194cc47b97f5c3165d35a24356b45659ccc/net/http/http_network_transaction_unittest.cc
,
May 26 2017
Turns out test is easy to fix, seems like functionality is not broken. |
|||
►
Sign in to add a comment |
|||
Comment 1 by rch@chromium.org
, May 24 2017